From: James Clark <james.clark@arm.com>
To: acme@kernel.org, namhyung@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
will@kernel.org, James Clark <james.clark@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
bpf@vger.kernel.org
Subject: [RFC PATCH 0/4] Add VG register attr test with kernel version and feature detection
Date: Tue, 27 Sep 2022 16:41:00 +0100 [thread overview]
Message-ID: <20220927154104.869029-1-james.clark@arm.com> (raw)
This is the kind of test that I would like to add for VG, with the
necessary additions to the attr test framework for kernel version
detection so that it always passes even when run on old kernels.
This approach isn't very scalable, for example the change to fix the
tests for PERF_FORMAT_LOST [1] affects many tests so they would all have
to be duplicated. Of course there is still the option to weaken those
tests and make them accept any value.
It also doesn't apply to any of the shell script tests which would need
to re-implement something similar to this.
I'm interested to see if people think this is useful, at least it is for
this one test.
[1]: https://lore.kernel.org/linux-perf-users/20220926144948.223641-1-james.clark@arm.com/T/#t
James Clark (4):
perf test: Add ability to test exit code for attr tests
perf test: Add mechanism for skipping attr tests on auxiliary vector
values
perf test: Add mechanism for skipping attr tests on kernel versions
perf test arm64: Add attr tests for new VG register
tools/perf/tests/attr.py | 71 +++++++++++++++++--
.../attr/test-record-user-regs-no-sve-aarch64 | 9 +++
.../test-record-user-regs-old-sve-aarch64 | 10 +++
.../attr/test-record-user-regs-sve-aarch64 | 14 ++++
4 files changed, 99 insertions(+), 5 deletions(-)
create mode 100644 tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64
create mode 100644 tools/perf/tests/attr/test-record-user-regs-old-sve-aarch64
create mode 100644 tools/perf/tests/attr/test-record-user-regs-sve-aarch64
--
2.28.0
next reply other threads:[~2022-09-27 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 15:41 James Clark [this message]
2022-09-27 15:41 ` [RFC PATCH 1/4] perf test: Add ability to test exit code for attr tests James Clark
2022-09-27 15:41 ` [RFC PATCH 2/4] perf test: Add mechanism for skipping attr tests on auxiliary vector values James Clark
2022-09-27 15:41 ` [RFC PATCH 3/4] perf test: Add mechanism for skipping attr tests on kernel versions James Clark
2022-09-27 15:41 ` [RFC PATCH 4/4] perf test arm64: Add attr tests for new VG register James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927154104.869029-1-james.clark@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.