All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	rui.zhang@intel.com, "Raju Rangoju" <rajur@chelsio.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Peter Kaestle" <peter@piie.net>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Mark Gross" <markgross@kernel.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Amit Kucheria" <amitk@kernel.org>,
	"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
	"Broadcom Kernel Team" <bcm-kernel-feedback-list@broadcom.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Support Opensource" <support.opensource@diasemi.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Thara Gopinath" <thara.gopinath@linaro.org>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Eduardo Valentin" <edubezval@gmail.com>,
	Keerthy <j-keerthy@ti.com>,
	"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Antoine Tenart" <atenart@kernel.org>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Dmitry Osipenko" <digetx@gmail.com>,
	netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-omap@vger.kernel.org,
	"Adam Ward" <DLG-Adam.Ward.opensource@dm.renesas.com>
Subject: [PATCH v8 24/29] thermal/drivers/da9062: Use generic thermal_zone_get_trip() function
Date: Mon,  3 Oct 2022 11:25:57 +0200	[thread overview]
Message-ID: <20221003092602.1323944-25-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20221003092602.1323944-1-daniel.lezcano@linaro.org>

The thermal framework gives the possibility to register the trip
points with the thermal zone. When that is done, no get_trip_* ops are
needed and they can be removed.

Convert ops content logic into generic trip points and register them with the
thermal zone.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>
---
 drivers/thermal/da9062-thermal.c | 52 +++++---------------------------
 1 file changed, 8 insertions(+), 44 deletions(-)

diff --git a/drivers/thermal/da9062-thermal.c b/drivers/thermal/da9062-thermal.c
index 180edec34e07..1e163e90d6b6 100644
--- a/drivers/thermal/da9062-thermal.c
+++ b/drivers/thermal/da9062-thermal.c
@@ -120,44 +120,6 @@ static irqreturn_t da9062_thermal_irq_handler(int irq, void *data)
 	return IRQ_HANDLED;
 }
 
-static int da9062_thermal_get_trip_type(struct thermal_zone_device *z,
-					int trip,
-					enum thermal_trip_type *type)
-{
-	struct da9062_thermal *thermal = z->devdata;
-
-	switch (trip) {
-	case 0:
-		*type = THERMAL_TRIP_HOT;
-		break;
-	default:
-		dev_err(thermal->dev,
-			"Driver does not support more than 1 trip-wire\n");
-		return -EINVAL;
-	}
-
-	return 0;
-}
-
-static int da9062_thermal_get_trip_temp(struct thermal_zone_device *z,
-					int trip,
-					int *temp)
-{
-	struct da9062_thermal *thermal = z->devdata;
-
-	switch (trip) {
-	case 0:
-		*temp = DA9062_MILLI_CELSIUS(125);
-		break;
-	default:
-		dev_err(thermal->dev,
-			"Driver does not support more than 1 trip-wire\n");
-		return -EINVAL;
-	}
-
-	return 0;
-}
-
 static int da9062_thermal_get_temp(struct thermal_zone_device *z,
 				   int *temp)
 {
@@ -172,8 +134,10 @@ static int da9062_thermal_get_temp(struct thermal_zone_device *z,
 
 static struct thermal_zone_device_ops da9062_thermal_ops = {
 	.get_temp	= da9062_thermal_get_temp,
-	.get_trip_type	= da9062_thermal_get_trip_type,
-	.get_trip_temp	= da9062_thermal_get_trip_temp,
+};
+
+static struct thermal_trip trips[] = {
+	{ .temperature = DA9062_MILLI_CELSIUS(125), .type = THERMAL_TRIP_HOT },
 };
 
 static const struct da9062_thermal_config da9062_config = {
@@ -228,10 +192,10 @@ static int da9062_thermal_probe(struct platform_device *pdev)
 	INIT_DELAYED_WORK(&thermal->work, da9062_thermal_poll_on);
 	mutex_init(&thermal->lock);
 
-	thermal->zone = thermal_zone_device_register(thermal->config->name,
-					1, 0, thermal,
-					&da9062_thermal_ops, NULL, pp_tmp,
-					0);
+	thermal->zone = thermal_zone_device_register_with_trips(thermal->config->name,
+								trips, ARRAY_SIZE(trips), 0, thermal,
+								&da9062_thermal_ops, NULL, pp_tmp,
+								0);
 	if (IS_ERR(thermal->zone)) {
 		dev_err(&pdev->dev, "Cannot register thermal zone device\n");
 		ret = PTR_ERR(thermal->zone);
-- 
2.34.1


  parent reply	other threads:[~2022-10-03  9:31 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221003092704eucas1p2875c1f996dfd60a58f06cf986e02e8eb@eucas1p2.samsung.com>
2022-10-03  9:25 ` [PATCH v8 00/29] Rework the trip points creation Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 01/29] thermal/core: Add a generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2023-03-12 12:14     ` [PATCH v8 01/29] " Ido Schimmel
2023-03-13 10:45       ` Daniel Lezcano
2023-03-13 12:12         ` Ido Schimmel
2022-10-03  9:25   ` [PATCH v8 02/29] thermal/sysfs: Always expose hysteresis attributes Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 03/29] thermal/core: Add a generic thermal_zone_set_trip() function Daniel Lezcano
2022-10-03 11:56     ` Rafael J. Wysocki
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 04/29] thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 05/29] thermal/of: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 06/29] thermal/of: Remove unused functions Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 07/29] thermal/drivers/exynos: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 08/29] thermal/drivers/exynos: of_thermal_get_ntrips() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 09/29] thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 10/29] thermal/drivers/tegra: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 11/29] thermal/drivers/uniphier: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 12/29] thermal/drivers/hisi: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 13/29] thermal/drivers/qcom: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 14/29] thermal/drivers/armada: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 15/29] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 16/29] thermal/of: Remove of_thermal_get_ntrips() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 17/29] thermal/of: Remove of_thermal_is_trip_valid() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 18/29] thermal/of: Remove of_thermal_set_trip_hyst() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 19/29] thermal/of: Remove of_thermal_get_crit_temp() Daniel Lezcano
2022-10-03 12:50     ` Marek Szyprowski
2022-10-03 12:50       ` Marek Szyprowski
2022-10-03 13:29       ` [PATCH] thermal/drivers/exynos: Fix NULL pointer dereference when getting the critical temp Daniel Lezcano
2022-10-03 13:29         ` Daniel Lezcano
2022-10-03 13:40         ` Krzysztof Kozlowski
2022-10-03 13:40           ` Krzysztof Kozlowski
2022-10-03 13:50         ` Marek Szyprowski
2022-10-03 13:50           ` Marek Szyprowski
2022-10-17 13:48         ` Marek Szyprowski
2022-10-17 13:48           ` Marek Szyprowski
2022-10-17 14:14           ` Daniel Lezcano
2022-10-17 14:14             ` Daniel Lezcano
2022-10-03 13:31       ` [PATCH v8 19/29] thermal/of: Remove of_thermal_get_crit_temp() Daniel Lezcano
2022-10-03 13:31         ` Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 20/29] thermal/drivers/st: Use generic trip points Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 21/29] thermal/drivers/imx: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 22/29] thermal/drivers/rcar: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 23/29] thermal/drivers/broadcom: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` Daniel Lezcano [this message]
2022-12-09 15:26     ` [thermal: thermal/next] thermal/drivers/da9062: " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 25/29] thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 26/29] thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:26   ` [PATCH v8 27/29] thermal/drivers/cxgb4: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:26   ` [PATCH v8 28/29] thermal/intel/int340x: Replace parameter to simplify Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:26   ` [PATCH v8 29/29] thermal/drivers/intel: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03 14:10   ` [PATCH v8 00/29] Rework the trip points creation Marek Szyprowski
2022-10-03 14:10     ` Marek Szyprowski
2022-10-03 15:36     ` Daniel Lezcano
2022-10-03 15:36       ` Daniel Lezcano
2022-10-03 21:18     ` Daniel Lezcano
2022-10-03 21:18       ` Daniel Lezcano
2022-10-05 12:37       ` Daniel Lezcano
2022-10-05 12:37         ` Daniel Lezcano
2022-10-05 13:05         ` Marek Szyprowski
2022-10-05 13:05           ` Marek Szyprowski
2022-10-06  6:55           ` Daniel Lezcano
2022-10-06  6:55             ` Daniel Lezcano
2022-10-06 16:25             ` Marek Szyprowski
2022-10-06 16:25               ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221003092602.1323944-25-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=DLG-Adam.Ward.opensource@dm.renesas.com \
    --cc=agross@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=amitk@kernel.org \
    --cc=atenart@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=bzolnier@gmail.com \
    --cc=davem@davemloft.net \
    --cc=digetx@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=festevam@gmail.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=hdegoede@redhat.com \
    --cc=j-keerthy@ti.com \
    --cc=jonathanh@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=markgross@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=nsaenz@kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peter@piie.net \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rajur@chelsio.com \
    --cc=rjui@broadcom.com \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sbranden@broadcom.com \
    --cc=shawnguo@kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=support.opensource@diasemi.com \
    --cc=thara.gopinath@linaro.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.