All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Jason Wang" <jasowang@redhat.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>, "Greg Kurz" <groug@kaod.org>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH v10 14/17] qemu-sockets: update socket_uri() and socket_parse() to be consistent
Date: Wed,  5 Oct 2022 18:20:48 +0200	[thread overview]
Message-ID: <20221005162051.1120041-15-lvivier@redhat.com> (raw)
In-Reply-To: <20221005162051.1120041-1-lvivier@redhat.com>

To be consistent with socket_uri(), add 'tcp:' prefix for inet type in
socket_parse(), by default socket_parse() use tcp when no prefix is
provided (format is host:port).

In socket_uri(), use 'vsock:' prefix for vsock type rather than 'tcp:'
because it makes a vsock address look like an inet address with CID
misinterpreted as host.
Goes back to commit 9aca82ba31 "migration: Create socket-address parameter"

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
---
 util/qemu-sockets.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 9f6f655fd526..a9926af714c4 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -1090,7 +1090,7 @@ char *socket_uri(SocketAddress *addr)
     case SOCKET_ADDRESS_TYPE_FD:
         return g_strdup_printf("fd:%s", addr->u.fd.str);
     case SOCKET_ADDRESS_TYPE_VSOCK:
-        return g_strdup_printf("tcp:%s:%s",
+        return g_strdup_printf("vsock:%s:%s",
                                addr->u.vsock.cid,
                                addr->u.vsock.port);
     default:
@@ -1124,6 +1124,11 @@ SocketAddress *socket_parse(const char *str, Error **errp)
         if (vsock_parse(&addr->u.vsock, str + strlen("vsock:"), errp)) {
             goto fail;
         }
+    } else if (strstart(str, "tcp:", NULL)) {
+        addr->type = SOCKET_ADDRESS_TYPE_INET;
+        if (inet_parse(&addr->u.inet, str + strlen("tcp:"), errp)) {
+            goto fail;
+        }
     } else {
         addr->type = SOCKET_ADDRESS_TYPE_INET;
         if (inet_parse(&addr->u.inet, str, errp)) {
-- 
2.37.3



  parent reply	other threads:[~2022-10-05 16:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 16:20 [PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 01/17] net: introduce convert_host_port() Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 02/17] net: remove the @errp argument of net_client_inits() Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 03/17] net: simplify net_client_parse() error management Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 04/17] qapi: net: introduce a way to bypass qemu_opts_parse_noisily() Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 05/17] net: introduce qemu_set_info_str() function Laurent Vivier
2022-10-06  8:08   ` David Gibson
2022-10-05 16:20 ` [PATCH v10 06/17] qapi: net: add stream and dgram netdevs Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 07/17] net: socket: Don't ignore EINVAL on netdev socket connection Laurent Vivier
2022-10-06  8:13   ` David Gibson
2022-10-05 16:20 ` [PATCH v10 08/17] net: stream: " Laurent Vivier
2022-10-06  8:14   ` David Gibson
2022-10-05 16:20 ` [PATCH v10 09/17] net: stream: add unix socket Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 10/17] net: dgram: make dgram_dst generic Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 11/17] net: dgram: move mcast specific code from net_socket_fd_init_dgram() Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 12/17] net: dgram: add unix socket Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 13/17] qemu-sockets: move and rename SocketAddress_to_str() Laurent Vivier
2022-10-05 16:20 ` Laurent Vivier [this message]
2022-10-05 16:20 ` [PATCH v10 15/17] net: stream: move to QIO to enable additional parameters Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 16/17] tests/qtest: netdev: test stream and dgram backends Laurent Vivier
2022-10-05 16:20 ` [PATCH v10 17/17] net: stream: add QAPI events to report connection state Laurent Vivier
2022-10-06 11:20 ` [PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend Michael S. Tsirkin
2022-10-09  5:52   ` Jason Wang
2022-10-11 20:04     ` Laurent Vivier
2022-10-12  1:18       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221005162051.1120041-15-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=groug@kaod.org \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.