All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Stephan Gerhold <stephan@gerhold.net>,
	Shawn Guo <shawn.guo@linaro.org>, Vinod Koul <vkoul@kernel.org>,
	krishna Lanka <quic_vamslank@quicinc.com>,
	Sivaprakash Murugesan <sivaprak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh@kernel.org>
Subject: [PATCH v4 07/34] dt-bindings: pinctrl: qcom,tlmm-common: add common check for function
Date: Thu,  6 Oct 2022 14:46:32 +0200	[thread overview]
Message-ID: <20221006124659.217540-8-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20221006124659.217540-1-krzysztof.kozlowski@linaro.org>

Certain pins, like SDcard related, do not have functions and such should
not be required.  Add a check for this in common Qualcomm TLMM pin
controller schema.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../bindings/pinctrl/qcom,tlmm-common.yaml    | 20 +++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
index c88c8dcb69d9..e1354f0c64f8 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
@@ -65,10 +65,6 @@ additionalProperties: true
 
 $defs:
   qcom-tlmm-state:
-    allOf:
-      - $ref: pincfg-node.yaml#
-      - $ref: pinmux-node.yaml#
-
     properties:
       drive-strength:
         enum: [2, 4, 6, 8, 10, 12, 14, 16]
@@ -82,5 +78,21 @@ $defs:
       output-high: true
       output-low: true
 
+    allOf:
+      - $ref: pincfg-node.yaml#
+      - $ref: pinmux-node.yaml#
+
+      - if:
+          properties:
+            pins:
+              items:
+                pattern: "^gpio"
+        then:
+          required:
+            - function
+        else:
+          properties:
+            function: false
+
     additionalProperties: true
 ...
-- 
2.34.1


  parent reply	other threads:[~2022-10-06 12:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 12:46 [PATCH v4 00/34] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings (third set) Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 01/34] arm64: dts: qcom: ipq6018-cp01-c1: use BLSPI1 pins Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 02/34] arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 03/34] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 04/34] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 05/34] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 06/34] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-10-06 12:46 ` Krzysztof Kozlowski [this message]
2022-10-06 12:46 ` [PATCH v4 08/34] dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 09/34] dt-bindings: pinctrl: qcom,ipq6018: correct BLSP6->BLSP0 functions Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 10/34] dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 11/34] dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 12/34] dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 13/34] dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 14/34] dt-bindings: pinctrl: qcom,msm8226: fix matching pin config Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 15/34] dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 16/34] dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 17/34] dt-bindings: pinctrl: qcom,msm8226: fix indentation in example Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 18/34] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 19/34] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 20/34] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 21/34] dt-bindings: pinctrl: qcom,msm8953: fix matching pin config Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 22/34] dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 23/34] dt-bindings: pinctrl: qcom,msm8953: fix indentation in example Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 24/34] dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 25/34] dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 26/34] dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 27/34] dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 28/34] dt-bindings: pinctrl: qcom,sdx55: fix matching pin config Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 29/34] dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 30/34] dt-bindings: pinctrl: qcom,sdx55: fix indentation in example Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 31/34] dt-bindings: pinctrl: qcom,sdx65: fix matching pin config Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 32/34] dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 33/34] dt-bindings: pinctrl: qcom,sc7280: fix matching pin config Krzysztof Kozlowski
2022-10-06 12:46 ` [PATCH v4 34/34] dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece) Krzysztof Kozlowski
2022-10-18  3:05 ` (subset) [PATCH v4 00/34] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings (third set) Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221006124659.217540-8-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_vamslank@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=sivaprak@codeaurora.org \
    --cc=stephan@gerhold.net \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.