All of lore.kernel.org
 help / color / mirror / Atom feed
From: Angela Czubak <acz@semihalf.com>
To: linux-input@vger.kernel.org
Cc: upstream@semihalf.com, benjamin.tissoires@redhat.com,
	jikos@kernel.org, dmitry.torokhov@gmail.com,
	Angela Czubak <acz@semihalf.com>
Subject: [PATCH v4 00/17] *** Implement simple haptic HID support ***
Date: Fri,  7 Oct 2022 18:29:28 +0000	[thread overview]
Message-ID: <20221007182945.1654046-1-acz@semihalf.com> (raw)

This patch series introduces changes necessary to support devices
using simple haptic HID pages.
Implementation attempts to follow the discussion below:
https://www.spinics.net/lists/linux-input/msg61091.html

Introduce new haptic defines as specified in HID Usage Tables.

Add new force feedback effect type in order to facilitate using
simple haptic force feedback.

Add INPUT_PROP_HAPTIC_TOUCHPAD to mark touchpad exposing simple haptic
support.

Add new struct hid_haptic_device so as to gather simple haptic related
configuration and current state of the device.

Add new functions to be triggered during HID input mapping and
configuration in order to detect simple haptic devices.

Modify HID input so that haptic output reports are parsed.

Initialize a haptic device.

Modify FF core so that effect IDs can be shared between multiple open file
handles.

Add shared release and press effects for a simple haptic device.

Calculate pressure resolution if units are grams or newtons.

Add support for kernel-driven mode of simple haptic device.

Toggle ABS_PRESSURE generation by input-mt on request.

Implement functions allowing switching between kernel-managed mode
and autonomous mode.

Add simple haptic support for hid-multitouch driver.

Implement EVIOCFF(TAKE|RELEASE)CONTROL ioctls so that userspace can take
and release control of shared release and press effects.

v2:
- Describe INPUT_PROP_HAPTIC_TOUCHPAD in
  Documentation/input/event-codes.rst
- Do not extract mt_get_feature(), use hid_hw_wait() instead
- Define HID_UNIT_GRAM and HID_UNIT_NEWTON
- Calculate pressure sum in input-mt if INPUT_MT_TOTAL_FORCE flags set
- Use u* instead of __u* in struct hid_haptic_device
- Solve problems with report IDS >= 0xF as Dmitry suggests

v3:
- Get rid of INPUT_PROP_HAPTIC_TOUCHPAD property as haptic device does not
  gave to be a touchpad
- Introduce notion of haptic forcepads; generate haptic feedback in kernel
  mode only for forcepads
- Generate clicks based on maximum pressure across slots instead of the sum
- Fix off-by-one bug in hid_haptic_upload_effect()
- Fix resume/suspend: issue hid_haptic_resume() in mt_resume() and
  hid_haptic_suspend() in mt_suspend()
- Add reset callback for HID i2c devices
- Implement reset callback for HID multitouch haptic devices
- Implement lid handler triggering touchpad recalibration for Redrix

v4:
- Fix mt_reset callback to end earlier if no input devices have been
  configured yet to avoid iterating over uninitialized hid->inputs list

Angela Czubak (17):
  HID: add haptics page defines
  Input: add FF_HID effect type
  HID: haptic: introduce hid_haptic_device
  HID: input: allow mapping of haptic output
  HID: haptic: initialize haptic device
  Input: add shared effects
  HID: haptic: implement release and press effects
  HID: input: calculate resolution for pressure
  HID: haptic: add functions handling events
  Input: MT - add INPUT_MT_MAX_FORCE flags
  HID: haptic: add hid_haptic_switch_mode
  HID: multitouch: add haptic multitouch support
  Input: introduce EVIOCFF(TAKE|RELEASE)CONTROL
  HID: haptic: add hid_haptic_change_control
  HID: add HID device reset callback
  HID: haptic: implement HID haptic reset callback
  HID: multitouch: Add lid handler for touchpad on Redrix chromebook

 drivers/hid/Kconfig                |  14 +
 drivers/hid/Makefile               |   1 +
 drivers/hid/hid-haptic.c           | 753 +++++++++++++++++++++++++++++
 drivers/hid/hid-haptic.h           | 152 ++++++
 drivers/hid/hid-input.c            |  18 +-
 drivers/hid/hid-multitouch.c       | 313 +++++++++++-
 drivers/hid/i2c-hid/i2c-hid-core.c |  21 +
 drivers/input/evdev.c              |   6 +
 drivers/input/ff-core.c            | 129 ++++-
 drivers/input/input-mt.c           |  16 +-
 include/linux/hid.h                |  31 ++
 include/linux/input.h              |   5 +
 include/linux/input/mt.h           |   1 +
 include/uapi/linux/input.h         |  26 +-
 14 files changed, 1469 insertions(+), 17 deletions(-)
 create mode 100644 drivers/hid/hid-haptic.c
 create mode 100644 drivers/hid/hid-haptic.h

-- 
2.36.0.550.gb090851708-goog


             reply	other threads:[~2022-10-07 18:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 18:29 Angela Czubak [this message]
2022-10-07 18:29 ` [PATCH v4 01/17] HID: add haptics page defines Angela Czubak
2022-10-07 18:29 ` [PATCH v4 02/17] Input: add FF_HID effect type Angela Czubak
2022-10-07 18:29 ` [PATCH v4 03/17] HID: haptic: introduce hid_haptic_device Angela Czubak
2022-10-07 18:29 ` [PATCH v4 04/17] HID: input: allow mapping of haptic output Angela Czubak
2022-10-07 18:29 ` [PATCH v4 05/17] HID: haptic: initialize haptic device Angela Czubak
2022-10-07 18:29 ` [PATCH v4 06/17] Input: add shared effects Angela Czubak
2022-10-07 18:29 ` [PATCH v4 07/17] HID: haptic: implement release and press effects Angela Czubak
2022-10-07 18:29 ` [PATCH v4 08/17] HID: input: calculate resolution for pressure Angela Czubak
2022-10-07 18:29 ` [PATCH v4 09/17] HID: haptic: add functions handling events Angela Czubak
2022-10-07 18:29 ` [PATCH v4 10/17] Input: MT - add INPUT_MT_MAX_FORCE flags Angela Czubak
2022-10-07 18:29 ` [PATCH v4 11/17] HID: haptic: add hid_haptic_switch_mode Angela Czubak
2022-10-07 18:29 ` [PATCH v4 12/17] HID: multitouch: add haptic multitouch support Angela Czubak
2022-10-07 18:29 ` [PATCH v4 13/17] Input: introduce EVIOCFF(TAKE|RELEASE)CONTROL Angela Czubak
2022-10-07 18:29 ` [PATCH v4 14/17] HID: haptic: add hid_haptic_change_control Angela Czubak
2022-10-07 18:29 ` [PATCH v4 15/17] HID: add HID device reset callback Angela Czubak
2022-10-07 18:29 ` [PATCH v4 16/17] HID: haptic: implement HID haptic " Angela Czubak
2022-10-07 18:29 ` [PATCH v4 17/17] HID: multitouch: Add lid handler for touchpad on Redrix chromebook Angela Czubak
     [not found] ` <CAB4aORV87CJFo9VkJawgLDe4CfyhXiGzGmzcaCAkPWO4bvwy1Q@mail.gmail.com>
2022-10-13 13:20   ` [PATCH v4 00/17] *** Implement simple haptic HID support *** Angela Czubak
2023-06-19 16:51     ` Sean O'Brien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221007182945.1654046-1-acz@semihalf.com \
    --to=acz@semihalf.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.