From: Kees Cook <keescook@chromium.org>
To: linux-hardening@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
Paramjit Oberoi <pso@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] pstore/ram: Move pmsg init earlier
Date: Tue, 11 Oct 2022 13:01:09 -0700 [thread overview]
Message-ID: <20221011200112.731334-3-keescook@chromium.org> (raw)
In-Reply-To: <20221011200112.731334-1-keescook@chromium.org>
Since the ftrace area can vary in size based on CPU count, move pmsg
initialization earlier so it will have a stable location.
Suggested-by: Paramjit Oberoi <pso@chromium.org>
Cc: Anton Vorontsov <anton@enomsg.org>
Cc: Colin Cross <ccross@android.com>
Cc: Tony Luck <tony.luck@intel.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
fs/pstore/ram.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 348820a3ce88..2f18563c8141 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -785,6 +785,11 @@ static int ramoops_probe(struct platform_device *pdev)
if (err)
goto fail_init;
+ err = ramoops_init_prz("pmsg", dev, cxt, &cxt->mprz, &paddr,
+ cxt->pmsg_size, 0);
+ if (err)
+ goto fail_init;
+
cxt->max_ftrace_cnt = (cxt->flags & RAMOOPS_FLAG_FTRACE_PER_CPU)
? nr_cpu_ids
: 1;
@@ -796,11 +801,6 @@ static int ramoops_probe(struct platform_device *pdev)
if (err)
goto fail_init;
- err = ramoops_init_prz("pmsg", dev, cxt, &cxt->mprz, &paddr,
- cxt->pmsg_size, 0);
- if (err)
- goto fail_init;
-
cxt->pstore.data = cxt;
/*
* Prepare frontend flags based on which areas are initialized.
--
2.34.1
next prev parent reply other threads:[~2022-10-11 20:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 20:01 [PATCH 0/5] Move internal definitions out of kernel-wide include Kees Cook
2022-10-11 20:01 ` [PATCH 1/5] pstore/ram: Consolidate kfree() paths Kees Cook
2022-10-12 19:43 ` Guilherme G. Piccoli
2022-10-11 20:01 ` Kees Cook [this message]
2022-10-12 19:45 ` [PATCH 2/5] pstore/ram: Move pmsg init earlier Guilherme G. Piccoli
2022-10-11 20:01 ` [PATCH 3/5] pstore/ram: Move internal definitions out of kernel-wide include Kees Cook
2022-10-12 19:46 ` Guilherme G. Piccoli
2022-10-12 21:51 ` Kees Cook
2022-10-11 20:01 ` [PATCH 4/5] pstore/ram: Set freed addresses to NULL Kees Cook
2022-10-12 19:44 ` Guilherme G. Piccoli
2022-10-11 20:01 ` [PATCH 5/5] MAINTAINERS: Update pstore maintainers Kees Cook
2022-10-11 20:26 ` Colin Cross
2022-10-11 20:35 ` Guilherme G. Piccoli
2022-10-11 22:20 ` Kees Cook
2022-10-12 15:15 ` Guilherme G. Piccoli
2022-11-16 15:42 ` Guilherme G. Piccoli
2022-11-17 22:01 ` Kees Cook
2022-11-17 22:05 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011200112.731334-3-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ardb@kernel.org \
--cc=ccross@android.com \
--cc=gpiccoli@igalia.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pso@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.