All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech, lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech, Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 09/12] xen/arm: mm: Allow dump_hyp_walk() to work on the current root table
Date: Sat, 22 Oct 2022 16:04:19 +0100	[thread overview]
Message-ID: <20221022150422.17707-10-julien@xen.org> (raw)
In-Reply-To: <20221022150422.17707-1-julien@xen.org>

From: Julien Grall <jgrall@amazon.com>

dump_hyp_walk() is used to print the tables walk in case of the data or
instruction abort.

Those abort are not limited to the runtime and could happen at early
boot. However, the current implementation of dump_hyp_walk() check
that the TTBR matches the runtime page tables.

Therefore, early abort will result to a secondary abort and not
print the table walks.

Given that the function is called in the abort path, there is no
reason for us to keep the BUG_ON() in any form. So drop it.

Signed-off-by: Julien Grall <jgrall@amazon.com>

----
    Changes in v2:
        - Patch added
---
 xen/arch/arm/mm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index a3f604e0e2d1..865780695421 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -289,13 +289,11 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr,
 void dump_hyp_walk(vaddr_t addr)
 {
     uint64_t ttbr = READ_SYSREG64(TTBR0_EL2);
-    lpae_t *pgtable = THIS_CPU_PGTABLE;
 
     printk("Walking Hypervisor VA 0x%"PRIvaddr" "
            "on CPU%d via TTBR 0x%016"PRIx64"\n",
            addr, smp_processor_id(), ttbr);
 
-    BUG_ON( virt_to_maddr(pgtable) != ttbr );
     dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1);
 }
 
-- 
2.37.1



  parent reply	other threads:[~2022-10-22 15:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-22 15:04 [RFC v2 00/12] xen/arm: Don't switch TTBR while the MMU is on Julien Grall
2022-10-22 15:04 ` [RFC v2 01/12] xen/arm: Clean-up the memory layout Julien Grall
2022-10-24 14:59   ` Luca Fancellu
2022-10-25  9:21   ` Michal Orzel
2022-10-25 10:31     ` Julien Grall
2022-10-25 10:36       ` Michal Orzel
2022-10-25 20:07         ` Julien Grall
2022-10-22 15:04 ` [RFC v2 02/12] xen/arm32: head: Jump to the runtime mapping in enable_mmu() Julien Grall
2022-10-25  9:45   ` Michal Orzel
2022-10-25 10:05     ` Julien Grall
2022-10-22 15:04 ` [RFC v2 03/12] xen/arm32: head: Introduce an helper to flush the TLBs Julien Grall
2022-10-25  9:53   ` Michal Orzel
2022-10-25 10:41     ` Julien Grall
2022-10-22 15:04 ` [RFC v2 04/12] xen/arm32: head: Remove restriction where to load Xen Julien Grall
2022-10-25 11:56   ` Luca Fancellu
2022-11-17 20:18     ` Julien Grall
2022-11-25 15:50       ` Luca Fancellu
2022-12-06 18:29         ` Julien Grall
2022-10-22 15:04 ` [RFC v2 05/12] xen/arm32: head: Widen the use of the temporary mapping Julien Grall
2022-10-22 15:04 ` [RFC v2 06/12] xen/arm: Enable use of dump_pt_walk() early during boot Julien Grall
2022-10-22 15:04 ` [RFC v2 07/12] xen/arm64: Rework the memory layout Julien Grall
2022-10-22 15:04 ` [RFC v2 08/12] xen/arm: mm: Allow xen_pt_update() to work with the current root table Julien Grall
2022-10-22 15:04 ` Julien Grall [this message]
2022-10-22 15:04 ` [RFC v2 10/12] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping Julien Grall
2022-10-22 15:04 ` [RFC v2 11/12] xen/arm64: mm: Rework switch_ttbr() Julien Grall
2022-10-22 15:04 ` [RFC v2 12/12] xen/arm64: smpboot: Directly switch to the runtime page-tables Julien Grall
2022-10-24 15:39 ` [RFC v2 00/12] xen/arm: Don't switch TTBR while the MMU is on Xenia Ragiadakou
2022-10-24 15:46   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221022150422.17707-10-julien@xen.org \
    --to=julien@xen.org \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=bertrand.marquis@arm.com \
    --cc=carlo.nonato@minervasys.tech \
    --cc=jgrall@amazon.com \
    --cc=lucmiccio@gmail.com \
    --cc=marco.solieri@minervasys.tech \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.