All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bryan Brattlof <bb@ti.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>
Cc: Keerthy <j-keerthy@ti.com>, Linux PM <linux-pm@vger.kernel.org>,
	Device Trees <devicetree@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	LKML ARM <linux-arm-kernel@lists.infradead.org>,
	Bryan Brattlof <bb@ti.com>
Subject: [PATCH v2 01/11] thermal: k3_j72xx_bandgap: simplify k3_thermal_get_temp() function
Date: Tue, 25 Oct 2022 14:15:05 -0500	[thread overview]
Message-ID: <20221025191515.9151-2-bb@ti.com> (raw)
In-Reply-To: <20221025191515.9151-1-bb@ti.com>

The k3_thermal_get_temp() function can be simplified to return only
the result of k3_bgp_read_temp() without needing the 'ret' variable

Signed-off-by: Bryan Brattlof <bb@ti.com>
---
 drivers/thermal/k3_j72xx_bandgap.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c
index c073b1023bbe7..a9f99a190cb61 100644
--- a/drivers/thermal/k3_j72xx_bandgap.c
+++ b/drivers/thermal/k3_j72xx_bandgap.c
@@ -249,14 +249,7 @@ static inline int k3_bgp_read_temp(struct k3_thermal_data *devdata,
 /* Get temperature callback function for thermal zone */
 static int k3_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
 {
-	struct k3_thermal_data *data = tz->devdata;
-	int ret = 0;
-
-	ret = k3_bgp_read_temp(data, temp);
-	if (ret)
-		return ret;
-
-	return ret;
+	return k3_bgp_read_temp(tz->devdata, temp);
 }
 
 static const struct thermal_zone_device_ops k3_of_thermal_ops = {
-- 
2.38.1


WARNING: multiple messages have this Message-ID (diff)
From: Bryan Brattlof <bb@ti.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>
Cc: Keerthy <j-keerthy@ti.com>, Linux PM <linux-pm@vger.kernel.org>,
	Device Trees <devicetree@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	LKML ARM <linux-arm-kernel@lists.infradead.org>,
	Bryan Brattlof <bb@ti.com>
Subject: [PATCH v2 01/11] thermal: k3_j72xx_bandgap: simplify k3_thermal_get_temp() function
Date: Tue, 25 Oct 2022 14:15:05 -0500	[thread overview]
Message-ID: <20221025191515.9151-2-bb@ti.com> (raw)
In-Reply-To: <20221025191515.9151-1-bb@ti.com>

The k3_thermal_get_temp() function can be simplified to return only
the result of k3_bgp_read_temp() without needing the 'ret' variable

Signed-off-by: Bryan Brattlof <bb@ti.com>
---
 drivers/thermal/k3_j72xx_bandgap.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c
index c073b1023bbe7..a9f99a190cb61 100644
--- a/drivers/thermal/k3_j72xx_bandgap.c
+++ b/drivers/thermal/k3_j72xx_bandgap.c
@@ -249,14 +249,7 @@ static inline int k3_bgp_read_temp(struct k3_thermal_data *devdata,
 /* Get temperature callback function for thermal zone */
 static int k3_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
 {
-	struct k3_thermal_data *data = tz->devdata;
-	int ret = 0;
-
-	ret = k3_bgp_read_temp(data, temp);
-	if (ret)
-		return ret;
-
-	return ret;
+	return k3_bgp_read_temp(tz->devdata, temp);
 }
 
 static const struct thermal_zone_device_ops k3_of_thermal_ops = {
-- 
2.38.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-25 19:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25 19:15 [PATCH v2 00/11] enable VTM node for all TI's K3 SoCs Bryan Brattlof
2022-10-25 19:15 ` Bryan Brattlof
2022-10-25 19:15 ` Bryan Brattlof [this message]
2022-10-25 19:15   ` [PATCH v2 01/11] thermal: k3_j72xx_bandgap: simplify k3_thermal_get_temp() function Bryan Brattlof
2022-10-25 19:15 ` [PATCH v2 02/11] thermal: k3_j72xx_bandgap: use bool for i2128 erratum flag Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof
2022-10-25 19:15 ` [PATCH v2 03/11] thermal: k3_j72xx_bandgap: remove fuse_base from structure Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof
2022-10-25 19:15 ` [PATCH v2 04/11] thermal: k3_j72xx_bandgap: map fuse_base only for erratum workaround Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof
2022-10-25 19:42   ` Bryan Brattlof
2022-10-25 19:42     ` Bryan Brattlof
2022-10-25 19:15 ` [PATCH v2 05/11] dt-bindings: thermal: k3-j72xx: elaborate on binding description Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof
2022-10-26 14:54   ` Krzysztof Kozlowski
2022-10-26 14:54     ` Krzysztof Kozlowski
2022-10-25 19:15 ` [PATCH v2 06/11] dt-bindings: thermal: k3-j72xx: conditionally require efuse reg range Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof
2022-10-26 14:55   ` Krzysztof Kozlowski
2022-10-26 14:55     ` Krzysztof Kozlowski
2022-10-25 19:15 ` [PATCH v2 07/11] arm64: dts: ti: k3-am64-main: add VTM node Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof
2022-10-25 19:15 ` [PATCH v2 08/11] arm64: dts: ti: k3-am62-wakeup: " Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof
2022-10-25 19:15 ` [PATCH v2 09/11] arm64: dts: ti: k3-j721e-mcu-wakeup: " Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof
2022-10-25 19:15 ` [PATCH v2 10/11] arm64: dts: ti: k3-j721s2-mcu-wakeup: " Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof
2022-10-25 19:15 ` [PATCH v2 11/11] arm64: dts: ti: k3-j7200-mcu-wakeup: " Bryan Brattlof
2022-10-25 19:15   ` Bryan Brattlof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221025191515.9151-2-bb@ti.com \
    --to=bb@ti.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.