All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
	ZiyangZhang <ZiyangZhang@linux.alibaba.com>,
	Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 2/4] ublk_drv: comment on ublk_driver entry of Kconfig
Date: Sat, 29 Oct 2022 09:04:30 +0800	[thread overview]
Message-ID: <20221029010432.598367-3-ming.lei@redhat.com> (raw)
In-Reply-To: <20221029010432.598367-1-ming.lei@redhat.com>

Add help info for choosing to build ublk_drv as module or builtin.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 drivers/block/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index db1b4b202646..a41145d52de9 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -408,6 +408,12 @@ config BLK_DEV_UBLK
 	  definition isn't finalized yet, and might change according to future
 	  requirement, so mark is as experimental now.
 
+	  Say Y if you want to get better performance because task_work_add()
+	  can be used in IO path for replacing io_uring cmd, which will become
+	  shared between IO tasks and ubq daemon, meantime task_work_add() can
+	  can handle batch more effectively, but task_work_add() isn't exported
+	  for module, so ublk has to be built to kernel.
+
 source "drivers/block/rnbd/Kconfig"
 
 endif # BLK_DEV
-- 
2.31.1


  parent reply	other threads:[~2022-10-29  1:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-29  1:04 [PATCH 0/4] ublk_drv: uring_cmd queueing improvement and cleanup Ming Lei
2022-10-29  1:04 ` [PATCH 1/4] ublk: return flag of UBLK_F_URING_CMD_COMP_IN_TASK in case of module Ming Lei
2022-10-31  3:14   ` Ziyang Zhang
2022-10-29  1:04 ` Ming Lei [this message]
2022-10-31  3:16   ` [PATCH 2/4] ublk_drv: comment on ublk_driver entry of Kconfig Ziyang Zhang
2022-10-29  1:04 ` [PATCH 3/4] ublk_drv: avoid to touch io_uring cmd in blk_mq io path Ming Lei
2022-10-31  5:15   ` Ziyang Zhang
2022-10-29  1:04 ` [PATCH 4/4] ublk_drv: add ublk_queue_cmd() for cleanup Ming Lei
2022-10-31  6:11   ` Ziyang Zhang
2022-10-31 13:24 ` [PATCH 0/4] ublk_drv: uring_cmd queueing improvement and cleanup Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221029010432.598367-3-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=ZiyangZhang@linux.alibaba.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.