All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com, mst@redhat.com,
	jasowang@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC] vhost: Clear the pending messages on vhost_init_device_iotlb()
Date: Mon,  7 Nov 2022 21:34:31 +0100	[thread overview]
Message-ID: <20221107203431.368306-1-eric.auger@redhat.com> (raw)

When the vhost iotlb is used along with a guest virtual iommu
and the guest gets rebooted, some MISS messages may have been
recorded just before the reboot and spuriously executed by
the virtual iommu after the reboot. Despite the device iotlb gets
re-initialized, the messages are not cleared. Fix that by calling
vhost_clear_msg() at the end of vhost_init_device_iotlb().

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 drivers/vhost/vhost.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 40097826cff0..422a1fdee0ca 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1751,6 +1751,7 @@ int vhost_init_device_iotlb(struct vhost_dev *d, bool enabled)
 	}
 
 	vhost_iotlb_free(oiotlb);
+	vhost_clear_msg(d);
 
 	return 0;
 }
-- 
2.37.3

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com, mst@redhat.com,
	jasowang@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: peterx@redhat.com
Subject: [RFC] vhost: Clear the pending messages on vhost_init_device_iotlb()
Date: Mon,  7 Nov 2022 21:34:31 +0100	[thread overview]
Message-ID: <20221107203431.368306-1-eric.auger@redhat.com> (raw)

When the vhost iotlb is used along with a guest virtual iommu
and the guest gets rebooted, some MISS messages may have been
recorded just before the reboot and spuriously executed by
the virtual iommu after the reboot. Despite the device iotlb gets
re-initialized, the messages are not cleared. Fix that by calling
vhost_clear_msg() at the end of vhost_init_device_iotlb().

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 drivers/vhost/vhost.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 40097826cff0..422a1fdee0ca 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1751,6 +1751,7 @@ int vhost_init_device_iotlb(struct vhost_dev *d, bool enabled)
 	}
 
 	vhost_iotlb_free(oiotlb);
+	vhost_clear_msg(d);
 
 	return 0;
 }
-- 
2.37.3


             reply	other threads:[~2022-11-07 20:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07 20:34 Eric Auger [this message]
2022-11-07 20:34 ` [RFC] vhost: Clear the pending messages on vhost_init_device_iotlb() Eric Auger
2022-11-07 20:42 ` Michael S. Tsirkin
2022-11-07 20:42   ` Michael S. Tsirkin
2022-11-07 21:10   ` Eric Auger
2022-11-07 21:10     ` Eric Auger
2022-11-07 23:06     ` Michael S. Tsirkin
2022-11-07 23:06       ` Michael S. Tsirkin
2022-11-08  3:09       ` Jason Wang
2022-11-08  3:09         ` Jason Wang
2022-11-08  7:31         ` Eric Auger
2022-11-08  7:31           ` Eric Auger
2022-11-08  8:55         ` Michael S. Tsirkin
2022-11-08  8:55           ` Michael S. Tsirkin
2022-11-08  9:13           ` Jason Wang
2022-11-08  9:13             ` Jason Wang
2022-11-08  9:31             ` Michael S. Tsirkin
2022-11-08  9:31               ` Michael S. Tsirkin
2022-11-08 10:17               ` Eric Auger
2022-11-08 10:17                 ` Eric Auger
2022-11-09  3:44                 ` Jason Wang
2022-11-09  3:44                   ` Jason Wang
2022-11-09  7:29                   ` Eric Auger
2022-11-09  7:29                     ` Eric Auger
2022-11-09  3:39               ` Jason Wang
2022-11-09  3:39                 ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221107203431.368306-1-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.