All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	virtio-fs@redhat.com, Yuval Shaia <yuval.shaia.ml@gmail.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Konstantin Kostiuk <kkostiuk@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>, Stefan Weil <sw@weilnetz.de>,
	Yan Vugenfirer <yan@daynix.com>,
	Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH 01/10] qga: Remove platform GUID definitions
Date: Thu, 10 Nov 2022 15:23:20 +0900	[thread overview]
Message-ID: <20221110062329.13363-2-akihiko.odaki@daynix.com> (raw)
In-Reply-To: <20221110062329.13363-1-akihiko.odaki@daynix.com>

GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
defined by MinGW-w64. They are not only unnecessary, but can lead to
duplicate definition errors at link time with some unknown condition.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 qga/commands-win32.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index ec9f55b453..dde5d401bb 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -506,13 +506,6 @@ static GuestDiskBusType find_bus_type(STORAGE_BUS_TYPE bus)
     return win2qemu[(int)bus];
 }
 
-DEFINE_GUID(GUID_DEVINTERFACE_DISK,
-        0x53f56307L, 0xb6bf, 0x11d0, 0x94, 0xf2,
-        0x00, 0xa0, 0xc9, 0x1e, 0xfb, 0x8b);
-DEFINE_GUID(GUID_DEVINTERFACE_STORAGEPORT,
-        0x2accfe60L, 0xc130, 0x11d2, 0xb0, 0x82,
-        0x00, 0xa0, 0xc9, 0x1e, 0xfb, 0x8b);
-
 static void get_pci_address_for_device(GuestPCIAddress *pci,
                                        HDEVINFO dev_info)
 {
-- 
2.38.1



WARNING: multiple messages have this Message-ID (diff)
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	virtio-fs@redhat.com, Yuval Shaia <yuval.shaia.ml@gmail.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Konstantin Kostiuk <kkostiuk@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>, Stefan Weil <sw@weilnetz.de>,
	Yan Vugenfirer <yan@daynix.com>,
	Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [Virtio-fs] [PATCH 01/10] qga: Remove platform GUID definitions
Date: Thu, 10 Nov 2022 15:23:20 +0900	[thread overview]
Message-ID: <20221110062329.13363-2-akihiko.odaki@daynix.com> (raw)
In-Reply-To: <20221110062329.13363-1-akihiko.odaki@daynix.com>

GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
defined by MinGW-w64. They are not only unnecessary, but can lead to
duplicate definition errors at link time with some unknown condition.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 qga/commands-win32.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index ec9f55b453..dde5d401bb 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -506,13 +506,6 @@ static GuestDiskBusType find_bus_type(STORAGE_BUS_TYPE bus)
     return win2qemu[(int)bus];
 }
 
-DEFINE_GUID(GUID_DEVINTERFACE_DISK,
-        0x53f56307L, 0xb6bf, 0x11d0, 0x94, 0xf2,
-        0x00, 0xa0, 0xc9, 0x1e, 0xfb, 0x8b);
-DEFINE_GUID(GUID_DEVINTERFACE_STORAGEPORT,
-        0x2accfe60L, 0xc130, 0x11d2, 0xb0, 0x82,
-        0x00, 0xa0, 0xc9, 0x1e, 0xfb, 0x8b);
-
 static void get_pci_address_for_device(GuestPCIAddress *pci,
                                        HDEVINFO dev_info)
 {
-- 
2.38.1


  reply	other threads:[~2022-11-10  6:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  6:23 [PATCH 00/10] util: Introduce qemu_get_runtime_dir() Akihiko Odaki
2022-11-10  6:23 ` [Virtio-fs] " Akihiko Odaki
2022-11-10  6:23 ` Akihiko Odaki [this message]
2022-11-10  6:23   ` [Virtio-fs] [PATCH 01/10] qga: Remove platform GUID definitions Akihiko Odaki
2022-11-10  8:03   ` Konstantin Kostiuk
2022-11-10  8:03     ` [Virtio-fs] " Konstantin Kostiuk
2022-11-10  6:23 ` [PATCH 02/10] util: Introduce qemu_get_runtime_dir() Akihiko Odaki
2022-11-10  6:23   ` [Virtio-fs] " Akihiko Odaki
2022-11-10  6:23 ` [PATCH 03/10] ivshmem-server: Use qemu_get_runtime_dir() Akihiko Odaki
2022-11-10  6:23   ` [Virtio-fs] " Akihiko Odaki
2022-11-10  6:23 ` [PATCH 04/10] contrib/rdmacm-mux: " Akihiko Odaki
2022-11-10  6:23   ` [Virtio-fs] " Akihiko Odaki
2022-11-10  6:23 ` [PATCH 05/10] qga: " Akihiko Odaki
2022-11-10  6:23   ` [Virtio-fs] " Akihiko Odaki
2022-11-10  6:23 ` [PATCH 06/10] scsi: " Akihiko Odaki
2022-11-10  6:23   ` [Virtio-fs] " Akihiko Odaki
2022-11-10  6:23 ` [PATCH 07/10] virtiofsd: " Akihiko Odaki
2022-11-10  6:23   ` [Virtio-fs] " Akihiko Odaki
2022-11-10  6:23 ` [PATCH 08/10] module: " Akihiko Odaki
2022-11-10  6:23   ` [Virtio-fs] " Akihiko Odaki
2022-11-10  6:23 ` [PATCH 09/10] util: Remove qemu_get_local_state_dir() Akihiko Odaki
2022-11-10  6:23   ` [Virtio-fs] " Akihiko Odaki
2022-11-10  6:23 ` [PATCH 10/10] spice-app: Use qemu_get_runtime_dir() Akihiko Odaki
2022-11-10  6:23   ` [Virtio-fs] " Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110062329.13363-2-akihiko.odaki@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=dgilbert@redhat.com \
    --cc=fam@euphon.net \
    --cc=kkostiuk@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    --cc=virtio-fs@redhat.com \
    --cc=yan@daynix.com \
    --cc=yuval.shaia.ml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.