All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>,
	Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
	David E Box <david.e.box@intel.com>
Cc: Sven van Ashbrook <svenva@chromium.org>,
	Raul Rangel <rrangel@chromium.org>, <linux-pm@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>,
	Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
	John Stultz <jstultz@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Stephen Boyd <sboyd@kernel.org>,
	S-k Shyam-sundar <Shyam-sundar.S-k@amd.com>,
	Rajat Jain <rajatja@google.com>,
	Hans de Goede <hdegoede@redhat.com>,
	<linux-kernel@vger.kernel.org>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Mark Gross <markgross@kernel.org>
Subject: [RFC v4 4/5] platform/x86/intel/pmc: core: Always capture counters on suspend
Date: Thu, 17 Nov 2022 16:58:20 -0600	[thread overview]
Message-ID: <20221117225822.16154-5-mario.limonciello@amd.com> (raw)
In-Reply-To: <20221117225822.16154-1-mario.limonciello@amd.com>

Currently counters are only captured during suspend when the
warn_on_s0ix_failures module parameter is set.

In order to relay this counter information to the kernel reporting
infrastructure adjust it so that the counters are always captured.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
RFC v3->v4:
 * New patch
---
 drivers/platform/x86/intel/pmc/core.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
index adc2cae4db28..9baf2bb443c8 100644
--- a/drivers/platform/x86/intel/pmc/core.c
+++ b/drivers/platform/x86/intel/pmc/core.c
@@ -2059,10 +2059,6 @@ static __maybe_unused int pmc_core_suspend(struct device *dev)
 {
 	struct pmc_dev *pmcdev = dev_get_drvdata(dev);
 
-	/* No warnings on S0ix failures */
-	if (!warn_on_s0ix_failures)
-		return 0;
-
 	/* Check if the syspend will actually use S0ix */
 	if (pm_suspend_via_firmware())
 		return 0;
-- 
2.34.1


  parent reply	other threads:[~2022-11-17 22:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 22:58 [RFC v4 0/5] Report percentage of time in hardware sleep state Mario Limonciello
2022-11-17 22:58 ` [RFC v4 1/5] PM: Add a sysfs file to represent the percentage of sleep in hardware state Mario Limonciello
2022-11-18  0:41   ` John Stultz
2022-11-17 22:58 ` [RFC v4 2/5] platform/x86/amd: pmc: Report duration of time in deepest hw state Mario Limonciello
2022-11-17 22:58 ` [RFC v4 3/5] platform/x86/intel/pmc: core: Drop check_counters Mario Limonciello
2022-11-23 17:47   ` Sven van Ashbrook
2022-12-01 20:12     ` Limonciello, Mario
2022-11-17 22:58 ` Mario Limonciello [this message]
2022-11-17 22:58 ` [RFC v4 5/5] platform/x86/intel/pmc: core: Report duration of time in HW sleep state Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221117225822.16154-5-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=david.e.box@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=jstultz@google.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rajatja@google.com \
    --cc=rrangel@chromium.org \
    --cc=sboyd@kernel.org \
    --cc=svenva@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.