All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v3 02/15] arm64: dts: qcom: qcs404: align CDSP PAS node with bindings
Date: Thu, 24 Nov 2022 19:43:20 +0100	[thread overview]
Message-ID: <20221124184333.133911-3-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20221124184333.133911-1-krzysztof.kozlowski@linaro.org>

The QCS404 CDSP remote processor can be brought to life using two
different bindings:
1. qcom,qcs404-cdsp-pas - currently used in DTSI.
2. qcom,qcs404-cdsp-pil.

Comment out the properties related to qcom,qcs404-cdsp-pil
(qcom,halt-regs, resets and additional clocks), to silence DT schema
warnings.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes since v2:
1. New patch.
---
 arch/arm64/boot/dts/qcom/qcs404.dtsi | 46 +++++++++++++++-------------
 1 file changed, 25 insertions(+), 21 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index a5324eecb50a..78a8ab29a0a9 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -485,27 +485,31 @@ remoteproc_cdsp: remoteproc@b00000 {
 			interrupt-names = "wdog", "fatal", "ready",
 					  "handover", "stop-ack";
 
-			clocks = <&xo_board>,
-				 <&gcc GCC_CDSP_CFG_AHB_CLK>,
-				 <&gcc GCC_CDSP_TBU_CLK>,
-				 <&gcc GCC_BIMC_CDSP_CLK>,
-				 <&turingcc TURING_WRAPPER_AON_CLK>,
-				 <&turingcc TURING_Q6SS_AHBS_AON_CLK>,
-				 <&turingcc TURING_Q6SS_AHBM_AON_CLK>,
-				 <&turingcc TURING_Q6SS_Q6_AXIM_CLK>;
-			clock-names = "xo",
-				      "sway",
-				      "tbu",
-				      "bimc",
-				      "ahb_aon",
-				      "q6ss_slave",
-				      "q6ss_master",
-				      "q6_axim";
-
-			resets = <&gcc GCC_CDSP_RESTART>;
-			reset-names = "restart";
-
-			qcom,halt-regs = <&tcsr 0x19004>;
+			clocks = <&xo_board>;
+			clock-names = "xo";
+
+			/*
+			 * If the node was using the PIL binding, then include properties:
+			 * clocks = <&xo_board>,
+			 *          <&gcc GCC_CDSP_CFG_AHB_CLK>,
+			 *          <&gcc GCC_CDSP_TBU_CLK>,
+			 *          <&gcc GCC_BIMC_CDSP_CLK>,
+			 *          <&turingcc TURING_WRAPPER_AON_CLK>,
+			 *          <&turingcc TURING_Q6SS_AHBS_AON_CLK>,
+			 *          <&turingcc TURING_Q6SS_AHBM_AON_CLK>,
+			 *          <&turingcc TURING_Q6SS_Q6_AXIM_CLK>;
+			 * clock-names = "xo",
+			 *               "sway",
+			 *               "tbu",
+			 *               "bimc",
+			 *               "ahb_aon",
+			 *               "q6ss_slave",
+			 *               "q6ss_master",
+			 *               "q6_axim";
+			 * resets = <&gcc GCC_CDSP_RESTART>;
+			 * reset-names = "restart";
+			 * qcom,halt-regs = <&tcsr 0x19004>;
+			 */
 
 			memory-region = <&cdsp_fw_mem>;
 
-- 
2.34.1


  parent reply	other threads:[~2022-11-24 18:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 18:43 [PATCH v3 00/15] dt-bindings: remoteproc: qcom: split and reorganize PAS/PIL Krzysztof Kozlowski
2022-11-24 18:43 ` [PATCH v3 01/15] arm64: dts: qcom: msm8996: drop address/size cells from smd-edge Krzysztof Kozlowski
2022-11-24 18:43 ` Krzysztof Kozlowski [this message]
2022-11-24 18:43 ` [PATCH v3 03/15] arm64: dts: qcom: sc7180: align MPSS PAS node with bindings Krzysztof Kozlowski
2022-11-24 18:43 ` [PATCH v3 04/15] arm64: dts: qcom: sc7280: " Krzysztof Kozlowski
2022-11-24 18:43 ` [PATCH v3 05/15] dt-bindings: remoteproc: qcom,adsp: drop resets and qcom,halt-regs Krzysztof Kozlowski
2022-12-05 19:44   ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 06/15] dt-bindings: remoteproc: qcom,adsp: split common part Krzysztof Kozlowski
2022-12-05 19:44   ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 07/15] dt-bindings: remoteproc: qcom,sm8350-pas: split into separate file Krzysztof Kozlowski
2022-12-05 19:45   ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 08/15] dt-bindings: remoteproc: qcom,sm8150-pas: " Krzysztof Kozlowski
2022-12-05 19:46   ` Rob Herring
2022-12-05 19:49   ` Rob Herring
2022-12-06  7:58     ` Krzysztof Kozlowski
2022-11-24 18:43 ` [PATCH v3 09/15] dt-bindings: remoteproc: qcom,sm6350-pas: " Krzysztof Kozlowski
2022-12-05 19:50   ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 10/15] dt-bindings: remoteproc: qcom,sc8280xp-pas: " Krzysztof Kozlowski
2022-12-05 19:50   ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 11/15] dt-bindings: remoteproc: qcom,sc8180x-pas: " Krzysztof Kozlowski
2022-12-05 19:51   ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 12/15] dt-bindings: remoteproc: qcom,sdx55-pas: " Krzysztof Kozlowski
2022-12-05 19:51   ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 13/15] dt-bindings: remoteproc: qcom,qcs404-pas: " Krzysztof Kozlowski
2022-12-05 19:52   ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 14/15] dt-bindings: remoteproc: qcom,sc7180-pas: " Krzysztof Kozlowski
2022-12-05 19:52   ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 15/15] dt-bindings: remoteproc: qcom,adsp: correct msm8996-slpi-pil clocks Krzysztof Kozlowski
2022-12-05 19:53   ` Rob Herring
2022-12-27 18:08 ` (subset) [PATCH v3 00/15] dt-bindings: remoteproc: qcom: split and reorganize PAS/PIL Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221124184333.133911-3-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.