From: Mark Brown <broonie@kernel.org> To: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>, Shuah Khan <shuah@kernel.org> Cc: alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org, Mark Brown <broonie@kernel.org> Subject: [PATCH v1 6/6] kselftest/alsa: Add more coverage of sample rates and channel counts Date: Wed, 30 Nov 2022 00:06:08 +0000 [thread overview] Message-ID: <20221130000608.519574-7-broonie@kernel.org> (raw) In-Reply-To: <20221130000608.519574-1-broonie@kernel.org> Now that we can skip unsupported configurations add some more test cases using that, cover 8kHz, 44.1kHz and 96kHz plus 8kHz mono and 48kHz 6 channel. 44.1kHz is a different clock base to the existing 48kHz tests and may therefore show problems with the clock configuration if only 8kHz based rates are really available (or help diagnose if bad clocking is due to only 44.1kHz based rates being supported). 8kHz mono and 48Hz 6 channel are real world formats and should show if clocking does not account for channel count properly. Signed-off-by: Mark Brown <broonie@kernel.org> --- tools/testing/selftests/alsa/pcm-test.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/alsa/pcm-test.c b/tools/testing/selftests/alsa/pcm-test.c index 614ccc52cece..d76a6f15ce25 100644 --- a/tools/testing/selftests/alsa/pcm-test.c +++ b/tools/testing/selftests/alsa/pcm-test.c @@ -517,8 +517,13 @@ static void test_pcm_time1(struct pcm_data *data, static const struct time_test_def time_tests[] = { /* name format rate chan period buffer */ - { "S16.48k.2.small", "S16_LE", 48000, 2, 512, 4096 }, - { "S16.48k.2.big", "S16_LE", 48000, 2, 24000, 192000 }, + { "8k.1.big", "S16_LE", 8000, 2, 2000, 16000 }, + { "8k.2.big", "S16_LE", 8000, 2, 4000, 32000 }, + { "44k1.2.big", "S16_LE", 44100, 2, 22050, 192000 }, + { "48k.2.small", "S16_LE", 48000, 2, 512, 4096 }, + { "48k.2.big", "S16_LE", 48000, 2, 24000, 192000 }, + { "48k.6.big", "S16_LE", 48000, 6, 48000, 576000 }, + { "96k.2.big", "S16_LE", 96000, 2, 48000, 384000 }, }; int main(void) -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>, Shuah Khan <shuah@kernel.org> Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>, linux-kselftest@vger.kernel.org Subject: [PATCH v1 6/6] kselftest/alsa: Add more coverage of sample rates and channel counts Date: Wed, 30 Nov 2022 00:06:08 +0000 [thread overview] Message-ID: <20221130000608.519574-7-broonie@kernel.org> (raw) In-Reply-To: <20221130000608.519574-1-broonie@kernel.org> Now that we can skip unsupported configurations add some more test cases using that, cover 8kHz, 44.1kHz and 96kHz plus 8kHz mono and 48kHz 6 channel. 44.1kHz is a different clock base to the existing 48kHz tests and may therefore show problems with the clock configuration if only 8kHz based rates are really available (or help diagnose if bad clocking is due to only 44.1kHz based rates being supported). 8kHz mono and 48Hz 6 channel are real world formats and should show if clocking does not account for channel count properly. Signed-off-by: Mark Brown <broonie@kernel.org> --- tools/testing/selftests/alsa/pcm-test.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/alsa/pcm-test.c b/tools/testing/selftests/alsa/pcm-test.c index 614ccc52cece..d76a6f15ce25 100644 --- a/tools/testing/selftests/alsa/pcm-test.c +++ b/tools/testing/selftests/alsa/pcm-test.c @@ -517,8 +517,13 @@ static void test_pcm_time1(struct pcm_data *data, static const struct time_test_def time_tests[] = { /* name format rate chan period buffer */ - { "S16.48k.2.small", "S16_LE", 48000, 2, 512, 4096 }, - { "S16.48k.2.big", "S16_LE", 48000, 2, 24000, 192000 }, + { "8k.1.big", "S16_LE", 8000, 2, 2000, 16000 }, + { "8k.2.big", "S16_LE", 8000, 2, 4000, 32000 }, + { "44k1.2.big", "S16_LE", 44100, 2, 22050, 192000 }, + { "48k.2.small", "S16_LE", 48000, 2, 512, 4096 }, + { "48k.2.big", "S16_LE", 48000, 2, 24000, 192000 }, + { "48k.6.big", "S16_LE", 48000, 6, 48000, 576000 }, + { "96k.2.big", "S16_LE", 96000, 2, 48000, 384000 }, }; int main(void) -- 2.30.2
next prev parent reply other threads:[~2022-11-30 0:07 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-30 0:06 [PATCH v1 0/6] kselftest/alsa: pcm-test improvements Mark Brown 2022-11-30 0:06 ` Mark Brown 2022-11-30 0:06 ` [PATCH v1 1/6] kselftest/alsa: Refactor pcm-test to list the tests to run in a struct Mark Brown 2022-11-30 0:06 ` Mark Brown 2022-11-30 0:06 ` [PATCH v1 2/6] kselftest/alsa: Report failures to set the requested sample rate as skips Mark Brown 2022-11-30 0:06 ` Mark Brown 2022-11-30 0:06 ` [PATCH v1 3/6] kselftest/alsa: Report failures to set the requested channels " Mark Brown 2022-11-30 0:06 ` Mark Brown 2022-11-30 0:06 ` [PATCH v1 4/6] kselftest/alsa: Don't any configuration in the sample config Mark Brown 2022-11-30 0:06 ` Mark Brown 2022-11-30 0:06 ` [PATCH v1 5/6] kselftest/alsa: Provide more meaningful names for tests Mark Brown 2022-11-30 0:06 ` Mark Brown 2022-11-30 0:06 ` Mark Brown [this message] 2022-11-30 0:06 ` [PATCH v1 6/6] kselftest/alsa: Add more coverage of sample rates and channel counts Mark Brown 2022-11-30 13:42 ` Mark Brown 2022-11-30 13:52 ` Takashi Iwai 2022-11-30 13:52 ` Takashi Iwai 2022-12-01 17:42 ` [PATCH v1 0/6] kselftest/alsa: pcm-test improvements Jaroslav Kysela 2022-12-01 18:44 ` Mark Brown 2022-12-01 18:44 ` Mark Brown 2022-12-01 19:06 ` Takashi Iwai 2022-12-01 19:06 ` Takashi Iwai 2022-12-01 20:29 ` Mark Brown 2022-12-01 20:29 ` Mark Brown 2022-12-02 7:52 ` Takashi Iwai 2022-12-02 7:52 ` Takashi Iwai 2022-12-02 7:54 ` Takashi Iwai 2022-12-02 7:54 ` Takashi Iwai 2022-12-02 8:56 ` Jaroslav Kysela 2022-12-02 8:56 ` Jaroslav Kysela 2022-12-02 13:22 ` Mark Brown 2022-12-02 13:22 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221130000608.519574-7-broonie@kernel.org \ --to=broonie@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=perex@perex.cz \ --cc=shuah@kernel.org \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.