From: Roberto Sassu via Ocfs2-devel <ocfs2-devel@oss.oracle.com> To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, casey@schaufler-ca.com Cc: nicolas.bouchinet@clip-os.org, keescook@chromium.org, selinux@vger.kernel.org, Roberto Sassu <roberto.sassu@huawei.com>, reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: [Ocfs2-devel] [PATCH v7 3/6] security: Remove security_old_inode_init_security() Date: Thu, 1 Dec 2022 11:41:22 +0100 [thread overview] Message-ID: <20221201104125.919483-4-roberto.sassu@huaweicloud.com> (raw) In-Reply-To: <20221201104125.919483-1-roberto.sassu@huaweicloud.com> From: Roberto Sassu <roberto.sassu@huawei.com> As the remaining two users reiserfs and ocfs2 switched to security_inode_init_security(), security_old_inode_init_security() can be now removed. Out-of-tree kernel modules should switch to security_inode_init_security() too. Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> Reviewed-by: Casey Schaufler <casey@schaufler-ca.com> --- include/linux/security.h | 12 ------------ security/security.c | 11 ----------- 2 files changed, 23 deletions(-) diff --git a/include/linux/security.h b/include/linux/security.h index ca1b7109c0db..c682fc96ed61 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -336,9 +336,6 @@ int security_inode_init_security(struct inode *inode, struct inode *dir, int security_inode_init_security_anon(struct inode *inode, const struct qstr *name, const struct inode *context_inode); -int security_old_inode_init_security(struct inode *inode, struct inode *dir, - const struct qstr *qstr, const char **name, - void **value, size_t *len); int security_inode_create(struct inode *dir, struct dentry *dentry, umode_t mode); int security_inode_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_dentry); @@ -771,15 +768,6 @@ static inline int security_inode_init_security_anon(struct inode *inode, return 0; } -static inline int security_old_inode_init_security(struct inode *inode, - struct inode *dir, - const struct qstr *qstr, - const char **name, - void **value, size_t *len) -{ - return -EOPNOTSUPP; -} - static inline int security_inode_create(struct inode *dir, struct dentry *dentry, umode_t mode) diff --git a/security/security.c b/security/security.c index 79d82cb6e469..e2857446fd32 100644 --- a/security/security.c +++ b/security/security.c @@ -1132,17 +1132,6 @@ int security_inode_init_security_anon(struct inode *inode, context_inode); } -int security_old_inode_init_security(struct inode *inode, struct inode *dir, - const struct qstr *qstr, const char **name, - void **value, size_t *len) -{ - if (unlikely(IS_PRIVATE(inode))) - return -EOPNOTSUPP; - return call_int_hook(inode_init_security, -EOPNOTSUPP, inode, dir, - qstr, name, value, len); -} -EXPORT_SYMBOL(security_old_inode_init_security); - #ifdef CONFIG_SECURITY_PATH int security_path_mknod(const struct path *dir, struct dentry *dentry, umode_t mode, unsigned int dev) -- 2.25.1 _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel
WARNING: multiple messages have this Message-ID (diff)
From: Roberto Sassu <roberto.sassu@huaweicloud.com> To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, stephen.smalley.work@gmail.com, eparis@parisplace.org, casey@schaufler-ca.com Cc: ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org, keescook@chromium.org, nicolas.bouchinet@clip-os.org, Roberto Sassu <roberto.sassu@huawei.com> Subject: [PATCH v7 3/6] security: Remove security_old_inode_init_security() Date: Thu, 1 Dec 2022 11:41:22 +0100 [thread overview] Message-ID: <20221201104125.919483-4-roberto.sassu@huaweicloud.com> (raw) In-Reply-To: <20221201104125.919483-1-roberto.sassu@huaweicloud.com> From: Roberto Sassu <roberto.sassu@huawei.com> As the remaining two users reiserfs and ocfs2 switched to security_inode_init_security(), security_old_inode_init_security() can be now removed. Out-of-tree kernel modules should switch to security_inode_init_security() too. Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> Reviewed-by: Casey Schaufler <casey@schaufler-ca.com> --- include/linux/security.h | 12 ------------ security/security.c | 11 ----------- 2 files changed, 23 deletions(-) diff --git a/include/linux/security.h b/include/linux/security.h index ca1b7109c0db..c682fc96ed61 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -336,9 +336,6 @@ int security_inode_init_security(struct inode *inode, struct inode *dir, int security_inode_init_security_anon(struct inode *inode, const struct qstr *name, const struct inode *context_inode); -int security_old_inode_init_security(struct inode *inode, struct inode *dir, - const struct qstr *qstr, const char **name, - void **value, size_t *len); int security_inode_create(struct inode *dir, struct dentry *dentry, umode_t mode); int security_inode_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_dentry); @@ -771,15 +768,6 @@ static inline int security_inode_init_security_anon(struct inode *inode, return 0; } -static inline int security_old_inode_init_security(struct inode *inode, - struct inode *dir, - const struct qstr *qstr, - const char **name, - void **value, size_t *len) -{ - return -EOPNOTSUPP; -} - static inline int security_inode_create(struct inode *dir, struct dentry *dentry, umode_t mode) diff --git a/security/security.c b/security/security.c index 79d82cb6e469..e2857446fd32 100644 --- a/security/security.c +++ b/security/security.c @@ -1132,17 +1132,6 @@ int security_inode_init_security_anon(struct inode *inode, context_inode); } -int security_old_inode_init_security(struct inode *inode, struct inode *dir, - const struct qstr *qstr, const char **name, - void **value, size_t *len) -{ - if (unlikely(IS_PRIVATE(inode))) - return -EOPNOTSUPP; - return call_int_hook(inode_init_security, -EOPNOTSUPP, inode, dir, - qstr, name, value, len); -} -EXPORT_SYMBOL(security_old_inode_init_security); - #ifdef CONFIG_SECURITY_PATH int security_path_mknod(const struct path *dir, struct dentry *dentry, umode_t mode, unsigned int dev) -- 2.25.1
next prev parent reply other threads:[~2022-12-01 10:42 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-01 10:41 [PATCH v7 0/6] evm: Do HMAC of multiple per LSM xattrs for new inodes Roberto Sassu 2022-12-01 10:41 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2022-12-01 10:41 ` [PATCH v7 1/6] reiserfs: Switch to security_inode_init_security() Roberto Sassu 2022-12-01 10:41 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2023-02-17 19:47 ` Mimi Zohar 2023-02-17 19:47 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2022-12-01 10:41 ` [Ocfs2-devel] [PATCH v7 2/6] ocfs2: " Roberto Sassu via Ocfs2-devel 2022-12-01 10:41 ` Roberto Sassu 2023-01-10 8:55 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2023-01-10 8:55 ` Roberto Sassu 2023-01-12 17:21 ` [Ocfs2-devel] " Paul Moore via Ocfs2-devel 2023-01-12 17:21 ` Paul Moore 2023-02-08 14:33 ` Roberto Sassu 2023-02-08 14:33 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2023-02-09 21:05 ` Paul Moore 2023-02-09 21:05 ` [Ocfs2-devel] " Paul Moore via Ocfs2-devel 2023-02-21 6:45 ` Joseph Qi 2023-02-21 6:45 ` [Ocfs2-devel] " Joseph Qi via Ocfs2-devel 2023-02-21 7:51 ` Roberto Sassu 2023-02-21 7:51 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2023-02-17 19:51 ` Mimi Zohar 2023-02-17 19:51 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2023-02-17 21:30 ` Mimi Zohar 2023-02-17 21:30 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2023-02-20 9:27 ` Roberto Sassu 2023-02-20 9:27 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2023-02-20 11:08 ` Mimi Zohar 2023-02-20 11:08 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2023-02-20 12:20 ` Roberto Sassu 2023-02-20 12:20 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2023-02-20 12:40 ` Mimi Zohar 2023-02-20 12:40 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2023-02-20 8:34 ` Roberto Sassu 2023-02-20 8:34 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2022-12-01 10:41 ` Roberto Sassu via Ocfs2-devel [this message] 2022-12-01 10:41 ` [PATCH v7 3/6] security: Remove security_old_inode_init_security() Roberto Sassu 2023-02-19 19:41 ` Mimi Zohar 2023-02-19 19:41 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2022-12-01 10:41 ` [Ocfs2-devel] [PATCH v7 4/6] security: Allow all LSMs to provide xattrs for inode_init_security hook Roberto Sassu via Ocfs2-devel 2022-12-01 10:41 ` Roberto Sassu 2023-02-20 12:43 ` Mimi Zohar 2023-02-20 12:43 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2022-12-01 10:41 ` [Ocfs2-devel] [PATCH v7 5/6] evm: Align evm_inode_init_security() definition with LSM infrastructure Roberto Sassu via Ocfs2-devel 2022-12-01 10:41 ` Roberto Sassu 2023-02-19 19:41 ` Mimi Zohar 2023-02-19 19:41 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2022-12-01 10:41 ` [Ocfs2-devel] [PATCH v7 6/6] evm: Support multiple LSMs providing an xattr Roberto Sassu via Ocfs2-devel 2022-12-01 10:41 ` Roberto Sassu 2023-02-19 19:42 ` Mimi Zohar 2023-02-19 19:42 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2023-02-20 9:49 ` Roberto Sassu 2023-02-20 9:49 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2023-02-20 10:56 ` Mimi Zohar 2023-02-20 10:56 ` [Ocfs2-devel] " Mimi Zohar via Ocfs2-devel 2023-01-12 17:15 ` [Ocfs2-devel] [PATCH v7 0/6] evm: Do HMAC of multiple per LSM xattrs for new inodes Paul Moore via Ocfs2-devel 2023-01-12 17:15 ` Paul Moore 2023-01-13 10:35 ` [Ocfs2-devel] " Roberto Sassu via Ocfs2-devel 2023-01-13 10:35 ` Roberto Sassu 2023-03-08 22:16 ` Paul Moore 2023-03-08 22:16 ` Paul Moore 2023-03-08 22:16 ` [Ocfs2-devel] " Paul Moore via Ocfs2-devel 2023-03-09 7:53 ` Roberto Sassu via Ocfs2-devel 2023-03-09 7:53 ` Roberto Sassu 2023-03-09 7:53 ` Roberto Sassu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221201104125.919483-4-roberto.sassu@huaweicloud.com \ --to=ocfs2-devel@oss.oracle.com \ --cc=casey@schaufler-ca.com \ --cc=dmitry.kasatkin@gmail.com \ --cc=eparis@parisplace.org \ --cc=jlbec@evilplan.org \ --cc=jmorris@namei.org \ --cc=joseph.qi@linux.alibaba.com \ --cc=keescook@chromium.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=mark@fasheh.com \ --cc=nicolas.bouchinet@clip-os.org \ --cc=paul@paul-moore.com \ --cc=reiserfs-devel@vger.kernel.org \ --cc=roberto.sassu@huawei.com \ --cc=roberto.sassu@huaweicloud.com \ --cc=selinux@vger.kernel.org \ --cc=serge@hallyn.com \ --cc=stephen.smalley.work@gmail.com \ --cc=zohar@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.