From: Colin Foster <colin.foster@in-advantage.com> To: linux-renesas-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: "John Crispin" <john@phrozen.org>, "Alexandre Belloni" <alexandre.belloni@bootlin.com>, "Claudiu Manoil" <claudiu.manoil@nxp.com>, "Marek Vasut" <marex@denx.de>, "Sean Wang" <sean.wang@mediatek.com>, "DENG Qingfang" <dqfext@gmail.com>, "Landen Chao" <Landen.Chao@mediatek.com>, "nç ÜNAL" <arinc.unal@arinc9.com>, "Vivien Didelot" <vivien.didelot@gmail.com>, "Clément Léger" <clement.leger@bootlin.com>, "Alvin Šipraga" <alsi@bang-olufsen.dk>, "Linus Walleij" <linus.walleij@linaro.org>, UNGLinuxDriver@microchip.com, "Woojung Huh" <woojung.huh@microchip.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Kurt Kanzenbach" <kurt@linutronix.de>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Jakub Kicinski" <kuba@kernel.org>, "Eric Dumazet" <edumazet@google.com>, "David S. Miller" <davem@davemloft.net>, "Vladimir Oltean" <olteanv@gmail.com>, "Florian Fainelli" <f.fainelli@gmail.com>, "Andrew Lunn" <andrew@lunn.ch>, "George McCollister" <george.mccollister@gmail.com> Subject: [PATCH v4 net-next 5/9] dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml Date: Fri, 2 Dec 2022 12:45:55 -0800 [thread overview] Message-ID: <20221202204559.162619-6-colin.foster@in-advantage.com> (raw) In-Reply-To: <20221202204559.162619-1-colin.foster@in-advantage.com> The dsa.yaml binding contains duplicated bindings for address and size cells, as well as the reference to dsa-port.yaml. Instead of duplicating this information, remove the reference to dsa-port.yaml and include the full reference to dsa.yaml. Signed-off-by: Colin Foster <colin.foster@in-advantage.com> Suggested-by: Vladimir Oltean <olteanv@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> --- v3 -> v4 * Add Reviewed tag * Remove unnecessary blank line deletion v2 -> v3 * Remove #address-cells and #size-cells from v2. The examples were incorrect and fixed elsewhere. * Remove erroneous unevaluatedProperties: true under Ethernet Port. * Add back ref: dsa-port.yaml#. v1 -> v2 * Add #address-cells and #size-cells to the switch layer. They aren't part of dsa.yaml. * Add unevaluatedProperties: true to the ethernet-port layer so it can correctly read properties from dsa.yaml. --- Documentation/devicetree/bindings/net/dsa/qca8k.yaml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml index 6fc9bc985726..389892592aac 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml @@ -66,15 +66,11 @@ properties: With the legacy mapping the reg corresponding to the internal mdio is the switch reg with an offset of -1. +$ref: "dsa.yaml#" + patternProperties: "^(ethernet-)?ports$": type: object - properties: - '#address-cells': - const: 1 - '#size-cells': - const: 0 - patternProperties: "^(ethernet-)?port@[0-6]$": type: object @@ -116,7 +112,7 @@ required: - compatible - reg -additionalProperties: true +unevaluatedProperties: false examples: - | -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Colin Foster <colin.foster@in-advantage.com> To: linux-renesas-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: "John Crispin" <john@phrozen.org>, "Alexandre Belloni" <alexandre.belloni@bootlin.com>, "Claudiu Manoil" <claudiu.manoil@nxp.com>, "Marek Vasut" <marex@denx.de>, "Sean Wang" <sean.wang@mediatek.com>, "DENG Qingfang" <dqfext@gmail.com>, "Landen Chao" <Landen.Chao@mediatek.com>, "nç ÜNAL" <arinc.unal@arinc9.com>, "Vivien Didelot" <vivien.didelot@gmail.com>, "Clément Léger" <clement.leger@bootlin.com>, "Alvin Šipraga" <alsi@bang-olufsen.dk>, "Linus Walleij" <linus.walleij@linaro.org>, UNGLinuxDriver@microchip.com, "Woojung Huh" <woojung.huh@microchip.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Kurt Kanzenbach" <kurt@linutronix.de>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Jakub Kicinski" <kuba@kernel.org>, "Eric Dumazet" <edumazet@google.com>, "David S. Miller" <davem@davemloft.net>, "Vladimir Oltean" <olteanv@gmail.com>, "Florian Fainelli" <f.fainelli@gmail.com>, "Andrew Lunn" <andrew@lunn.ch>, "George McCollister" <george.mccollister@gmail.com> Subject: [PATCH v4 net-next 5/9] dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml Date: Fri, 2 Dec 2022 12:45:55 -0800 [thread overview] Message-ID: <20221202204559.162619-6-colin.foster@in-advantage.com> (raw) In-Reply-To: <20221202204559.162619-1-colin.foster@in-advantage.com> The dsa.yaml binding contains duplicated bindings for address and size cells, as well as the reference to dsa-port.yaml. Instead of duplicating this information, remove the reference to dsa-port.yaml and include the full reference to dsa.yaml. Signed-off-by: Colin Foster <colin.foster@in-advantage.com> Suggested-by: Vladimir Oltean <olteanv@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> --- v3 -> v4 * Add Reviewed tag * Remove unnecessary blank line deletion v2 -> v3 * Remove #address-cells and #size-cells from v2. The examples were incorrect and fixed elsewhere. * Remove erroneous unevaluatedProperties: true under Ethernet Port. * Add back ref: dsa-port.yaml#. v1 -> v2 * Add #address-cells and #size-cells to the switch layer. They aren't part of dsa.yaml. * Add unevaluatedProperties: true to the ethernet-port layer so it can correctly read properties from dsa.yaml. --- Documentation/devicetree/bindings/net/dsa/qca8k.yaml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml index 6fc9bc985726..389892592aac 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml @@ -66,15 +66,11 @@ properties: With the legacy mapping the reg corresponding to the internal mdio is the switch reg with an offset of -1. +$ref: "dsa.yaml#" + patternProperties: "^(ethernet-)?ports$": type: object - properties: - '#address-cells': - const: 1 - '#size-cells': - const: 0 - patternProperties: "^(ethernet-)?port@[0-6]$": type: object @@ -116,7 +112,7 @@ required: - compatible - reg -additionalProperties: true +unevaluatedProperties: false examples: - | -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-02 20:47 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-02 20:45 [PATCH v4 net-next 0/9] dt-binding preparation for ocelot switches Colin Foster 2022-12-02 20:45 ` Colin Foster 2022-12-02 20:45 ` [PATCH v4 net-next 1/9] dt-bindings: net: dsa: sf2: fix brcm,use-bcm-hdr documentation Colin Foster 2022-12-02 20:45 ` Colin Foster 2022-12-02 20:45 ` [PATCH v4 net-next 2/9] dt-bindings: net: dsa: qca8k: remove address-cells and size-cells from switch node Colin Foster 2022-12-02 20:45 ` Colin Foster 2022-12-02 20:45 ` [PATCH v4 net-next 3/9] dt-bindings: net: dsa: utilize base definitions for standard dsa switches Colin Foster 2022-12-02 20:45 ` Colin Foster 2022-12-02 21:45 ` Arınç ÜNAL 2022-12-02 21:45 ` Arınç ÜNAL 2022-12-06 2:20 ` Colin Foster 2022-12-06 2:20 ` Colin Foster 2022-12-05 18:29 ` Arınç ÜNAL 2022-12-05 18:29 ` Arınç ÜNAL 2022-12-05 21:42 ` Rob Herring 2022-12-05 21:42 ` Rob Herring 2022-12-06 15:18 ` Vladimir Oltean 2022-12-06 15:18 ` Vladimir Oltean 2022-12-07 2:24 ` Colin Foster 2022-12-07 2:24 ` Colin Foster 2022-12-06 15:37 ` Vladimir Oltean 2022-12-06 15:37 ` Vladimir Oltean 2022-12-07 2:27 ` Colin Foster 2022-12-07 2:27 ` Colin Foster 2022-12-09 9:10 ` Krzysztof Kozlowski 2022-12-09 9:10 ` Krzysztof Kozlowski 2022-12-02 20:45 ` [PATCH v4 net-next 4/9] dt-bindings: net: dsa: allow additional ethernet-port properties Colin Foster 2022-12-02 20:45 ` Colin Foster 2022-12-05 21:42 ` Rob Herring 2022-12-05 21:42 ` Rob Herring 2022-12-02 20:45 ` Colin Foster [this message] 2022-12-02 20:45 ` [PATCH v4 net-next 5/9] dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml Colin Foster 2022-12-05 21:42 ` Rob Herring 2022-12-05 21:42 ` Rob Herring 2022-12-02 20:45 ` [PATCH v4 net-next 6/9] dt-bindings: net: dsa: mediatek,mt7530: remove unnecessary dsa-port reference Colin Foster 2022-12-02 20:45 ` Colin Foster 2022-12-05 21:44 ` Rob Herring 2022-12-05 21:44 ` Rob Herring 2022-12-02 20:45 ` [PATCH v4 net-next 7/9] dt-bindings: net: add generic ethernet-switch Colin Foster 2022-12-02 20:45 ` Colin Foster 2022-12-05 21:47 ` Rob Herring 2022-12-05 21:47 ` Rob Herring 2022-12-02 20:45 ` [PATCH v4 net-next 8/9] dt-bindings: net: add generic ethernet-switch-port binding Colin Foster 2022-12-02 20:45 ` Colin Foster 2022-12-05 21:45 ` Rob Herring 2022-12-05 21:45 ` Rob Herring 2022-12-06 15:50 ` Vladimir Oltean 2022-12-06 15:50 ` Vladimir Oltean 2022-12-07 2:49 ` Colin Foster 2022-12-07 2:49 ` Colin Foster 2022-12-02 20:45 ` [PATCH v4 net-next 9/9] dt-bindings: net: mscc,vsc7514-switch: utilize generic ethernet-switch.yaml Colin Foster 2022-12-02 20:45 ` Colin Foster 2022-12-06 16:04 ` [PATCH v4 net-next 0/9] dt-binding preparation for ocelot switches Vladimir Oltean 2022-12-06 16:04 ` Vladimir Oltean 2022-12-07 3:07 ` Colin Foster 2022-12-07 3:07 ` Colin Foster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221202204559.162619-6-colin.foster@in-advantage.com \ --to=colin.foster@in-advantage.com \ --cc=Landen.Chao@mediatek.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=alsi@bang-olufsen.dk \ --cc=andrew@lunn.ch \ --cc=arinc.unal@arinc9.com \ --cc=claudiu.manoil@nxp.com \ --cc=clement.leger@bootlin.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=dqfext@gmail.com \ --cc=edumazet@google.com \ --cc=f.fainelli@gmail.com \ --cc=george.mccollister@gmail.com \ --cc=john@phrozen.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kuba@kernel.org \ --cc=kurt@linutronix.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=marex@denx.de \ --cc=matthias.bgg@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=pabeni@redhat.com \ --cc=robh+dt@kernel.org \ --cc=sean.wang@mediatek.com \ --cc=vivien.didelot@gmail.com \ --cc=woojung.huh@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.