All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Brown <doug@schmorgal.com>
To: Russell King <linux@armlinux.org.uk>, Lubomir Rintel <lkundrak@v3.sk>
Cc: soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Doug Brown <doug@schmorgal.com>
Subject: [PATCH 0/2] ARM: mmp: PXA168 timer fixes
Date: Sat,  3 Dec 2022 16:51:15 -0800	[thread overview]
Message-ID: <20221204005117.53452-1-doug@schmorgal.com> (raw)

This series contains a couple of bug fixes for the PXA168 timer. The
clock wasn't assigned in pxa168.dtsi which eventually resulted in a hang
at every boot after the clock was disabled. Also, the timer read
function wasn't waiting long enough to capture the new timer value,
which resulted in erroneous high CPU usage percent being reported with
CONFIG_NO_HZ_IDLE=y.

I don't have any other MMP systems to test with, but I suspect the timer
read delay problem also affected them. For example, the OLPC XO-4 kernel
disabled CONFIG_NO_HZ due to incorrect high CPU usage reporting:

http://dev.laptop.org/git/olpc-kernel/commit?h=arm-3.5&id=5bd2520f8f51fc44911ec7a86b84f41a1f3e384c

CCing soc@kernel.org because I didn't receive any responses when I
submitted these last time and was hoping these fixes could get merged.

Doug Brown (2):
  ARM: dts: pxa168: add timer reset and clock
  ARM: mmp: fix timer_read delay

 arch/arm/boot/dts/pxa168.dtsi |  2 ++
 arch/arm/mach-mmp/time.c      | 11 +++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Doug Brown <doug@schmorgal.com>
To: Russell King <linux@armlinux.org.uk>, Lubomir Rintel <lkundrak@v3.sk>
Cc: soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Doug Brown <doug@schmorgal.com>
Subject: [PATCH 0/2] ARM: mmp: PXA168 timer fixes
Date: Sat,  3 Dec 2022 16:51:15 -0800	[thread overview]
Message-ID: <20221204005117.53452-1-doug@schmorgal.com> (raw)

This series contains a couple of bug fixes for the PXA168 timer. The
clock wasn't assigned in pxa168.dtsi which eventually resulted in a hang
at every boot after the clock was disabled. Also, the timer read
function wasn't waiting long enough to capture the new timer value,
which resulted in erroneous high CPU usage percent being reported with
CONFIG_NO_HZ_IDLE=y.

I don't have any other MMP systems to test with, but I suspect the timer
read delay problem also affected them. For example, the OLPC XO-4 kernel
disabled CONFIG_NO_HZ due to incorrect high CPU usage reporting:

http://dev.laptop.org/git/olpc-kernel/commit?h=arm-3.5&id=5bd2520f8f51fc44911ec7a86b84f41a1f3e384c

CCing soc@kernel.org because I didn't receive any responses when I
submitted these last time and was hoping these fixes could get merged.

Doug Brown (2):
  ARM: dts: pxa168: add timer reset and clock
  ARM: mmp: fix timer_read delay

 arch/arm/boot/dts/pxa168.dtsi |  2 ++
 arch/arm/mach-mmp/time.c      | 11 +++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2022-12-04  0:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-04  0:51 Doug Brown [this message]
2022-12-04  0:51 ` [PATCH 0/2] ARM: mmp: PXA168 timer fixes Doug Brown
2022-12-04  0:51 ` [PATCH 1/2] ARM: dts: pxa168: add timer reset and clock Doug Brown
2022-12-04  0:51   ` Doug Brown
2022-12-04  0:51 ` [PATCH 2/2] ARM: mmp: fix timer_read delay Doug Brown
2022-12-04  0:51   ` Doug Brown
2022-12-04 12:20 ` [PATCH 0/2] ARM: mmp: PXA168 timer fixes patchwork-bot+linux-soc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221204005117.53452-1-doug@schmorgal.com \
    --to=doug@schmorgal.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=lkundrak@v3.sk \
    --cc=robh+dt@kernel.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.