All of lore.kernel.org
 help / color / mirror / Atom feed
From: <quic_mmitkov@quicinc.com>
To: <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<robert.foss@linaro.org>, <akapatra@quicinc.com>,
	<jzala@quicinc.com>, <todor.too@gmail.com>
Cc: <agross@kernel.org>, <konrad.dybcio@somainline.org>,
	<mchehab@kernel.org>, <bryan.odonoghue@linaro.org>,
	<cgera@qti.qualcomm.com>, <gchinnab@quicinc.com>,
	<ayasan@qti.qualcomm.com>, <laurent.pinchart@ideasonboard.com>,
	Milen Mitkov <quic_mmitkov@quicinc.com>
Subject: [PATCH v6 2/4] media: camss: vfe: Reserve VFE lines on stream start and link to CSID
Date: Mon, 5 Dec 2022 17:24:48 +0200	[thread overview]
Message-ID: <20221205152450.1099-3-quic_mmitkov@quicinc.com> (raw)
In-Reply-To: <20221205152450.1099-1-quic_mmitkov@quicinc.com>

From: Milen Mitkov <quic_mmitkov@quicinc.com>

For multiple virtual channels support, each VFE line can be in either
ON, RESERVED or OFF states. This allows the starting and stopping
of a VFE line independently of other active VFE lines.

Also, link the CSID entity's source ports to corresponding VFE lines.

Signed-off-by: Milen Mitkov <quic_mmitkov@quicinc.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: Robert Foss <robert.foss@linaro.org>
---
 drivers/media/platform/qcom/camss/camss-vfe.c | 1 +
 drivers/media/platform/qcom/camss/camss.c     | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
index a26e4a5d87b6..e0832f3f4f25 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe.c
@@ -740,6 +740,7 @@ static int vfe_set_stream(struct v4l2_subdev *sd, int enable)
 	int ret;
 
 	if (enable) {
+		line->output.state = VFE_OUTPUT_RESERVED;
 		ret = vfe->ops->vfe_enable(line);
 		if (ret < 0)
 			dev_err(vfe->camss->dev,
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 9cda284f1e71..547099f8ed14 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -1320,7 +1320,7 @@ static int camss_register_entities(struct camss *camss)
 					struct v4l2_subdev *vfe = &camss->vfe[k].line[j].subdev;
 
 					ret = media_create_pad_link(&csid->entity,
-								    MSM_CSID_PAD_SRC,
+								    MSM_CSID_PAD_FIRST_SRC + j,
 								    &vfe->entity,
 								    MSM_VFE_PAD_SINK,
 								    0);
-- 
2.37.3


  parent reply	other threads:[~2022-12-05 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 15:24 [PATCH v6 0/4] media: camss: sm8250: Virtual channels support for SM8250 quic_mmitkov
2022-12-05 15:24 ` [PATCH v6 1/4] media: camss: sm8250: Virtual channels for CSID quic_mmitkov
2022-12-05 15:24 ` quic_mmitkov [this message]
2022-12-06 13:55   ` [PATCH v6 2/4] media: camss: vfe: Reserve VFE lines on stream start and link to CSID Bryan O'Donoghue
2022-12-05 15:24 ` [PATCH v6 3/4] media: camss: vfe-480: Multiple outputs support for SM8250 quic_mmitkov
2022-12-05 15:24 ` [PATCH v6 4/4] media: camss: sm8250: Pipeline starting and stopping for multiple virtual channels quic_mmitkov
2022-12-05 16:43   ` Bryan O'Donoghue
2022-12-05 16:49     ` Milen Mitkov (Consultant)
2022-12-05 17:01       ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205152450.1099-3-quic_mmitkov@quicinc.com \
    --to=quic_mmitkov@quicinc.com \
    --cc=agross@kernel.org \
    --cc=akapatra@quicinc.com \
    --cc=ayasan@qti.qualcomm.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=cgera@qti.qualcomm.com \
    --cc=gchinnab@quicinc.com \
    --cc=jzala@quicinc.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robert.foss@linaro.org \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.