From: Paul Kocialkowski <paul.kocialkowski@bootlin.com> To: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Cc: Yong Deng <yong.deng@magewell.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Hans Verkuil <hverkuil@xs4all.nl>, Sakari Ailus <sakari.ailus@iki.fi>, Conor Dooley <conor@kernel.org>, Nathan Chancellor <nathan@kernel.org> Subject: [PATCH v3 08/12] media: sun6i-isp: proc: Error out on invalid port to fix warning Date: Thu, 8 Dec 2022 15:20:02 +0100 [thread overview] Message-ID: <20221208142006.425809-9-paul.kocialkowski@bootlin.com> (raw) In-Reply-To: <20221208142006.425809-1-paul.kocialkowski@bootlin.com> The enabled variable is only set for a valid port and used later, which triggers an uninitialized use smatch warning. Explicitly error out in that case to fix the warning. Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Fixes: e3185e1d7c14 ("media: staging: media: Add support for the Allwinner A31 ISP") --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c index a95709d2c573..4f34c1bc8be9 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c @@ -416,7 +416,7 @@ static int sun6i_isp_proc_notifier_bound(struct v4l2_async_notifier *notifier, enabled = !proc->source_csi0.expected; break; default: - break; + return -EINVAL; } source->subdev = remote_subdev; -- 2.38.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com> To: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Cc: Yong Deng <yong.deng@magewell.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Hans Verkuil <hverkuil@xs4all.nl>, Sakari Ailus <sakari.ailus@iki.fi>, Conor Dooley <conor@kernel.org>, Nathan Chancellor <nathan@kernel.org> Subject: [PATCH v3 08/12] media: sun6i-isp: proc: Error out on invalid port to fix warning Date: Thu, 8 Dec 2022 15:20:02 +0100 [thread overview] Message-ID: <20221208142006.425809-9-paul.kocialkowski@bootlin.com> (raw) In-Reply-To: <20221208142006.425809-1-paul.kocialkowski@bootlin.com> The enabled variable is only set for a valid port and used later, which triggers an uninitialized use smatch warning. Explicitly error out in that case to fix the warning. Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Fixes: e3185e1d7c14 ("media: staging: media: Add support for the Allwinner A31 ISP") --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c index a95709d2c573..4f34c1bc8be9 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c @@ -416,7 +416,7 @@ static int sun6i_isp_proc_notifier_bound(struct v4l2_async_notifier *notifier, enabled = !proc->source_csi0.expected; break; default: - break; + return -EINVAL; } source->subdev = remote_subdev; -- 2.38.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-08 14:20 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-08 14:19 [PATCH v3 00/12] Allwinner A31/A83T CSI/ISP/MIPI CSI-2 media fixes Paul Kocialkowski 2022-12-08 14:19 ` Paul Kocialkowski 2022-12-08 14:19 ` [PATCH v3 01/12] media: sun6i-csi: bridge: Fix return code handling in stream off path Paul Kocialkowski 2022-12-08 14:19 ` Paul Kocialkowski 2022-12-08 14:19 ` [PATCH v3 02/12] media: sun6i-csi: bridge: Error out on invalid port to fix warning Paul Kocialkowski 2022-12-08 14:19 ` Paul Kocialkowski 2022-12-08 14:19 ` [PATCH v3 03/12] media: sunxi-csi: bridge: Declare subdev ops as static Paul Kocialkowski 2022-12-08 14:19 ` Paul Kocialkowski 2022-12-08 14:19 ` [PATCH v3 04/12] media: sun6i-csi: capture: Remove useless ret initialization Paul Kocialkowski 2022-12-08 14:19 ` Paul Kocialkowski 2022-12-08 14:19 ` [PATCH v3 05/12] media: sun6i-mipi-csi2: Clarify return code handling in stream off path Paul Kocialkowski 2022-12-08 14:19 ` Paul Kocialkowski 2022-12-08 14:20 ` [PATCH v3 06/12] media: sun8i-a83t-mipi-csi2: " Paul Kocialkowski 2022-12-08 14:20 ` Paul Kocialkowski 2022-12-08 14:20 ` [PATCH v3 07/12] media: sun6i-isp: proc: Fix " Paul Kocialkowski 2022-12-08 14:20 ` Paul Kocialkowski 2022-12-08 14:20 ` Paul Kocialkowski [this message] 2022-12-08 14:20 ` [PATCH v3 08/12] media: sun6i-isp: proc: Error out on invalid port to fix warning Paul Kocialkowski 2022-12-08 14:20 ` [PATCH v3 09/12] media: sun6i-isp: proc: Declare subdev ops as static Paul Kocialkowski 2022-12-08 14:20 ` Paul Kocialkowski 2022-12-08 14:20 ` [PATCH v3 10/12] media: sun6i-isp: capture: Fix uninitialized variable use Paul Kocialkowski 2022-12-08 14:20 ` Paul Kocialkowski 2022-12-08 14:20 ` [PATCH v3 11/12] media: sun6i-isp: params: Fix incorrect indentation Paul Kocialkowski 2022-12-08 14:20 ` Paul Kocialkowski 2022-12-08 14:20 ` [PATCH v3 12/12] media: sun6i-isp: params: Unregister pending buffer on cleanup Paul Kocialkowski 2022-12-08 14:20 ` Paul Kocialkowski 2022-12-17 4:12 ` [PATCH v3 00/12] Allwinner A31/A83T CSI/ISP/MIPI CSI-2 media fixes Palmer Dabbelt 2022-12-17 4:12 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221208142006.425809-9-paul.kocialkowski@bootlin.com \ --to=paul.kocialkowski@bootlin.com \ --cc=conor@kernel.org \ --cc=hverkuil@xs4all.nl \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=linux-sunxi@lists.linux.dev \ --cc=mchehab@kernel.org \ --cc=nathan@kernel.org \ --cc=sakari.ailus@iki.fi \ --cc=samuel@sholland.org \ --cc=thomas.petazzoni@bootlin.com \ --cc=wens@csie.org \ --cc=yong.deng@magewell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.