From: Yu Kuai <yukuai1@huaweicloud.com> To: tj@kernel.org, hch@infradead.org, josef@toxicpanda.com, axboe@kernel.dk Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com Subject: [PATCH -next 1/4] blk-iocost: track whether iocg is still online Date: Sat, 17 Dec 2022 11:05:24 +0800 [thread overview] Message-ID: <20221217030527.1250083-2-yukuai1@huaweicloud.com> (raw) In-Reply-To: <20221217030527.1250083-1-yukuai1@huaweicloud.com> From: Yu Kuai <yukuai3@huawei.com> blkcg_gq->online can't be used in iocost because it gets cleared only after all policies are offlined. This patch add a new field 'online' in iocg. Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- block/blk-iocost.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/block/blk-iocost.c b/block/blk-iocost.c index 3aeb8538f0c3..1498879c4a52 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -459,6 +459,8 @@ struct ioc_gq { struct blkg_policy_data pd; struct ioc *ioc; + bool online; + /* * A iocg can get its weight from two sources - an explicit * per-device-cgroup configuration or the default weight of the @@ -2952,6 +2954,7 @@ static void ioc_pd_init(struct blkg_policy_data *pd) ioc_now(ioc, &now); iocg->ioc = ioc; + iocg->online = true; atomic64_set(&iocg->vtime, now.vnow); atomic64_set(&iocg->done_vtime, now.vnow); atomic64_set(&iocg->active_period, atomic64_read(&ioc->cur_period)); @@ -2977,6 +2980,19 @@ static void ioc_pd_init(struct blkg_policy_data *pd) spin_unlock_irqrestore(&ioc->lock, flags); } +static void ioc_pd_offline(struct blkg_policy_data *pd) +{ + struct ioc_gq *iocg = pd_to_iocg(pd); + struct ioc *ioc = iocg->ioc; + unsigned long flags; + + if (ioc) { + spin_lock_irqsave(&ioc->lock, flags); + iocg->online = false; + spin_unlock_irqrestore(&ioc->lock, flags); + } +} + static void ioc_pd_free(struct blkg_policy_data *pd) { struct ioc_gq *iocg = pd_to_iocg(pd); @@ -3467,6 +3483,7 @@ static struct blkcg_policy blkcg_policy_iocost = { .cpd_free_fn = ioc_cpd_free, .pd_alloc_fn = ioc_pd_alloc, .pd_init_fn = ioc_pd_init, + .pd_offline_fn = ioc_pd_offline, .pd_free_fn = ioc_pd_free, .pd_stat_fn = ioc_pd_stat, }; -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Yu Kuai <yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org> To: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org, yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Subject: [PATCH -next 1/4] blk-iocost: track whether iocg is still online Date: Sat, 17 Dec 2022 11:05:24 +0800 [thread overview] Message-ID: <20221217030527.1250083-2-yukuai1@huaweicloud.com> (raw) In-Reply-To: <20221217030527.1250083-1-yukuai1-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org> From: Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> blkcg_gq->online can't be used in iocost because it gets cleared only after all policies are offlined. This patch add a new field 'online' in iocg. Signed-off-by: Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> --- block/blk-iocost.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/block/blk-iocost.c b/block/blk-iocost.c index 3aeb8538f0c3..1498879c4a52 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -459,6 +459,8 @@ struct ioc_gq { struct blkg_policy_data pd; struct ioc *ioc; + bool online; + /* * A iocg can get its weight from two sources - an explicit * per-device-cgroup configuration or the default weight of the @@ -2952,6 +2954,7 @@ static void ioc_pd_init(struct blkg_policy_data *pd) ioc_now(ioc, &now); iocg->ioc = ioc; + iocg->online = true; atomic64_set(&iocg->vtime, now.vnow); atomic64_set(&iocg->done_vtime, now.vnow); atomic64_set(&iocg->active_period, atomic64_read(&ioc->cur_period)); @@ -2977,6 +2980,19 @@ static void ioc_pd_init(struct blkg_policy_data *pd) spin_unlock_irqrestore(&ioc->lock, flags); } +static void ioc_pd_offline(struct blkg_policy_data *pd) +{ + struct ioc_gq *iocg = pd_to_iocg(pd); + struct ioc *ioc = iocg->ioc; + unsigned long flags; + + if (ioc) { + spin_lock_irqsave(&ioc->lock, flags); + iocg->online = false; + spin_unlock_irqrestore(&ioc->lock, flags); + } +} + static void ioc_pd_free(struct blkg_policy_data *pd) { struct ioc_gq *iocg = pd_to_iocg(pd); @@ -3467,6 +3483,7 @@ static struct blkcg_policy blkcg_policy_iocost = { .cpd_free_fn = ioc_cpd_free, .pd_alloc_fn = ioc_pd_alloc, .pd_init_fn = ioc_pd_init, + .pd_offline_fn = ioc_pd_offline, .pd_free_fn = ioc_pd_free, .pd_stat_fn = ioc_pd_stat, }; -- 2.31.1
next prev parent reply other threads:[~2022-12-17 2:44 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-17 3:05 [PATCH -next 0/4] blk-iocost: make sure parent iocg is exited before child Yu Kuai 2022-12-17 3:05 ` Yu Kuai 2022-12-17 3:05 ` Yu Kuai [this message] 2022-12-17 3:05 ` [PATCH -next 1/4] blk-iocost: track whether iocg is still online Yu Kuai 2022-12-21 10:33 ` Christoph Hellwig 2022-12-26 1:10 ` Yu Kuai 2022-12-26 1:10 ` Yu Kuai 2022-12-17 3:05 ` [PATCH -next 2/4] blk-iocost: don't throttle bio if iocg is offlined Yu Kuai 2022-12-19 21:28 ` Tejun Heo 2022-12-20 9:38 ` Yu Kuai 2022-12-20 9:38 ` Yu Kuai 2022-12-17 3:05 ` [PATCH -next 3/4] blk-iocost: dispatch all throttled bio in ioc_pd_offline Yu Kuai 2022-12-19 21:31 ` Tejun Heo 2022-12-19 21:31 ` Tejun Heo 2022-12-17 3:05 ` [PATCH -next 4/4] blk-iocost: guarantee the exit order of iocg Yu Kuai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221217030527.1250083-2-yukuai1@huaweicloud.com \ --to=yukuai1@huaweicloud.com \ --cc=axboe@kernel.dk \ --cc=cgroups@vger.kernel.org \ --cc=hch@infradead.org \ --cc=josef@toxicpanda.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tj@kernel.org \ --cc=yi.zhang@huawei.com \ --cc=yukuai3@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.