From: Matthew Brost <matthew.brost@intel.com> To: <intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org> Subject: [Intel-gfx] [RFC PATCH 06/20] drm/sched: Start run wq before TDR in drm_sched_start Date: Thu, 22 Dec 2022 14:21:13 -0800 [thread overview] Message-ID: <20221222222127.34560-7-matthew.brost@intel.com> (raw) In-Reply-To: <20221222222127.34560-1-matthew.brost@intel.com> If the TDR is set to a very small value it can fire before the run wq is started in the function drm_sched_start. The run wq is expected to running when the TDR fires, fix this ordering so this expectation is always met. Signed-off-by: Matthew Brost <matthew.brost@intel.com> --- drivers/gpu/drm/scheduler/sched_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 8e688c2fc482..f39fdc01c37b 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -586,13 +586,13 @@ void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery) drm_sched_job_done(s_job); } + drm_sched_run_wq_start(sched); + if (full_recovery) { spin_lock(&sched->job_list_lock); drm_sched_start_timeout(sched); spin_unlock(&sched->job_list_lock); } - - drm_sched_run_wq_start(sched); } EXPORT_SYMBOL(drm_sched_start); -- 2.37.3
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Brost <matthew.brost@intel.com> To: <intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org> Subject: [RFC PATCH 06/20] drm/sched: Start run wq before TDR in drm_sched_start Date: Thu, 22 Dec 2022 14:21:13 -0800 [thread overview] Message-ID: <20221222222127.34560-7-matthew.brost@intel.com> (raw) In-Reply-To: <20221222222127.34560-1-matthew.brost@intel.com> If the TDR is set to a very small value it can fire before the run wq is started in the function drm_sched_start. The run wq is expected to running when the TDR fires, fix this ordering so this expectation is always met. Signed-off-by: Matthew Brost <matthew.brost@intel.com> --- drivers/gpu/drm/scheduler/sched_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 8e688c2fc482..f39fdc01c37b 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -586,13 +586,13 @@ void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery) drm_sched_job_done(s_job); } + drm_sched_run_wq_start(sched); + if (full_recovery) { spin_lock(&sched->job_list_lock); drm_sched_start_timeout(sched); spin_unlock(&sched->job_list_lock); } - - drm_sched_run_wq_start(sched); } EXPORT_SYMBOL(drm_sched_start); -- 2.37.3
next prev parent reply other threads:[~2022-12-22 22:29 UTC|newest] Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-22 22:21 [RFC PATCH 00/20] Initial Xe driver submission Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] [RFC PATCH 01/20] drm/suballoc: Introduce a generic suballocation manager Matthew Brost 2022-12-22 22:21 ` Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] [RFC PATCH 02/20] drm/amd: Convert amdgpu to use suballocation helper Matthew Brost 2022-12-22 22:21 ` Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] [RFC PATCH 03/20] drm/radeon: Use the drm suballocation manager implementation Matthew Brost 2022-12-22 22:21 ` Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread Matthew Brost 2022-12-22 22:21 ` Matthew Brost 2022-12-23 17:42 ` [Intel-gfx] " Rob Clark 2022-12-28 22:21 ` Matthew Brost 2022-12-30 10:20 ` Boris Brezillon 2022-12-30 10:20 ` [Intel-gfx] " Boris Brezillon 2022-12-30 11:55 ` Boris Brezillon 2022-12-30 11:55 ` [Intel-gfx] " Boris Brezillon 2023-01-02 7:30 ` Boris Brezillon 2023-01-02 7:30 ` [Intel-gfx] " Boris Brezillon 2023-01-03 13:02 ` Tvrtko Ursulin 2023-01-03 14:21 ` Boris Brezillon 2023-01-03 14:21 ` Boris Brezillon 2023-01-05 21:43 ` Matthew Brost 2023-01-05 21:43 ` Matthew Brost 2023-01-06 23:52 ` Matthew Brost 2023-01-09 13:46 ` Tvrtko Ursulin 2023-01-09 17:27 ` Jason Ekstrand 2023-01-09 17:27 ` Jason Ekstrand 2023-01-10 11:28 ` Tvrtko Ursulin 2023-01-10 11:28 ` Tvrtko Ursulin 2023-01-10 12:19 ` Tvrtko Ursulin 2023-01-10 12:19 ` Tvrtko Ursulin 2023-01-10 15:55 ` Matthew Brost 2023-01-10 15:55 ` Matthew Brost 2023-01-10 16:50 ` Tvrtko Ursulin 2023-01-10 16:50 ` Tvrtko Ursulin 2023-01-10 19:01 ` Matthew Brost 2023-01-10 19:01 ` Matthew Brost 2023-01-11 9:17 ` Tvrtko Ursulin 2023-01-11 9:17 ` Tvrtko Ursulin 2023-01-11 18:07 ` Matthew Brost 2023-01-11 18:07 ` Matthew Brost 2023-01-11 18:52 ` John Harrison 2023-01-11 18:55 ` Matthew Brost 2023-01-11 18:55 ` Matthew Brost 2023-01-10 14:08 ` Jason Ekstrand 2023-01-10 14:08 ` Jason Ekstrand 2023-01-11 8:50 ` Tvrtko Ursulin 2023-01-11 8:50 ` Tvrtko Ursulin 2023-01-11 19:40 ` Matthew Brost 2023-01-11 19:40 ` Matthew Brost 2023-01-12 18:43 ` Tvrtko Ursulin 2023-01-12 18:43 ` Tvrtko Ursulin 2023-01-11 22:18 ` Jason Ekstrand 2023-01-11 22:18 ` Jason Ekstrand 2023-01-11 22:31 ` Matthew Brost 2023-01-11 22:31 ` Matthew Brost 2023-01-11 22:56 ` Jason Ekstrand 2023-01-11 22:56 ` Jason Ekstrand 2023-01-13 0:39 ` John Harrison 2023-01-18 3:06 ` Matthew Brost 2023-01-18 3:06 ` Matthew Brost 2023-01-10 16:39 ` Matthew Brost 2023-01-10 16:39 ` Matthew Brost 2023-01-11 1:13 ` Matthew Brost 2023-01-11 1:13 ` Matthew Brost 2023-01-11 9:09 ` Tvrtko Ursulin 2023-01-11 9:09 ` Tvrtko Ursulin 2023-01-11 17:52 ` Matthew Brost 2023-01-11 17:52 ` Matthew Brost 2023-01-12 18:21 ` Tvrtko Ursulin 2023-01-12 18:21 ` Tvrtko Ursulin 2023-01-05 19:40 ` Matthew Brost 2023-01-05 19:40 ` [Intel-gfx] " Matthew Brost 2023-01-09 15:45 ` Jason Ekstrand 2023-01-09 15:45 ` Jason Ekstrand 2023-01-09 17:17 ` Boris Brezillon 2023-01-09 17:17 ` Boris Brezillon 2023-01-09 20:40 ` Daniel Vetter 2023-01-09 20:40 ` Daniel Vetter 2023-01-10 8:46 ` Boris Brezillon 2023-01-10 8:46 ` Boris Brezillon 2023-01-11 21:47 ` Daniel Vetter 2023-01-11 21:47 ` Daniel Vetter 2023-01-12 9:10 ` Boris Brezillon 2023-01-12 9:10 ` Boris Brezillon 2023-01-12 9:32 ` Daniel Vetter 2023-01-12 9:32 ` Daniel Vetter 2023-01-12 10:11 ` Boris Brezillon 2023-01-12 10:11 ` Boris Brezillon 2023-01-12 10:25 ` Boris Brezillon 2023-01-12 10:25 ` Boris Brezillon 2023-01-12 10:42 ` Daniel Vetter 2023-01-12 10:42 ` Daniel Vetter 2023-01-12 12:08 ` Boris Brezillon 2023-01-12 12:08 ` Boris Brezillon 2023-01-12 15:38 ` Daniel Vetter 2023-01-12 15:38 ` Daniel Vetter 2023-01-12 16:48 ` Boris Brezillon 2023-01-12 16:48 ` Boris Brezillon 2023-01-12 10:30 ` Boris Brezillon 2023-01-12 10:30 ` Boris Brezillon 2022-12-22 22:21 ` [RFC PATCH 05/20] drm/sched: Add generic scheduler message interface Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` Matthew Brost [this message] 2022-12-22 22:21 ` [RFC PATCH 06/20] drm/sched: Start run wq before TDR in drm_sched_start Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 07/20] drm/sched: Submit job before starting TDR Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] [RFC PATCH 08/20] drm/sched: Add helper to set TDR timeout Matthew Brost 2022-12-22 22:21 ` Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] [RFC PATCH 09/20] drm: Add a gpu page-table walker helper Matthew Brost 2022-12-22 22:21 ` Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 10/20] drm/ttm: Don't print error message if eviction was interrupted Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 11/20] drm/i915: Remove gem and overlay frontbuffer tracking Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-23 11:13 ` Tvrtko Ursulin 2022-12-22 22:21 ` [Intel-gfx] [RFC PATCH 12/20] drm/i915/display: Neuter frontbuffer tracking harder Matthew Brost 2022-12-22 22:21 ` Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 13/20] drm/i915/display: Add more macros to remove all direct calls to uncore Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 14/20] drm/i915/display: Remove all uncore mmio accesses in favor of intel_de Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] [RFC PATCH 15/20] drm/i915: Rename find_section to find_bdb_section Matthew Brost 2022-12-22 22:21 ` Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 16/20] drm/i915/regs: Set DISPLAY_MMIO_BASE to 0 for xe Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 17/20] drm/i915/display: Fix a use-after-free when intel_edp_init_connector fails Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 18/20] drm/i915/display: Remaining changes to make xe compile Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 19/20] sound/hda: Allow XE as i915 replacement for sound Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:21 ` [RFC PATCH 20/20] mei/hdcp: Also enable for XE Matthew Brost 2022-12-22 22:21 ` [Intel-gfx] " Matthew Brost 2022-12-22 22:41 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Initial Xe driver submission Patchwork 2023-01-02 8:14 ` [RFC PATCH 00/20] " Thomas Zimmermann 2023-01-02 8:14 ` [Intel-gfx] " Thomas Zimmermann 2023-01-02 11:42 ` Jani Nikula 2023-01-02 11:42 ` [Intel-gfx] " Jani Nikula 2023-01-03 13:56 ` Boris Brezillon 2023-01-03 13:56 ` [Intel-gfx] " Boris Brezillon 2023-01-03 14:41 ` Alyssa Rosenzweig 2023-01-03 14:41 ` [Intel-gfx] " Alyssa Rosenzweig 2023-01-03 12:21 ` Tvrtko Ursulin 2023-01-05 21:27 ` Matthew Brost 2023-01-12 9:54 ` Lucas De Marchi 2023-01-12 9:54 ` Lucas De Marchi 2023-01-12 17:10 ` Matthew Brost 2023-01-12 17:10 ` Matthew Brost 2023-01-17 16:40 ` Jason Ekstrand 2023-01-10 12:33 ` Boris Brezillon 2023-01-10 12:33 ` [Intel-gfx] " Boris Brezillon 2023-01-17 16:12 ` Jason Ekstrand 2023-02-17 20:51 ` Daniel Vetter 2023-02-17 20:51 ` [Intel-gfx] " Daniel Vetter 2023-02-27 12:46 ` Oded Gabbay 2023-02-27 12:46 ` [Intel-gfx] " Oded Gabbay 2023-03-01 23:00 ` Rodrigo Vivi 2023-03-01 23:00 ` Rodrigo Vivi 2023-03-09 15:10 ` Daniel Vetter 2023-03-09 15:10 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221222222127.34560-7-matthew.brost@intel.com \ --to=matthew.brost@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.