From: Bryan O'Donoghue <bryan.odonoghue@linaro.org> To: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, dianders@chromium.org, david@ixit.cz, krzysztof.kozlowski+dt@linaro.org, swboyd@chromium.org, konrad.dybcio@somainline.org, agross@kernel.org, andersson@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH v6 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Date: Fri, 23 Dec 2022 02:10:09 +0000 [thread overview] Message-ID: <20221223021025.1646636-3-bryan.odonoghue@linaro.org> (raw) In-Reply-To: <20221223021025.1646636-1-bryan.odonoghue@linaro.org> power-domain is required for the sc7180 dispcc GDSC but not every qcom SoC has a similar dependency for example the apq8064. Most Qcom SoC's using mdss-dsi-ctrl seem to have the ability to power-collapse the MDP without collapsing DSI. For example the qcom vendor kernel commit for apq8084, msm8226, msm8916, msm8974. https://review.carbonrom.org/plugins/gitiles/CarbonROM/android_kernel_oneplus_msm8994/+/7b5c011a770daa2811778937ed646237a28a8694 "ARM: dts: msm: add mdss gdsc supply to dsi controller device It is possible for the DSI controller to be active when MDP is power collapsed. DSI controller needs to have it's own vote for mdss gdsc to ensure that gdsc remains on in such cases." This however doesn't appear to be the case for the apq8064 so we shouldn't be marking power-domain as required in yaml checks. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index 55bfe1101d6f4..8ba61fef576a5 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -137,7 +137,6 @@ required: - phys - assigned-clocks - assigned-clock-parents - - power-domains - ports additionalProperties: false -- 2.38.1
WARNING: multiple messages have this Message-ID (diff)
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org> To: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, krzysztof.kozlowski+dt@linaro.org, sean@poorly.run, andersson@kernel.org, konrad.dybcio@somainline.org, quic_abhinavk@quicinc.com, david@ixit.cz, dianders@chromium.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, robh+dt@kernel.org, agross@kernel.org, dmitry.baryshkov@linaro.org, bryan.odonoghue@linaro.org, swboyd@chromium.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Date: Fri, 23 Dec 2022 02:10:09 +0000 [thread overview] Message-ID: <20221223021025.1646636-3-bryan.odonoghue@linaro.org> (raw) In-Reply-To: <20221223021025.1646636-1-bryan.odonoghue@linaro.org> power-domain is required for the sc7180 dispcc GDSC but not every qcom SoC has a similar dependency for example the apq8064. Most Qcom SoC's using mdss-dsi-ctrl seem to have the ability to power-collapse the MDP without collapsing DSI. For example the qcom vendor kernel commit for apq8084, msm8226, msm8916, msm8974. https://review.carbonrom.org/plugins/gitiles/CarbonROM/android_kernel_oneplus_msm8994/+/7b5c011a770daa2811778937ed646237a28a8694 "ARM: dts: msm: add mdss gdsc supply to dsi controller device It is possible for the DSI controller to be active when MDP is power collapsed. DSI controller needs to have it's own vote for mdss gdsc to ensure that gdsc remains on in such cases." This however doesn't appear to be the case for the apq8064 so we shouldn't be marking power-domain as required in yaml checks. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index 55bfe1101d6f4..8ba61fef576a5 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -137,7 +137,6 @@ required: - phys - assigned-clocks - assigned-clock-parents - - power-domains - ports additionalProperties: false -- 2.38.1
next prev parent reply other threads:[~2022-12-23 2:10 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-23 2:10 [PATCH v6 00/18] mdss-dsi-ctrl binding and dts fixes Bryan O'Donoghue 2022-12-23 2:10 ` Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue 2022-12-23 2:10 ` Bryan O'Donoghue 2022-12-23 2:10 ` Bryan O'Donoghue [this message] 2022-12-23 2:10 ` [PATCH v6 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 03/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue 2022-12-23 2:10 ` Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue 2022-12-23 2:10 ` Bryan O'Donoghue 2023-01-10 5:48 ` Dmitry Baryshkov 2023-01-10 5:48 ` Dmitry Baryshkov 2022-12-23 2:10 ` [PATCH v6 05/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue 2022-12-23 2:10 ` Bryan O'Donoghue 2023-01-10 5:47 ` Dmitry Baryshkov 2023-01-10 5:47 ` Dmitry Baryshkov 2022-12-23 2:10 ` [PATCH v6 06/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue 2022-12-23 2:10 ` Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 07/18] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats Bryan O'Donoghue 2022-12-23 2:10 ` Bryan O'Donoghue 2023-01-04 0:29 ` Rob Herring 2023-01-04 0:29 ` Rob Herring 2023-01-04 9:37 ` Dmitry Baryshkov 2023-01-04 9:37 ` Dmitry Baryshkov 2022-12-23 2:10 ` [PATCH v6 08/18] ARM: dts: qcom: apq8064: add compat qcom,apq8064-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 08/18] ARM: dts: qcom: apq8064: add compat qcom, apq8064-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 09/18] ARM: dts: qcom: msm8974: Add compat qcom,msm8974-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 09/18] ARM: dts: qcom: msm8974: Add compat qcom, msm8974-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 10/18] arm64: dts: qcom: msm8916: Add compat qcom,msm8916-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 10/18] arm64: dts: qcom: msm8916: Add compat qcom, msm8916-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 11/18] arm64: dts: qcom: msm8953: Add compat qcom,msm8953-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 11/18] arm64: dts: qcom: msm8953: Add compat qcom, msm8953-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 12/18] arm64: dts: qcom: msm8996: Add compat qcom,msm8996-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 12/18] arm64: dts: qcom: msm8996: Add compat qcom, msm8996-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 13/18] arm64: dts: qcom: sc7180: Add compat qcom, sc7180-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 13/18] arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 14/18] arm64: dts: qcom: sc7280: Add compat qcom, sc7280-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 14/18] arm64: dts: qcom: sc7280: Add compat qcom,sc7280-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 15/18] arm64: dts: qcom: sdm630: Add compat qcom, sdm660-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 15/18] arm64: dts: qcom: sdm630: Add compat qcom,sdm660-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 16/18] arm64: dts: qcom: sdm660: Add compat qcom, sdm660-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 16/18] arm64: dts: qcom: sdm660: Add compat qcom,sdm660-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 17/18] arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 17/18] arm64: dts: qcom: sdm845: Add compat qcom, sdm845-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 18/18] arm64: dts: qcom: sm8250: Add compat qcom, sm8250-dsi-ctrl Bryan O'Donoghue 2022-12-23 2:10 ` [PATCH v6 18/18] arm64: dts: qcom: sm8250: Add compat qcom,sm8250-dsi-ctrl Bryan O'Donoghue 2022-12-29 17:23 ` (subset) [PATCH v6 00/18] mdss-dsi-ctrl binding and dts fixes Bjorn Andersson 2022-12-29 17:23 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221223021025.1646636-3-bryan.odonoghue@linaro.org \ --to=bryan.odonoghue@linaro.org \ --cc=agross@kernel.org \ --cc=airlied@gmail.com \ --cc=andersson@kernel.org \ --cc=daniel@ffwll.ch \ --cc=david@ixit.cz \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=konrad.dybcio@somainline.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.