All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Holland <samuel@sholland.org>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
	Samuel Holland <samuel@sholland.org>
Subject: [PATCH 2/2] rtc: sun6i: Drop the unused has_out_clk flag
Date: Thu, 29 Dec 2022 12:40:11 -0600	[thread overview]
Message-ID: <20221229184011.62925-2-samuel@sholland.org> (raw)
In-Reply-To: <20221229184011.62925-1-samuel@sholland.org>

This flag was never used by the driver.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/rtc/rtc-sun6i.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
index a22358a44e32..52049f139474 100644
--- a/drivers/rtc/rtc-sun6i.c
+++ b/drivers/rtc/rtc-sun6i.c
@@ -135,7 +135,6 @@ struct sun6i_rtc_clk_data {
 	unsigned long rc_osc_rate;
 	unsigned int fixed_prescaler : 16;
 	unsigned int has_prescaler : 1;
-	unsigned int has_out_clk : 1;
 	unsigned int export_iosc : 1;
 	unsigned int has_losc_en : 1;
 	unsigned int has_auto_swt : 1;
@@ -346,7 +345,6 @@ CLK_OF_DECLARE_DRIVER(sun6i_a31_rtc_clk, "allwinner,sun6i-a31-rtc",
 static const struct sun6i_rtc_clk_data sun8i_a23_rtc_data = {
 	.rc_osc_rate = 667000, /* datasheet says 600 ~ 700 KHz */
 	.has_prescaler = 1,
-	.has_out_clk = 1,
 };
 
 static void __init sun8i_a23_rtc_clk_init(struct device_node *node)
@@ -360,7 +358,6 @@ static const struct sun6i_rtc_clk_data sun8i_h3_rtc_data = {
 	.rc_osc_rate = 16000000,
 	.fixed_prescaler = 32,
 	.has_prescaler = 1,
-	.has_out_clk = 1,
 	.export_iosc = 1,
 };
 
@@ -378,7 +375,6 @@ static const struct sun6i_rtc_clk_data sun50i_h6_rtc_data = {
 	.rc_osc_rate = 16000000,
 	.fixed_prescaler = 32,
 	.has_prescaler = 1,
-	.has_out_clk = 1,
 	.export_iosc = 1,
 	.has_losc_en = 1,
 	.has_auto_swt = 1,
@@ -409,7 +405,6 @@ CLK_OF_DECLARE_DRIVER(sun8i_r40_rtc_clk, "allwinner,sun8i-r40-rtc",
 
 static const struct sun6i_rtc_clk_data sun8i_v3_rtc_data = {
 	.rc_osc_rate = 32000,
-	.has_out_clk = 1,
 };
 
 static void __init sun8i_v3_rtc_clk_init(struct device_node *node)
-- 
2.37.4


WARNING: multiple messages have this Message-ID (diff)
From: Samuel Holland <samuel@sholland.org>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
	Samuel Holland <samuel@sholland.org>
Subject: [PATCH 2/2] rtc: sun6i: Drop the unused has_out_clk flag
Date: Thu, 29 Dec 2022 12:40:11 -0600	[thread overview]
Message-ID: <20221229184011.62925-2-samuel@sholland.org> (raw)
In-Reply-To: <20221229184011.62925-1-samuel@sholland.org>

This flag was never used by the driver.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/rtc/rtc-sun6i.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
index a22358a44e32..52049f139474 100644
--- a/drivers/rtc/rtc-sun6i.c
+++ b/drivers/rtc/rtc-sun6i.c
@@ -135,7 +135,6 @@ struct sun6i_rtc_clk_data {
 	unsigned long rc_osc_rate;
 	unsigned int fixed_prescaler : 16;
 	unsigned int has_prescaler : 1;
-	unsigned int has_out_clk : 1;
 	unsigned int export_iosc : 1;
 	unsigned int has_losc_en : 1;
 	unsigned int has_auto_swt : 1;
@@ -346,7 +345,6 @@ CLK_OF_DECLARE_DRIVER(sun6i_a31_rtc_clk, "allwinner,sun6i-a31-rtc",
 static const struct sun6i_rtc_clk_data sun8i_a23_rtc_data = {
 	.rc_osc_rate = 667000, /* datasheet says 600 ~ 700 KHz */
 	.has_prescaler = 1,
-	.has_out_clk = 1,
 };
 
 static void __init sun8i_a23_rtc_clk_init(struct device_node *node)
@@ -360,7 +358,6 @@ static const struct sun6i_rtc_clk_data sun8i_h3_rtc_data = {
 	.rc_osc_rate = 16000000,
 	.fixed_prescaler = 32,
 	.has_prescaler = 1,
-	.has_out_clk = 1,
 	.export_iosc = 1,
 };
 
@@ -378,7 +375,6 @@ static const struct sun6i_rtc_clk_data sun50i_h6_rtc_data = {
 	.rc_osc_rate = 16000000,
 	.fixed_prescaler = 32,
 	.has_prescaler = 1,
-	.has_out_clk = 1,
 	.export_iosc = 1,
 	.has_losc_en = 1,
 	.has_auto_swt = 1,
@@ -409,7 +405,6 @@ CLK_OF_DECLARE_DRIVER(sun8i_r40_rtc_clk, "allwinner,sun8i-r40-rtc",
 
 static const struct sun6i_rtc_clk_data sun8i_v3_rtc_data = {
 	.rc_osc_rate = 32000,
-	.has_out_clk = 1,
 };
 
 static void __init sun8i_v3_rtc_clk_init(struct device_node *node)
-- 
2.37.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-29 18:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 18:40 [PATCH 1/2] rtc: sun6i: Prevent an out-of-bounds read Samuel Holland
2022-12-29 18:40 ` Samuel Holland
2022-12-29 18:40 ` Samuel Holland [this message]
2022-12-29 18:40   ` [PATCH 2/2] rtc: sun6i: Drop the unused has_out_clk flag Samuel Holland
2023-01-05 17:18   ` Jernej Škrabec
2023-01-05 17:18     ` Jernej Škrabec
2023-01-05 17:26 ` [PATCH 1/2] rtc: sun6i: Prevent an out-of-bounds read Jernej Škrabec
2023-01-05 17:26   ` Jernej Škrabec
2023-01-07 17:15   ` Samuel Holland
2023-01-07 17:15     ` Samuel Holland
2023-01-08 19:39     ` Jernej Škrabec
2023-01-08 19:39       ` Jernej Škrabec
2023-02-12 21:10       ` Samuel Holland
2023-02-12 21:10         ` Samuel Holland
2023-02-09 22:49 ` Alexandre Belloni
2023-02-09 22:49   ` Alexandre Belloni
2023-02-12 21:11   ` Samuel Holland
2023-02-12 21:11     ` Samuel Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221229184011.62925-2-samuel@sholland.org \
    --to=samuel@sholland.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.