From: Emilio Cota <cota@braap.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Aaron Lindsay" <aaron@os.amperecomputing.com>,
"Emilio Cota" <cota@braap.org>
Subject: [PATCH 3/4] tcg: exclude lookup_tb_ptr from helper instrumentation
Date: Sun, 8 Jan 2023 11:47:30 -0500 [thread overview]
Message-ID: <20230108164731.61469-4-cota@braap.org> (raw)
In-Reply-To: <20230108164731.61469-1-cota@braap.org>
It is internal to TCG and therefore we know it does not
access guest memory.
Related: #1381
Signed-off-by: Emilio Cota <cota@braap.org>
---
tcg/tcg.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index da91779890..ee67eefc0c 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -1652,8 +1652,10 @@ void tcg_gen_callN(void *func, TCGTemp *ret, int nargs, TCGTemp **args)
op = tcg_op_alloc(INDEX_op_call, total_args);
#ifdef CONFIG_PLUGIN
- /* detect non-plugin helpers */
- if (tcg_ctx->plugin_insn && unlikely(strncmp(info->name, "plugin_", 7))) {
+ /* flag helpers that are not internal to TCG */
+ if (tcg_ctx->plugin_insn &&
+ strncmp(info->name, "plugin_", 7) &&
+ strcmp(info->name, "lookup_tb_ptr")) {
tcg_ctx->plugin_insn->calls_helpers = true;
}
#endif
--
2.34.1
next prev parent reply other threads:[~2023-01-08 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 16:47 [PATCH 0/4] plugin patches to fix #1381 Emilio Cota
2023-01-08 16:47 ` [PATCH 1/4] plugins: fix optimization in plugin_gen_disable_mem_helpers Emilio Cota
2023-01-10 15:29 ` Aaron Lindsay
2023-01-08 16:47 ` [PATCH 2/4] translator: always pair plugin_gen_insn_{start, end} calls Emilio Cota
2023-01-08 19:56 ` Philippe Mathieu-Daudé
2023-01-10 15:26 ` [PATCH 2/4] translator: always pair plugin_gen_insn_{start,end} calls Aaron Lindsay
2023-01-08 16:47 ` Emilio Cota [this message]
2023-01-08 16:51 ` [PATCH 4/4] cpu-exec: assert that plugin_mem_cbs is NULL after execution Emilio Cota
2023-01-09 13:52 ` Alex Bennée
2023-01-10 2:16 ` Emilio Cota
2023-01-10 13:02 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108164731.61469-4-cota@braap.org \
--to=cota@braap.org \
--cc=aaron@os.amperecomputing.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.