From: Christoph Hellwig <hch@lst.de> To: Andrew Morton <akpm@linux-foundation.org>, Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com>, Dave Kleikamp <shaggy@kernel.org>, Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>, Joseph Qi <joseph.qi@linux.alibaba.com>, Evgeniy Dushistov <dushistov@mail.ru>, "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: linux-btrfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/7] btrfs: stop using write_one_page in btrfs_scratch_superblock Date: Sun, 8 Jan 2023 17:56:40 +0100 [thread overview] Message-ID: <20230108165645.381077-3-hch@lst.de> (raw) In-Reply-To: <20230108165645.381077-1-hch@lst.de> write_one_page is an awkward interface that expects the page locked and ->writepage to be implemented. Just mark the sb dirty, put the page and then call the proper bdev helper to sync the range. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/btrfs/volumes.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 1378f5ad5ed4c4..10e98b004a2fa3 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -2009,23 +2009,22 @@ static void btrfs_scratch_superblock(struct btrfs_fs_info *fs_info, struct block_device *bdev, int copy_num) { struct btrfs_super_block *disk_super; - struct page *page; + const size_t len = sizeof(disk_super->magic); + u64 bytenr = btrfs_sb_offset(copy_num); int ret; - disk_super = btrfs_read_dev_one_super(bdev, copy_num, false); + disk_super = btrfs_read_disk_super(bdev, bytenr, bytenr); if (IS_ERR(disk_super)) return; - memset(&disk_super->magic, 0, sizeof(disk_super->magic)); - page = virt_to_page(disk_super); - set_page_dirty(page); - lock_page(page); - /* write_on_page() unlocks the page */ - ret = write_one_page(page); + memset(&disk_super->magic, 0, len); + set_page_dirty(virt_to_page(disk_super)); + btrfs_release_disk_super(disk_super); + + ret = sync_blockdev_range(bdev, bytenr, bytenr + len - 1); if (ret) btrfs_warn(fs_info, "error clearing superblock number %d (%d)", copy_num, ret); - btrfs_release_disk_super(disk_super); } void btrfs_scratch_superblocks(struct btrfs_fs_info *fs_info, -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com> To: Andrew Morton <akpm@linux-foundation.org>, Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com>, Dave Kleikamp <shaggy@kernel.org>, Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>, Joseph Qi <joseph.qi@linux.alibaba.com>, Evgeniy Dushistov <dushistov@mail.ru>, "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-btrfs@vger.kernel.org Subject: [Ocfs2-devel] [PATCH 2/7] btrfs: stop using write_one_page in btrfs_scratch_superblock Date: Sun, 8 Jan 2023 17:56:40 +0100 [thread overview] Message-ID: <20230108165645.381077-3-hch@lst.de> (raw) In-Reply-To: <20230108165645.381077-1-hch@lst.de> write_one_page is an awkward interface that expects the page locked and ->writepage to be implemented. Just mark the sb dirty, put the page and then call the proper bdev helper to sync the range. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/btrfs/volumes.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 1378f5ad5ed4c4..10e98b004a2fa3 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -2009,23 +2009,22 @@ static void btrfs_scratch_superblock(struct btrfs_fs_info *fs_info, struct block_device *bdev, int copy_num) { struct btrfs_super_block *disk_super; - struct page *page; + const size_t len = sizeof(disk_super->magic); + u64 bytenr = btrfs_sb_offset(copy_num); int ret; - disk_super = btrfs_read_dev_one_super(bdev, copy_num, false); + disk_super = btrfs_read_disk_super(bdev, bytenr, bytenr); if (IS_ERR(disk_super)) return; - memset(&disk_super->magic, 0, sizeof(disk_super->magic)); - page = virt_to_page(disk_super); - set_page_dirty(page); - lock_page(page); - /* write_on_page() unlocks the page */ - ret = write_one_page(page); + memset(&disk_super->magic, 0, len); + set_page_dirty(virt_to_page(disk_super)); + btrfs_release_disk_super(disk_super); + + ret = sync_blockdev_range(bdev, bytenr, bytenr + len - 1); if (ret) btrfs_warn(fs_info, "error clearing superblock number %d (%d)", copy_num, ret); - btrfs_release_disk_super(disk_super); } void btrfs_scratch_superblocks(struct btrfs_fs_info *fs_info, -- 2.35.1 _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2023-01-08 16:57 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-08 16:56 remove write_one_page / folio_write_one Christoph Hellwig 2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel 2023-01-08 16:56 ` [PATCH 1/7] btrfs: don't read the disk superblock for zoned devices in btrfs_scratch_superblocks Christoph Hellwig 2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel 2023-01-08 16:56 ` Christoph Hellwig [this message] 2023-01-08 16:56 ` [Ocfs2-devel] [PATCH 2/7] btrfs: stop using write_one_page in btrfs_scratch_superblock Christoph Hellwig via Ocfs2-devel 2023-01-08 21:13 ` Matthew Wilcox via Ocfs2-devel 2023-01-08 21:13 ` Matthew Wilcox 2023-01-08 16:56 ` [PATCH 3/7] minix: don't flush page immediately for DIRSYNC directories Christoph Hellwig 2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel 2023-01-08 21:17 ` Matthew Wilcox 2023-01-08 21:17 ` [Ocfs2-devel] " Matthew Wilcox via Ocfs2-devel 2023-01-10 8:22 ` Christoph Hellwig 2023-01-10 8:22 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel 2023-01-11 2:20 ` Al Viro 2023-01-11 2:20 ` [Ocfs2-devel] " Al Viro via Ocfs2-devel 2023-01-11 4:26 ` Christoph Hellwig via Ocfs2-devel 2023-01-11 4:26 ` Christoph Hellwig 2023-01-11 4:58 ` Al Viro 2023-01-11 4:58 ` [Ocfs2-devel] " Al Viro via Ocfs2-devel 2023-01-08 16:56 ` [PATCH 4/7] sysv: " Christoph Hellwig 2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel 2023-01-08 21:19 ` Matthew Wilcox 2023-01-08 21:19 ` [Ocfs2-devel] " Matthew Wilcox via Ocfs2-devel 2023-01-10 8:24 ` Christoph Hellwig via Ocfs2-devel 2023-01-10 8:24 ` Christoph Hellwig 2023-01-08 16:56 ` [PATCH 5/7] ufs: " Christoph Hellwig 2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel 2023-01-08 16:56 ` [PATCH 6/7] ocfs2: don't use write_one_page in ocfs2_duplicate_clusters_by_page Christoph Hellwig 2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel 2023-01-09 17:03 ` Jan Kara via Ocfs2-devel 2023-01-09 17:03 ` Jan Kara 2023-01-10 3:03 ` [Ocfs2-devel] " Joseph Qi via Ocfs2-devel 2023-01-10 3:03 ` Joseph Qi 2023-01-08 16:56 ` [PATCH 7/7] mm,jfs: move write_one_page/folio_write_one to jfs Christoph Hellwig 2023-01-08 16:56 ` [Ocfs2-devel] [PATCH 7/7] mm, jfs: " Christoph Hellwig via Ocfs2-devel 2023-01-08 21:31 ` remove write_one_page / folio_write_one Matthew Wilcox 2023-01-08 21:31 ` [Ocfs2-devel] " Matthew Wilcox via Ocfs2-devel 2023-01-09 19:53 ` David Sterba 2023-01-09 19:53 ` [Ocfs2-devel] " David Sterba via Ocfs2-devel 2023-01-10 8:16 ` Christoph Hellwig 2023-01-10 8:16 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel 2023-01-10 13:00 ` David Sterba 2023-01-10 13:00 ` [Ocfs2-devel] " David Sterba via Ocfs2-devel 2023-01-10 15:32 ` Christoph Hellwig via Ocfs2-devel 2023-01-10 15:32 ` Christoph Hellwig 2023-01-11 19:20 ` David Sterba 2023-01-11 19:20 ` [Ocfs2-devel] " David Sterba via Ocfs2-devel 2023-01-12 8:02 ` Christoph Hellwig 2023-01-12 8:02 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230108165645.381077-3-hch@lst.de \ --to=hch@lst.de \ --cc=akpm@linux-foundation.org \ --cc=clm@fb.com \ --cc=dsterba@suse.com \ --cc=dushistov@mail.ru \ --cc=jfs-discussion@lists.sourceforge.net \ --cc=jlbec@evilplan.org \ --cc=josef@toxicpanda.com \ --cc=joseph.qi@linux.alibaba.com \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mark@fasheh.com \ --cc=ocfs2-devel@oss.oracle.com \ --cc=shaggy@kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.