From: Sibi Sankar <quic_sibis@quicinc.com>
To: <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<robh+dt@kernel.org>, <manivannan.sadhasivam@linaro.org>,
<robin.murphy@arm.com>
Cc: <agross@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<konrad.dybcio@somainline.org>, <amit.pundir@linaro.org>,
<regressions@leemhuis.info>, <sumit.semwal@linaro.org>,
<will@kernel.org>, <catalin.marinas@arm.com>,
Sibi Sankar <quic_sibis@quicinc.com>
Subject: [PATCH V2 00/11] Fix XPU violation during modem metadata authentication
Date: Mon, 9 Jan 2023 09:18:32 +0530 [thread overview]
Message-ID: <20230109034843.23759-1-quic_sibis@quicinc.com> (raw)
The memory region allocated using dma_alloc_attr with no kernel mapping
attribute set would still be a part of the linear kernel map. Any access
to this region by the application processor after assigning it to the
remote Q6 will result in a XPU violation. Fix this by replacing the
dynamically allocated memory region with a no-map carveout and unmap the
modem metadata memory region before passing control to the remote Q6.
The addition of the carveout and memunmap is required only on SoCs that
mandate memory protection before transferring control to Q6, hence the
driver falls back to dynamic memory allocation in the absence of the
modem metadata carveout.
V2:
* Convert legacy bindings to yaml
* Revert no_kernel_mapping [Mani/Robin]
* Pad commit message to explain bindings break [Krzysztof]
* Split dt/bindings per SoC [Krzysztof]
Sibi Sankar (11):
dt-bindings: remoteproc: qcom,q6v5: Move MSM8996 to schema
dt-bindings: remoteproc: qcom,msm8996-mss-pil: Update memory region
dt-bindings: remoteproc: qcom,sc7180-mss-pil: Update memory-region
dt-bindings: remoteproc: qcom,sc7280-mss-pil: Update memory-region
remoteproc: qcom_q6v5_mss: revert "map/unmap metadata region
before/after use"
remoteproc: qcom_q6v5_mss: Use a carveout to authenticate modem
headers
arm64: dts: qcom: msm8996: Add a carveout for modem metadata
arm64: dts: qcom: msm8998: Add a carveout for modem metadata
arm64: dts: qcom: sdm845: Add a carveout for modem metadata
arm64: dts: qcom: sc7180: Add a carveout for modem metadata
arm64: dts: qcom: sc7280: Add a carveout for modem metadata
.../remoteproc/qcom,msm8996-mss-pil.yaml | 382 ++++++++++++++++++
.../bindings/remoteproc/qcom,q6v5.txt | 137 +------
.../remoteproc/qcom,sc7180-mss-pil.yaml | 3 +-
.../remoteproc/qcom,sc7280-mss-pil.yaml | 3 +-
.../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 6 +
arch/arm64/boot/dts/qcom/msm8996.dtsi | 9 +
arch/arm64/boot/dts/qcom/msm8998.dtsi | 9 +
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 7 +-
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 7 +-
.../dts/qcom/sc7280-herobrine-lte-sku.dtsi | 7 +-
arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +
drivers/remoteproc/qcom_q6v5_mss.c | 78 ++--
12 files changed, 486 insertions(+), 171 deletions(-)
create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
--
2.17.1
next reply other threads:[~2023-01-09 3:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 3:48 Sibi Sankar [this message]
2023-01-09 3:48 ` [PATCH V2 01/11] dt-bindings: remoteproc: qcom,q6v5: Move MSM8996 to schema Sibi Sankar
2023-01-10 9:33 ` Krzysztof Kozlowski
2023-01-09 3:48 ` [PATCH V2 02/11] dt-bindings: remoteproc: qcom,msm8996-mss-pil: Update memory region Sibi Sankar
2023-01-10 9:35 ` Krzysztof Kozlowski
2023-01-09 3:48 ` [PATCH V2 03/11] dt-bindings: remoteproc: qcom,sc7180-mss-pil: Update memory-region Sibi Sankar
2023-01-09 14:30 ` Rob Herring
2023-01-10 9:36 ` Krzysztof Kozlowski
2023-01-09 3:48 ` [PATCH V2 04/11] dt-bindings: remoteproc: qcom,sc7280-mss-pil: " Sibi Sankar
2023-01-10 9:36 ` Krzysztof Kozlowski
2023-01-09 3:48 ` [PATCH V2 05/11] remoteproc: qcom_q6v5_mss: revert "map/unmap metadata region before/after use" Sibi Sankar
2023-01-09 8:18 ` Manivannan Sadhasivam
2023-01-09 10:00 ` Sibi Sankar
2023-01-11 11:24 ` Manivannan Sadhasivam
2023-01-09 3:48 ` [PATCH V2 06/11] remoteproc: qcom_q6v5_mss: Use a carveout to authenticate modem headers Sibi Sankar
2023-01-09 8:32 ` Manivannan Sadhasivam
2023-01-09 10:05 ` Sibi Sankar
2023-01-11 11:23 ` Manivannan Sadhasivam
2023-01-09 3:48 ` [PATCH V2 07/11] arm64: dts: qcom: msm8996: Add a carveout for modem metadata Sibi Sankar
2023-01-09 3:48 ` [PATCH V2 08/11] arm64: dts: qcom: msm8998: " Sibi Sankar
2023-01-09 3:48 ` [PATCH V2 09/11] arm64: dts: qcom: sdm845: " Sibi Sankar
2023-01-09 3:48 ` [PATCH V2 10/11] arm64: dts: qcom: sc7180: " Sibi Sankar
2023-01-09 3:48 ` [PATCH V2 11/11] arm64: dts: qcom: sc7280: " Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109034843.23759-1-quic_sibis@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=regressions@leemhuis.info \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.