All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 25/38] hw/gpio/omap_gpio: Add local variable to avoid embedded cast
Date: Fri, 13 Jan 2023 14:11:13 +0000	[thread overview]
Message-ID: <20230113141126.535646-26-peter.maydell@linaro.org> (raw)
In-Reply-To: <20230113141126.535646-1-peter.maydell@linaro.org>

From: Philippe Mathieu-Daudé <philmd@linaro.org>

Add a local 'struct omap_gpif_s *' variable to improve readability.
(This also eases next commit conversion).

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20230109140306.23161-3-philmd@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/gpio/omap_gpio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c
index bd0841d57fe..12ec16d1b03 100644
--- a/hw/gpio/omap_gpio.c
+++ b/hw/gpio/omap_gpio.c
@@ -53,7 +53,8 @@ struct omap_gpif_s {
 /* General-Purpose I/O of OMAP1 */
 static void omap_gpio_set(void *opaque, int line, int level)
 {
-    struct omap_gpio_s *s = &((struct omap_gpif_s *) opaque)->omap1;
+    struct omap_gpif_s *p = opaque;
+    struct omap_gpio_s *s = &p->omap1;
     uint16_t prev = s->inputs;
 
     if (level)
-- 
2.34.1



  parent reply	other threads:[~2023-01-13 14:31 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 14:10 [PULL 00/38] target-arm queue Peter Maydell
2023-01-13 14:10 ` [PULL 01/38] hw/arm/stm32f405: correctly describe the memory layout Peter Maydell
2023-01-13 14:10 ` [PULL 02/38] hw/arm: Add Olimex H405 Peter Maydell
2023-01-13 14:10 ` [PULL 03/38] hw/misc: Allwinner-A10 Clock Controller Module Emulation Peter Maydell
2023-01-13 14:10 ` [PULL 04/38] hw/misc: Allwinner A10 DRAM Controller Emulation Peter Maydell
2023-01-13 14:10 ` [PULL 05/38] {hw/i2c,docs/system/arm}: Allwinner TWI/I2C Emulation Peter Maydell
2023-01-13 14:10 ` [PULL 06/38] hw/misc: AXP209 PMU Emulation Peter Maydell
2023-01-13 14:10 ` [PULL 07/38] hw/arm: Add AXP209 to Cubieboard Peter Maydell
2023-01-13 14:10 ` [PULL 08/38] hw/arm: Allwinner A10 enable SPL load from MMC Peter Maydell
2023-01-13 14:10 ` [PULL 09/38] tests/avocado: Add SD boot test to Cubieboard Peter Maydell
2023-01-13 14:10 ` [PULL 10/38] target/arm: Fix sve_probe_page Peter Maydell
2023-01-13 14:10 ` [PULL 11/38] hw/arm/pxa2xx: Simplify pxa255_init() Peter Maydell
2023-01-13 14:11 ` [PULL 12/38] hw/arm/pxa2xx: Simplify pxa270_init() Peter Maydell
2023-01-13 14:11 ` [PULL 13/38] hw/arm/collie: Use the IEC binary prefix definitions Peter Maydell
2023-01-13 14:11 ` [PULL 14/38] hw/arm/collie: Simplify flash creation using for() loop Peter Maydell
2023-01-13 14:11 ` [PULL 15/38] hw/arm/gumstix: Improve documentation Peter Maydell
2023-01-13 14:11 ` [PULL 16/38] hw/arm/gumstix: Use the IEC binary prefix definitions Peter Maydell
2023-01-13 14:11 ` [PULL 17/38] hw/arm/mainstone: " Peter Maydell
2023-01-13 14:11 ` [PULL 18/38] hw/arm/musicpal: " Peter Maydell
2023-01-13 14:11 ` [PULL 19/38] hw/arm/omap_sx1: Remove unused 'total_ram' definitions Peter Maydell
2023-01-13 14:11 ` [PULL 20/38] hw/arm/omap_sx1: Use the IEC binary prefix definitions Peter Maydell
2023-01-13 14:11 ` [PULL 21/38] hw/arm/z2: " Peter Maydell
2023-01-13 14:11 ` [PULL 22/38] hw/arm/vexpress: Remove dead code in vexpress_common_init() Peter Maydell
2023-01-13 14:11 ` [PULL 23/38] hw/arm: Remove unreachable code calling pflash_cfi01_register() Peter Maydell
2023-01-13 14:11 ` [PULL 24/38] hw/arm/pxa: Avoid forward-declaring PXA2xxI2CState Peter Maydell
2023-01-13 14:11 ` Peter Maydell [this message]
2023-01-13 14:11 ` [PULL 26/38] hw/arm/omap: Drop useless casts from void * to pointer Peter Maydell
2023-01-13 14:11 ` [PULL 27/38] hw/gpio/omap_gpio: Use CamelCase for TYPE_OMAP1_GPIO type name Peter Maydell
2023-01-13 14:11 ` [PULL 28/38] hw/gpio/omap_gpio: Use CamelCase for TYPE_OMAP2_GPIO " Peter Maydell
2023-01-13 14:11 ` [PULL 29/38] hw/intc/omap_intc: Use CamelCase for TYPE_OMAP_INTC " Peter Maydell
2023-01-13 14:11 ` [PULL 30/38] hw/arm/stellaris: Drop useless casts from void * to pointer Peter Maydell
2023-01-13 14:11 ` [PULL 31/38] hw/arm/stellaris: Use CamelCase for STELLARIS_ADC type name Peter Maydell
2023-01-13 14:11 ` [PULL 32/38] hw/arm/bcm2836: Remove definitions generated by OBJECT_DECLARE_TYPE() Peter Maydell
2023-01-13 14:11 ` [PULL 33/38] hw/arm/npcm7xx: Declare QOM macros using OBJECT_DECLARE_SIMPLE_TYPE() Peter Maydell
2023-01-13 14:11 ` [PULL 34/38] hw/misc/sbsa_ec: Rename TYPE_SBSA_EC -> TYPE_SBSA_SECURE_EC Peter Maydell
2023-01-13 14:11 ` [PULL 35/38] hw/misc/sbsa_ec: Declare QOM macros using OBJECT_DECLARE_SIMPLE_TYPE() Peter Maydell
2023-01-13 14:11 ` [PULL 36/38] hw/intc/xilinx_intc: Use 'XpsIntc' typedef instead of 'struct xlx_pic' Peter Maydell
2023-01-13 14:11 ` [PULL 37/38] hw/timer/xilinx_timer: Use XpsTimerState instead of 'struct timerblock' Peter Maydell
2023-01-13 14:11 ` [PULL 38/38] target/arm: allow writes to SCR_EL3.HXEn bit when FEAT_HCX is enabled Peter Maydell
2023-01-13 17:54 ` [PULL 00/38] target-arm queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113141126.535646-26-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.