From: Andrey Skvortsov <andrej.skvortzov@gmail.com>
To: Steve Longerbeam <slongerbeam@gmail.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andrey Skvortsov <andrej.skvortzov@gmail.com>
Subject: [PATCHv2] media: ov5640: Update last busy timestamp to reset autosuspend timer
Date: Sun, 15 Jan 2023 20:30:10 +0300 [thread overview]
Message-ID: <20230115173010.1237320-1-andrej.skvortzov@gmail.com> (raw)
In-Reply-To: <Y8KgGhu0e/+xIfDm@valkosipuli.retiisi.eu>
Otherwise autosuspend delay doesn't work and power is cut off
immediately as device is freed.
Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
---
Changes since PATCHv1:
* Removed pm_runtime_mask_last_busy call from ov5640_write_reg and ov5640_read_reg
as suggested by Sakari Ailus
* Updated diff against next-20230113
drivers/media/i2c/ov5640.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index e0f908af581b..24f4f395aad6 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -3316,6 +3316,7 @@ static int ov5640_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
break;
}
+ pm_runtime_mark_last_busy(&sensor->i2c_client->dev);
pm_runtime_put_autosuspend(&sensor->i2c_client->dev);
return 0;
@@ -3391,6 +3392,7 @@ static int ov5640_s_ctrl(struct v4l2_ctrl *ctrl)
break;
}
+ pm_runtime_mark_last_busy(&sensor->i2c_client->dev);
pm_runtime_put_autosuspend(&sensor->i2c_client->dev);
return ret;
@@ -3710,8 +3712,10 @@ static int ov5640_s_stream(struct v4l2_subdev *sd, int enable)
out:
mutex_unlock(&sensor->lock);
- if (!enable || ret)
+ if (!enable || ret) {
+ pm_runtime_mark_last_busy(&sensor->i2c_client->dev);
pm_runtime_put_autosuspend(&sensor->i2c_client->dev);
+ }
return ret;
}
@@ -3912,6 +3916,7 @@ static int ov5640_probe(struct i2c_client *client)
pm_runtime_set_autosuspend_delay(dev, 1000);
pm_runtime_use_autosuspend(dev);
+ pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev);
return 0;
--
2.39.0
prev parent reply other threads:[~2023-01-15 17:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 11:21 [PATCH] media: ov5640: Update last busy timestamp to reset autosuspend timer Andrey Skvortsov
2023-01-14 12:29 ` Sakari Ailus
2023-01-14 15:19 ` Jacopo Mondi
2023-01-14 21:49 ` Sakari Ailus
2023-01-15 17:28 ` Andrey Skvortsov
2023-01-15 17:30 ` Andrey Skvortsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230115173010.1237320-1-andrej.skvortzov@gmail.com \
--to=andrej.skvortzov@gmail.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.