All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wupeng Ma <mawupeng1@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<mawupeng1@huawei.com>, <kuleshovmail@gmail.com>,
	<aneesh.kumar@linux.ibm.com>
Subject: [PATCH v2 2/4] mm/mempolicy: return EINVAL for if len overflows for set_mempolicy_home_node
Date: Mon, 16 Jan 2023 19:58:11 +0800	[thread overview]
Message-ID: <20230116115813.2956935-3-mawupeng1@huawei.com> (raw)
In-Reply-To: <20230116115813.2956935-1-mawupeng1@huawei.com>

From: Ma Wupeng <mawupeng1@huawei.com>

Return -EINVAL if len overflows for set_mempolicy_home_node.

Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
---
 mm/mempolicy.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 02c8a712282f..153fda1ebb9c 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1488,6 +1488,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 		unsigned long, home_node, unsigned long, flags)
 {
 	struct mm_struct *mm = current->mm;
+	unsigned long old_len = len;
 	struct vm_area_struct *vma;
 	struct mempolicy *new;
 	unsigned long vmstart;
@@ -1515,7 +1516,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le
 	len = PAGE_ALIGN(len);
 	end = start + len;
 
-	if (end < start)
+	if (end < start || (old_len != 0 && len == 0))
 		return -EINVAL;
 	if (end == start)
 		return 0;
-- 
2.25.1


  parent reply	other threads:[~2023-01-16 11:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 11:58 [PATCH v2 0/4] Add overflow checks for several syscalls Wupeng Ma
2023-01-16 11:58 ` [PATCH v2 1/4] mm/mlock: return EINVAL if len overflows for mlock/munlock Wupeng Ma
2023-01-16 20:51   ` Andrew Morton
2023-01-17  7:09     ` mawupeng
2023-01-16 11:58 ` Wupeng Ma [this message]
2023-01-16 11:58 ` [PATCH v2 3/4] mm/mempolicy: return EINVAL if len overflows for mbind Wupeng Ma
2023-01-16 11:58 ` [PATCH v2 4/4] mm/msync: return ENOMEM if len overflows for msync Wupeng Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230116115813.2956935-3-mawupeng1@huawei.com \
    --to=mawupeng1@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=kuleshovmail@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.