All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Rodolfo Giometti <giometti@enneenne.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Johan Hovold <johan@kernel.org>,
	Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
	linux-kernel@vger.kernel.org
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v4 10/12] tty: Return bool from tty_termios_hw_change()
Date: Tue, 17 Jan 2023 11:03:56 +0200	[thread overview]
Message-ID: <20230117090358.4796-11-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230117090358.4796-1-ilpo.jarvinen@linux.intel.com>

Change tty_termios_hw_change() to return bool.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/tty/tty_ioctl.c | 8 ++++----
 include/linux/tty.h     | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index ce511557b98b..12983ce4e43e 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -270,13 +270,13 @@ EXPORT_SYMBOL(tty_termios_copy_hw);
  *	between the two termios structures, or a speed change is needed.
  */
 
-int tty_termios_hw_change(const struct ktermios *a, const struct ktermios *b)
+bool tty_termios_hw_change(const struct ktermios *a, const struct ktermios *b)
 {
 	if (a->c_ispeed != b->c_ispeed || a->c_ospeed != b->c_ospeed)
-		return 1;
+		return true;
 	if ((a->c_cflag ^ b->c_cflag) & ~(HUPCL | CREAD | CLOCAL))
-		return 1;
-	return 0;
+		return true;
+	return false;
 }
 EXPORT_SYMBOL(tty_termios_hw_change);
 
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 730c3301d710..093935e97f42 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -453,7 +453,7 @@ unsigned char tty_get_char_size(unsigned int cflag);
 unsigned char tty_get_frame_size(unsigned int cflag);
 
 void tty_termios_copy_hw(struct ktermios *new, const struct ktermios *old);
-int tty_termios_hw_change(const struct ktermios *a, const struct ktermios *b);
+bool tty_termios_hw_change(const struct ktermios *a, const struct ktermios *b);
 int tty_set_termios(struct tty_struct *tty, struct ktermios *kt);
 
 void tty_wakeup(struct tty_struct *tty);
-- 
2.30.2


  parent reply	other threads:[~2023-01-17  9:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17  9:03 [PATCH v4 00/12] tty/serial: bool conversions and cleanups Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 01/12] tty: Cleanup tty_port_set_initialized() bool parameter Ilpo Järvinen
2023-01-17  9:03   ` Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 02/12] tty: Cleamup tty_port_set_suspended() " Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 03/12] tty: Cleanup tty_port_set_active() " Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 04/12] tty: moxa: Make local var storing tty_port_initialized() bool Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 05/12] serial: Convert uart_{,port_}startup() init_hw param to bool Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 06/12] tty: Convert ->carrier_raised() and callchains " Ilpo Järvinen
2023-01-17  9:03   ` Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 07/12] tty: Convert ->dtr_rts() to take bool argument Ilpo Järvinen
2023-01-17  9:03   ` Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 08/12] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 09/12] serial: Make uart_handle_cts_change() status param " Ilpo Järvinen
2023-01-17  9:03   ` Ilpo Järvinen
2023-01-17  9:03 ` Ilpo Järvinen [this message]
2023-01-17  9:03 ` [PATCH v4 11/12] tty: Call ->dtr_rts() parameter active consistently Ilpo Järvinen
2023-01-17  9:03   ` Ilpo Järvinen
2023-01-17  9:03 ` [PATCH v4 12/12] tty: moxa: Rename dtr/rts parameters/variables to active Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230117090358.4796-11-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=giometti@enneenne.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=siglesias@igalia.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.