From: Arnd Bergmann <arnd@kernel.org>
To: Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Daniel Latypov" <dlatypov@google.com>,
"Jeremy Kerr" <jk@codeconstruct.com.au>,
"Joe Fradley" <joefradley@google.com>,
"Maxime Ripard" <maxime@cerno.tech>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Maíra Canal" <mcanal@igalia.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: [PATCH] kunit: Export kunit_running()
Date: Tue, 17 Jan 2023 17:50:26 +0100 [thread overview]
Message-ID: <20230117165039.1871598-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Using kunit_fail_current_test() in a loadable module causes a link
error like:
ERROR: modpost: "kunit_running" [drivers/gpu/drm/vc4/vc4.ko] undefined!
Export the symbol to allow using it from modules.
Fixes: da43ff045c3f ("drm/vc4: tests: Fail the current test if we access a register")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/kunit/test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/kunit/test.c b/lib/kunit/test.c
index c9ebf975e56b..890ba5b3a981 100644
--- a/lib/kunit/test.c
+++ b/lib/kunit/test.c
@@ -21,6 +21,7 @@
#include "try-catch-impl.h"
DEFINE_STATIC_KEY_FALSE(kunit_running);
+EXPORT_SYMBOL_GPL(kunit_running);
#if IS_BUILTIN(CONFIG_KUNIT)
/*
--
2.39.0
next reply other threads:[~2023-01-17 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 16:50 Arnd Bergmann [this message]
2023-01-18 0:37 ` [PATCH] kunit: Export kunit_running() David Gow
2023-01-18 11:02 ` Maxime Ripard
2023-01-20 6:13 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117165039.1871598-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=javierm@redhat.com \
--cc=jk@codeconstruct.com.au \
--cc=joefradley@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mcanal@igalia.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.