All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	Hugh Dickins <hughd@google.com>
Cc: linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, cluster-devel@redhat.com,
	linux-mm@kvack.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org
Subject: [PATCH 8/9] btrfs: handle a NULL folio in extent_range_redirty_for_io
Date: Wed, 18 Jan 2023 10:43:28 +0100	[thread overview]
Message-ID: <20230118094329.9553-9-hch@lst.de> (raw)
In-Reply-To: <20230118094329.9553-1-hch@lst.de>

filemap_get_folio can return NULL, skip those cases.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/btrfs/extent_io.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index d55e4531ffd212..a54d2cf74ba020 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -230,6 +230,8 @@ void extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end)
 
 	while (index <= end_index) {
 		folio = filemap_get_folio(mapping, index);
+		if (!folio)
+			continue;
 		filemap_dirty_folio(mapping, folio);
 		folio_account_redirty(folio);
 		index += folio_nr_pages(folio);
-- 
2.39.0


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 8/9] btrfs: handle a NULL folio in extent_range_redirty_for_io
Date: Wed, 18 Jan 2023 10:43:28 +0100	[thread overview]
Message-ID: <20230118094329.9553-9-hch@lst.de> (raw)
In-Reply-To: <20230118094329.9553-1-hch@lst.de>

filemap_get_folio can return NULL, skip those cases.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/btrfs/extent_io.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index d55e4531ffd212..a54d2cf74ba020 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -230,6 +230,8 @@ void extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end)
 
 	while (index <= end_index) {
 		folio = filemap_get_folio(mapping, index);
+		if (!folio)
+			continue;
 		filemap_dirty_folio(mapping, folio);
 		folio_account_redirty(folio);
 		index += folio_nr_pages(folio);
-- 
2.39.0


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	Hugh Dickins <hughd@google.com>
Cc: linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org,
	cluster-devel@redhat.com, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org
Subject: [PATCH 8/9] btrfs: handle a NULL folio in extent_range_redirty_for_io
Date: Wed, 18 Jan 2023 10:43:28 +0100	[thread overview]
Message-ID: <20230118094329.9553-9-hch@lst.de> (raw)
In-Reply-To: <20230118094329.9553-1-hch@lst.de>

filemap_get_folio can return NULL, skip those cases.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/btrfs/extent_io.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index d55e4531ffd212..a54d2cf74ba020 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -230,6 +230,8 @@ void extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end)
 
 	while (index <= end_index) {
 		folio = filemap_get_folio(mapping, index);
+		if (!folio)
+			continue;
 		filemap_dirty_folio(mapping, folio);
 		folio_account_redirty(folio);
 		index += folio_nr_pages(folio);
-- 
2.39.0


  parent reply	other threads:[~2023-01-18 10:40 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  9:43 return an ERR_PTR from __filemap_get_folio Christoph Hellwig
2023-01-18  9:43 ` [Cluster-devel] " Christoph Hellwig
2023-01-18  9:43 ` [PATCH 1/9] mm: don't look at xarray value entries in split_huge_pages_in_file Christoph Hellwig
2023-01-18  9:43   ` Christoph Hellwig
2023-01-18  9:43   ` [Cluster-devel] " Christoph Hellwig
2023-01-18 13:47   ` Matthew Wilcox
2023-01-18 13:47     ` Matthew Wilcox
2023-01-18 13:47     ` [Cluster-devel] " Matthew Wilcox
2023-01-18  9:43 ` [PATCH 2/9] mm: make mapping_get_entry available outside of filemap.c Christoph Hellwig
2023-01-18  9:43   ` Christoph Hellwig
2023-01-18  9:43   ` [Cluster-devel] " Christoph Hellwig
2023-01-18 13:49   ` Matthew Wilcox
2023-01-18 13:49     ` Matthew Wilcox
2023-01-18 13:49     ` [Cluster-devel] " Matthew Wilcox
2023-01-18  9:43 ` [PATCH 3/9] mm: use filemap_get_entry in filemap_get_incore_folio Christoph Hellwig
2023-01-18  9:43   ` Christoph Hellwig
2023-01-18  9:43   ` [Cluster-devel] " Christoph Hellwig
2023-01-18 13:49   ` Matthew Wilcox
2023-01-18 13:49     ` Matthew Wilcox
2023-01-18 13:49     ` [Cluster-devel] " Matthew Wilcox
2023-01-18  9:43 ` [PATCH 4/9] shmem: remove shmem_get_partial_folio Christoph Hellwig
2023-01-18  9:43   ` Christoph Hellwig
2023-01-18  9:43   ` [Cluster-devel] " Christoph Hellwig
2023-01-18 13:57   ` Brian Foster
2023-01-18 13:57     ` Brian Foster
2023-01-18 13:57     ` [Cluster-devel] " Brian Foster
2023-01-18 16:43     ` Christoph Hellwig
2023-01-18 16:43       ` Christoph Hellwig
2023-01-18 16:43       ` [Cluster-devel] " Christoph Hellwig
2023-01-18 16:50       ` Brian Foster
2023-01-18 16:50         ` Brian Foster
2023-01-18 16:50         ` [Cluster-devel] " Brian Foster
2023-01-18  9:43 ` [PATCH 5/9] shmem: open code the page cache lookup in shmem_get_folio_gfp Christoph Hellwig
2023-01-18  9:43   ` Christoph Hellwig
2023-01-18  9:43   ` [Cluster-devel] " Christoph Hellwig
2023-01-18  9:43 ` [PATCH 6/9] mm: remove FGP_ENTRY Christoph Hellwig
2023-01-18  9:43   ` Christoph Hellwig
2023-01-18  9:43   ` [Cluster-devel] " Christoph Hellwig
2023-01-18  9:43 ` [PATCH 7/9] gfs2: handle a NULL folio in gfs2_jhead_process_page Christoph Hellwig
2023-01-18  9:43   ` Christoph Hellwig
2023-01-18  9:43   ` [Cluster-devel] " Christoph Hellwig
2023-01-18 16:00   ` Matthew Wilcox
2023-01-18 16:00     ` Matthew Wilcox
2023-01-18 16:00     ` [Cluster-devel] " Matthew Wilcox
2023-01-18 16:24     ` Andreas Gruenbacher
2023-01-18 16:24       ` Andreas Gruenbacher
2023-01-18 16:24       ` [Cluster-devel] " Andreas Gruenbacher
2023-01-18 16:42       ` Christoph Hellwig
2023-01-18 16:42         ` Christoph Hellwig
2023-01-18  9:43 ` Christoph Hellwig [this message]
2023-01-18  9:43   ` [PATCH 8/9] btrfs: handle a NULL folio in extent_range_redirty_for_io Christoph Hellwig
2023-01-18  9:43   ` [Cluster-devel] " Christoph Hellwig
2023-01-18 16:08   ` Matthew Wilcox
2023-01-18 16:08     ` Matthew Wilcox
2023-01-18 16:08     ` [Cluster-devel] " Matthew Wilcox
2023-01-18 16:42     ` Christoph Hellwig
2023-01-18 16:42       ` Christoph Hellwig
2023-01-18 16:42       ` [Cluster-devel] " Christoph Hellwig
2023-01-18  9:43 ` [PATCH 9/9] mm: return an ERR_PTR from __filemap_get_folio Christoph Hellwig
2023-01-18  9:43   ` Christoph Hellwig
2023-01-18  9:43   ` [Cluster-devel] " Christoph Hellwig
2023-01-18 12:39   ` Ryusuke Konishi
2023-01-18 12:39     ` Ryusuke Konishi
2023-01-18 12:39     ` [Cluster-devel] " Ryusuke Konishi
2023-01-18 16:42     ` Christoph Hellwig
2023-01-18 16:42       ` Christoph Hellwig
2023-01-18 16:42       ` [Cluster-devel] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230118094329.9553-9-hch@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=cluster-devel@redhat.com \
    --cc=hughd@google.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.