From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marijn Suijten <marijn.suijten@somainline.org>
Subject: [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name
Date: Wed, 18 Jan 2023 12:06:23 +0200 [thread overview]
Message-ID: <20230118100623.42255-1-andriy.shevchenko@linux.intel.com> (raw)
The node name can contain an address part which is unused
by the driver. Moreover, this string is propagated into
the userspace label, sysfs filenames *and breaking ABI*.
Cut the address part out before assigning the channel name.
Fixes: 4f47a236a23d ("iio: adc: qcom-spmi-adc5: convert to device properties")
Reported-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: rephrased commit message (Marijn), fixed compilation issue (Marijin)
drivers/iio/adc/qcom-spmi-adc5.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
index e90c299c913a..c2d5e06f137a 100644
--- a/drivers/iio/adc/qcom-spmi-adc5.c
+++ b/drivers/iio/adc/qcom-spmi-adc5.c
@@ -628,12 +628,20 @@ static int adc5_get_fw_channel_data(struct adc5_chip *adc,
struct fwnode_handle *fwnode,
const struct adc5_data *data)
{
- const char *name = fwnode_get_name(fwnode), *channel_name;
+ const char *channel_name;
+ char *name;
u32 chan, value, varr[2];
u32 sid = 0;
int ret;
struct device *dev = adc->dev;
+ name = devm_kasprintf(dev, GFP_KERNEL, "%pfwP", fwnode);
+ if (!name)
+ return -ENOMEM;
+
+ /* Cut the address part */
+ name[strchrnul(name, '@') - name] = '\0';
+
ret = fwnode_property_read_u32(fwnode, "reg", &chan);
if (ret) {
dev_err(dev, "invalid channel number %s\n", name);
--
2.39.0
next reply other threads:[~2023-01-18 11:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 10:06 Andy Shevchenko [this message]
2023-01-18 12:35 ` [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name Marijn Suijten
2023-01-18 13:22 ` Andy Shevchenko
2023-01-18 14:04 ` Marijn Suijten
2023-01-18 14:29 ` Andy Shevchenko
2023-01-18 15:21 ` Marijn Suijten
2023-01-18 15:57 ` Andy Shevchenko
2023-01-22 17:24 ` Jonathan Cameron
2023-01-23 12:02 ` Andy Shevchenko
2023-01-23 19:30 ` Jonathan Cameron
2023-01-23 16:35 ` Konrad Dybcio
2023-01-23 17:01 ` Marijn Suijten
2023-01-23 17:04 ` Konrad Dybcio
2023-01-23 23:12 ` Doug Anderson
2023-01-25 19:39 ` Matthias Kaehlcke
2023-01-28 15:34 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118100623.42255-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=jic23@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.