All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] media: renesas: vsp1: blacklist r8a7795 ES1.*
Date: Wed, 18 Jan 2023 13:20:02 +0100	[thread overview]
Message-ID: <20230118122003.132905-1-wsa+renesas@sang-engineering.com> (raw)

The earliest revision of these SoC may hang when underrunning. Later
revisions have that fixed. Bail out when we detect a problematic
version.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

The BSP tries to work around the issue, yet this is neither upstreamable
nor are we sure the solution is complete. Because the early SoC revision
is hardly in use, we simply "document" the problem upstream.

 drivers/media/platform/renesas/vsp1/vsp1_drv.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drv.c b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
index c260d318d298..b395e8eb0af9 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c
+++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
@@ -17,6 +17,7 @@
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 #include <linux/reset.h>
+#include <linux/sys_soc.h>
 #include <linux/videodev2.h>
 
 #include <media/rcar-fcp.h>
@@ -875,13 +876,24 @@ static const struct vsp1_device_info *vsp1_lookup_info(struct vsp1_device *vsp1)
 	return NULL;
 }
 
+static const struct soc_device_attribute vsp1_blacklist[]  = {
+	/* H3 ES1.* has underrun hang issues */
+	{ .soc_id = "r8a7795", .revision = "ES1.*" },
+	{ /* Sentinel */ }
+};
+
 static int vsp1_probe(struct platform_device *pdev)
 {
+	const struct soc_device_attribute *attr;
 	struct vsp1_device *vsp1;
 	struct device_node *fcp_node;
 	int ret;
 	int irq;
 
+	attr = soc_device_match(vsp1_blacklist);
+	if (attr)
+		return -ENOTSUPP;
+
 	vsp1 = devm_kzalloc(&pdev->dev, sizeof(*vsp1), GFP_KERNEL);
 	if (vsp1 == NULL)
 		return -ENOMEM;
-- 
2.30.2


             reply	other threads:[~2023-01-18 13:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 12:20 Wolfram Sang [this message]
2023-01-18 12:43 ` [PATCH] media: renesas: vsp1: blacklist r8a7795 ES1.* Laurent Pinchart
2023-01-18 13:09   ` Wolfram Sang
2023-01-18 13:30   ` Geert Uytterhoeven
2023-01-18 13:39     ` Laurent Pinchart
2023-01-18 14:02       ` Geert Uytterhoeven
2023-01-18 14:06         ` Laurent Pinchart
2023-02-28 10:15           ` Pavel Machek
2023-02-28 10:23             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230118122003.132905-1-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.