All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: Jason Wang <jasowang@redhat.com>,
	Dmitry Fleytman <dmitry.fleytman@gmail.com>,
	Thomas Huth <thuth@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Yan Vugenfirer <yvugenfi@redhat.com>,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	Sriram Yagnaraman <sriram.yagnaraman@est.tech>,
	Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v2 10/26] e1000e: Use memcpy to intialize registers
Date: Tue, 24 Jan 2023 13:31:27 +0900	[thread overview]
Message-ID: <20230124043143.5515-11-akihiko.odaki@daynix.com> (raw)
In-Reply-To: <20230124043143.5515-1-akihiko.odaki@daynix.com>

Use memcpy instead of memmove to initialize registers. The initial
register templates and register table instances will never overlap.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 hw/net/e1000e_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 6a4da72bd3..87f964cdc1 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -3511,9 +3511,9 @@ e1000e_core_reset(E1000ECore *core)
     e1000e_intrmgr_reset(core);
 
     memset(core->phy, 0, sizeof core->phy);
-    memmove(core->phy, e1000e_phy_reg_init, sizeof e1000e_phy_reg_init);
+    memcpy(core->phy, e1000e_phy_reg_init, sizeof e1000e_phy_reg_init);
     memset(core->mac, 0, sizeof core->mac);
-    memmove(core->mac, e1000e_mac_reg_init, sizeof e1000e_mac_reg_init);
+    memcpy(core->mac, e1000e_mac_reg_init, sizeof e1000e_mac_reg_init);
 
     core->rxbuf_min_shift = 1 + E1000_RING_DESC_LEN_SHIFT;
 
-- 
2.39.0



  parent reply	other threads:[~2023-01-24  4:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24  4:31 [PATCH v2 00/26] e1000x cleanups (preliminary for IGB) Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 01/26] e1000e: Fix the code style Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 02/26] hw/net: Add more MII definitions Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 03/26] fsl_etsec: Use hw/net/mii.h Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 04/26] e1000: " Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 05/26] e1000: Mask registers when writing Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 06/26] e1000e: " Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 07/26] e1000: Use more constant definitions Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 08/26] e1000e: " Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 09/26] e1000: Use memcpy to intialize registers Akihiko Odaki
2023-01-24  4:31 ` Akihiko Odaki [this message]
2023-01-24  4:31 ` [PATCH v2 11/26] e1000e: Remove pending interrupt flags Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 12/26] e1000e: Improve software reset Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 13/26] e1000: Configure ResettableClass Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 14/26] e1000e: " Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 15/26] e1000e: Introduce e1000_rx_desc_union Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 16/26] e1000e: Set MII_ANER_NWAY Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 17/26] e1000e: Remove extra pointer indirection Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 18/26] net: Check L4 header size Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 19/26] e1000x: Alter the signature of e1000x_is_vlan_packet Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 20/26] net: Strip virtio-net header when dumping Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 21/26] hw/net/net_tx_pkt: Automatically determine if virtio-net header is used Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 22/26] hw/net/net_rx_pkt: Remove net_rx_pkt_has_virt_hdr Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 23/26] e1000e: Perform software segmentation for loopback Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 24/26] hw/net/net_tx_pkt: Implement TCP segmentation Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 25/26] MAINTAINERS: Add Akihiko Odaki as a e1000e reviewer Akihiko Odaki
2023-01-24  4:31 ` [PATCH v2 26/26] MAINTAINERS: Add e1000e test files Akihiko Odaki
2023-01-24  7:10   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230124043143.5515-11-akihiko.odaki@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=dmitry.fleytman@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=sriram.yagnaraman@est.tech \
    --cc=thuth@redhat.com \
    --cc=yuri.benditovich@daynix.com \
    --cc=yvugenfi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.