All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, kraxel@redhat.com, kwolf@redhat.com,
	hreitz@redhat.com, marcandre.lureau@redhat.com,
	dgilbert@redhat.com, mst@redhat.com, imammedo@redhat.com,
	ani@anisinha.ca, eduardo@habkost.net, marcel.apfelbaum@gmail.com,
	philmd@linaro.org, wangyanan55@huawei.com, jasowang@redhat.com,
	jiri@resnulli.us, berrange@redhat.com, thuth@redhat.com,
	quintela@redhat.com, stefanb@linux.vnet.ibm.com,
	stefanha@redhat.com, kvm@vger.kernel.org, qemu-block@nongnu.org
Subject: [PATCH 00/32] Move and clean up monitor command code
Date: Tue, 24 Jan 2023 13:19:14 +0100	[thread overview]
Message-ID: <20230124121946.1139465-1-armbru@redhat.com> (raw)

Over the years, many commands got dumped into monitor/, where
MAINTAINERS blames them on Dave and me.  Recent "[PATCH v2 00/13] pci:
Move and clean up monitor command code" (merge commit 33698d3abf8)
evicted commands related to PCI (qapi/pci.json), and "[PATCH v4 00/17]
ui: Move and clean up monitor command code" (merge commit 70d17c3eede)
evicted commands rated to UI (qapi/ui.json) This series evicts most of
the rest.  Commands related to the monitor itself (qapi/control.json
qapi/introspect.json) and miscellaneous commands (qapi/misc.json) stay
in monitor/.

Together, these patches move almost 4000 lines from monitor/ to
subsystems where they belong.

Based-on: <20230119091545.3116376-1-armbru@redhat.com>

Markus Armbruster (32):
  monitor: Drop unnecessary includes
  audio: Move HMP commands from monitor/ to audio/
  char: Move HMP commands from monitor/ to chardev/
  char: Factor out qmp_add_client() parts and move to chardev/
  hmp: Drop redundant argument check from add_completion_option()
  readline: Extract readline_add_completion_of() from monitor
  hmp: Rename help_cmd() to hmp_help_cmd(), move declaration to hmp.h
  trace: Move HMP commands from monitor/ to trace/
  machine: Move QMP commands from monitor/ to hw/core/
  machine: Move HMP commands from monitor/ to hw/core/
  qom: Move HMP commands from monitor/ to qom/
  block: Factor out hmp_change_medium(), and move to block/monitor/
  rocker: Move HMP commands from monitor to hw/net/rocker/
  hmp: Rewrite strlist_from_comma_list() as hmp_split_at_comma()
  net: Move HMP commands from monitor to net/
  net: Move hmp_info_network() to net-hmp-cmds.c
  migration: Move HMP commands from monitor/ to migration/
  migration: Move the QMP command from monitor/ to migration/
  virtio: Move HMP commands from monitor/ to hw/virtio/
  tpm: Move HMP commands from monitor/ to softmmu/
  runstate: Move HMP commands from monitor/ to softmmu/
  stats: Move QMP commands from monitor/ to stats/
  stats: Move HMP commands from monitor/ to stats/
  acpi: Move the QMP command from monitor/ to hw/acpi/
  qdev: Move HMP command completion from monitor to softmmu/
  monitor: Split file descriptor passing stuff off misc.c
  monitor: Move monitor_putc() next to monitor_puts & external linkage
  monitor: Move target-dependent HMP commands to hmp-cmds-target.c
  monitor: Move remaining HMP commands from misc.c to hmp-cmds.c
  monitor: Move remaining QMP stuff from misc.c to qmp-cmds.c
  monitor: Loosen coupling between misc.c and monitor.c slightly
  monitor: Rename misc.c to hmp-target.c

 MAINTAINERS                          |   10 +-
 meson.build                          |    1 +
 include/monitor/hmp-target.h         |    6 +
 include/monitor/hmp.h                |   27 +
 include/monitor/monitor.h            |    1 +
 include/monitor/qmp-helpers.h        |    3 +
 include/net/net.h                    |    4 +-
 include/qemu/readline.h              |    2 +
 include/{monitor => sysemu}/stats.h  |    0
 monitor/monitor-internal.h           |    1 -
 accel/kvm/kvm-all.c                  |    2 +-
 audio/audio-hmp-cmds.c               |   83 +
 block/monitor/block-hmp-cmds.c       |   21 +
 chardev/char-hmp-cmds.c              |  220 +++
 chardev/char.c                       |   20 +
 hw/acpi/acpi-qmp-cmds.c              |   30 +
 hw/core/machine-hmp-cmds.c           |  208 +++
 hw/core/machine-qmp-cmds.c           |  144 ++
 hw/net/rocker/rocker-hmp-cmds.c      |  316 ++++
 hw/virtio/virtio-hmp-cmds.c          |  321 ++++
 migration/migration-hmp-cmds.c       |  807 ++++++++++
 migration/migration.c                |   30 +
 monitor/fds.c                        |  468 ++++++
 monitor/hmp-cmds-target.c            |  380 +++++
 monitor/hmp-cmds.c                   | 2181 ++------------------------
 monitor/hmp-target.c                 |  178 +++
 monitor/hmp.c                        |   17 +-
 monitor/misc.c                       | 1906 ----------------------
 monitor/monitor.c                    |   30 +-
 monitor/qmp-cmds-control.c           |    1 -
 monitor/qmp-cmds.c                   |  355 +----
 net/net-hmp-cmds.c                   |  170 ++
 net/net.c                            |   28 +-
 qom/qom-hmp-cmds.c                   |   67 +
 softmmu/qdev-monitor.c               |   82 +
 softmmu/runstate-hmp-cmds.c          |   82 +
 softmmu/tpm-hmp-cmds.c               |   65 +
 stats/stats-hmp-cmds.c               |  247 +++
 stats/stats-qmp-cmds.c               |  162 ++
 storage-daemon/qemu-storage-daemon.c |    4 +-
 trace/trace-hmp-cmds.c               |  148 ++
 util/readline.c                      |    8 +
 audio/meson.build                    |    1 +
 chardev/meson.build                  |    6 +-
 hmp-commands.hx                      |    4 +-
 hw/acpi/meson.build                  |    1 +
 hw/net/meson.build                   |    1 +
 hw/virtio/meson.build                |    1 +
 migration/meson.build                |    1 +
 monitor/meson.build                  |    4 +-
 net/meson.build                      |    1 +
 softmmu/meson.build                  |    2 +
 stats/meson.build                    |    1 +
 trace/meson.build                    |    1 +
 54 files changed, 4574 insertions(+), 4286 deletions(-)
 rename include/{monitor => sysemu}/stats.h (100%)
 create mode 100644 audio/audio-hmp-cmds.c
 create mode 100644 chardev/char-hmp-cmds.c
 create mode 100644 hw/acpi/acpi-qmp-cmds.c
 create mode 100644 hw/net/rocker/rocker-hmp-cmds.c
 create mode 100644 hw/virtio/virtio-hmp-cmds.c
 create mode 100644 migration/migration-hmp-cmds.c
 create mode 100644 monitor/fds.c
 create mode 100644 monitor/hmp-cmds-target.c
 create mode 100644 monitor/hmp-target.c
 delete mode 100644 monitor/misc.c
 create mode 100644 net/net-hmp-cmds.c
 create mode 100644 softmmu/runstate-hmp-cmds.c
 create mode 100644 softmmu/tpm-hmp-cmds.c
 create mode 100644 stats/stats-hmp-cmds.c
 create mode 100644 stats/stats-qmp-cmds.c
 create mode 100644 trace/trace-hmp-cmds.c
 create mode 100644 stats/meson.build

-- 
2.39.0


             reply	other threads:[~2023-01-24 12:20 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 12:19 Markus Armbruster [this message]
2023-01-24 12:19 ` [PATCH 01/32] monitor: Drop unnecessary includes Markus Armbruster
2023-01-24 22:43   ` Stefan Berger
2023-01-24 12:19 ` [PATCH 02/32] audio: Move HMP commands from monitor/ to audio/ Markus Armbruster
2023-01-24 12:19 ` [PATCH 03/32] char: Move HMP commands from monitor/ to chardev/ Markus Armbruster
2023-01-24 12:19 ` [PATCH 04/32] char: Factor out qmp_add_client() parts and move " Markus Armbruster
2023-01-24 12:19 ` [PATCH 05/32] hmp: Drop redundant argument check from add_completion_option() Markus Armbruster
2023-01-24 12:19 ` [PATCH 06/32] readline: Extract readline_add_completion_of() from monitor Markus Armbruster
2023-01-24 12:19 ` [PATCH 07/32] hmp: Rename help_cmd() to hmp_help_cmd(), move declaration to hmp.h Markus Armbruster
2023-01-24 12:19 ` [PATCH 08/32] trace: Move HMP commands from monitor/ to trace/ Markus Armbruster
2023-01-24 12:22   ` Philippe Mathieu-Daudé
2023-01-24 14:21   ` Stefan Hajnoczi
2023-01-24 12:19 ` [PATCH 09/32] machine: Move QMP commands from monitor/ to hw/core/ Markus Armbruster
2023-01-24 12:19 ` [PATCH 10/32] machine: Move HMP " Markus Armbruster
2023-01-24 12:19 ` [PATCH 11/32] qom: Move HMP commands from monitor/ to qom/ Markus Armbruster
2023-01-24 12:23   ` Philippe Mathieu-Daudé
2023-01-24 12:19 ` [PATCH 12/32] block: Factor out hmp_change_medium(), and move to block/monitor/ Markus Armbruster
2023-01-24 14:20   ` Stefan Hajnoczi
2023-01-26 13:29   ` Stefan Berger
2023-01-24 12:19 ` [PATCH 13/32] rocker: Move HMP commands from monitor to hw/net/rocker/ Markus Armbruster
2023-01-24 12:19 ` [PATCH 14/32] hmp: Rewrite strlist_from_comma_list() as hmp_split_at_comma() Markus Armbruster
2023-01-24 12:19 ` [PATCH 15/32] net: Move HMP commands from monitor to net/ Markus Armbruster
2023-01-24 12:19 ` [PATCH 16/32] net: Move hmp_info_network() to net-hmp-cmds.c Markus Armbruster
2023-01-24 12:19 ` [PATCH 17/32] migration: Move HMP commands from monitor/ to migration/ Markus Armbruster
2023-02-01 20:46   ` Juan Quintela
2023-01-24 12:19 ` [PATCH 18/32] migration: Move the QMP command " Markus Armbruster
2023-02-01 20:46   ` Juan Quintela
2023-01-24 12:19 ` [PATCH 19/32] virtio: Move HMP commands from monitor/ to hw/virtio/ Markus Armbruster
2023-01-24 12:24   ` Philippe Mathieu-Daudé
2023-01-24 12:19 ` [PATCH 20/32] tpm: Move HMP commands from monitor/ to softmmu/ Markus Armbruster
2023-01-24 22:39   ` Stefan Berger
2023-01-24 12:19 ` [PATCH 21/32] runstate: " Markus Armbruster
2023-01-24 12:19 ` [PATCH 22/32] stats: Move QMP commands from monitor/ to stats/ Markus Armbruster
2023-01-24 12:19 ` [PATCH 23/32] stats: Move HMP " Markus Armbruster
2023-01-24 12:19 ` [PATCH 24/32] acpi: Move the QMP command from monitor/ to hw/acpi/ Markus Armbruster
2023-01-24 12:25   ` Philippe Mathieu-Daudé
2023-01-24 12:19 ` [PATCH 25/32] qdev: Move HMP command completion from monitor to softmmu/ Markus Armbruster
2023-01-24 12:19 ` [PATCH 26/32] monitor: Split file descriptor passing stuff off misc.c Markus Armbruster
2023-01-24 12:19 ` [PATCH 27/32] monitor: Move monitor_putc() next to monitor_puts & external linkage Markus Armbruster
2023-01-24 12:19 ` [PATCH 28/32] monitor: Move target-dependent HMP commands to hmp-cmds-target.c Markus Armbruster
2023-01-24 12:19 ` [PATCH 29/32] monitor: Move remaining HMP commands from misc.c to hmp-cmds.c Markus Armbruster
2023-01-24 12:19 ` [PATCH 30/32] monitor: Move remaining QMP stuff from misc.c to qmp-cmds.c Markus Armbruster
2023-01-24 12:19 ` [PATCH 31/32] monitor: Loosen coupling between misc.c and monitor.c slightly Markus Armbruster
2023-01-24 12:19 ` [PATCH 32/32] monitor: Rename misc.c to hmp-target.c Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230124121946.1139465-1-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=hreitz@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.