All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/5] drm/ttm: stop allocating dummy resources during BO creation
Date: Tue, 24 Jan 2023 13:57:23 +0100	[thread overview]
Message-ID: <20230124125726.13323-2-christian.koenig@amd.com> (raw)
In-Reply-To: <20230124125726.13323-1-christian.koenig@amd.com>

That should not be necessary any more when drivers should at least be
able to handle the move without a resource.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/ttm/ttm_bo.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 326a3d13a829..bb0c21c8caac 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -953,7 +953,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
 			 struct sg_table *sg, struct dma_resv *resv,
 			 void (*destroy) (struct ttm_buffer_object *))
 {
-	static const struct ttm_place sys_mem = { .mem_type = TTM_PL_SYSTEM };
 	int ret;
 
 	kref_init(&bo->kref);
@@ -970,12 +969,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
 		bo->base.resv = &bo->base._resv;
 	atomic_inc(&ttm_glob.bo_count);
 
-	ret = ttm_resource_alloc(bo, &sys_mem, &bo->resource);
-	if (unlikely(ret)) {
-		ttm_bo_put(bo);
-		return ret;
-	}
-
 	/*
 	 * For ttm_bo_type_device buffers, allocate
 	 * address space from the device.
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/5] drm/ttm: stop allocating dummy resources during BO creation
Date: Tue, 24 Jan 2023 13:57:23 +0100	[thread overview]
Message-ID: <20230124125726.13323-2-christian.koenig@amd.com> (raw)
In-Reply-To: <20230124125726.13323-1-christian.koenig@amd.com>

That should not be necessary any more when drivers should at least be
able to handle the move without a resource.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/ttm/ttm_bo.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 326a3d13a829..bb0c21c8caac 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -953,7 +953,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
 			 struct sg_table *sg, struct dma_resv *resv,
 			 void (*destroy) (struct ttm_buffer_object *))
 {
-	static const struct ttm_place sys_mem = { .mem_type = TTM_PL_SYSTEM };
 	int ret;
 
 	kref_init(&bo->kref);
@@ -970,12 +969,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
 		bo->base.resv = &bo->base._resv;
 	atomic_inc(&ttm_glob.bo_count);
 
-	ret = ttm_resource_alloc(bo, &sys_mem, &bo->resource);
-	if (unlikely(ret)) {
-		ttm_bo_put(bo);
-		return ret;
-	}
-
 	/*
 	 * For ttm_bo_type_device buffers, allocate
 	 * address space from the device.
-- 
2.34.1


  reply	other threads:[~2023-01-24 12:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 12:57 [PATCH 1/5] drm/i915: audit bo->resource usage v3 Christian König
2023-01-24 12:57 ` [Intel-gfx] " Christian König
2023-01-24 12:57 ` Christian König [this message]
2023-01-24 12:57   ` [Intel-gfx] [PATCH 2/5] drm/ttm: stop allocating dummy resources during BO creation Christian König
2023-01-24 13:49   ` Matthew Auld
2023-01-24 13:49     ` [Intel-gfx] " Matthew Auld
2023-01-24 12:57 ` [PATCH 3/5] drm/ttm: stop allocating a dummy resource for pipelined gutting Christian König
2023-01-24 12:57   ` [Intel-gfx] " Christian König
2023-01-24 13:50   ` Matthew Auld
2023-01-24 13:50     ` [Intel-gfx] " Matthew Auld
2023-01-24 12:57 ` [PATCH 4/5] drm/ttm: prevent moving of pinned BOs Christian König
2023-01-24 12:57   ` [Intel-gfx] " Christian König
2023-01-24 14:01   ` Matthew Auld
2023-01-24 14:01     ` [Intel-gfx] " Matthew Auld
2023-01-24 12:57 ` [PATCH 5/5] drm/ttm: replace busy placement with flags v2 Christian König
2023-01-24 12:57   ` [Intel-gfx] " Christian König
2023-01-24 17:11   ` Matthew Auld
2023-01-25 11:31   ` kernel test robot
2023-01-24 13:48 ` [Intel-gfx] [PATCH 1/5] drm/i915: audit bo->resource usage v3 Matthew Auld
2023-01-24 17:15   ` Matthew Auld
2023-01-25  9:56     ` Matthew Auld
2023-01-25 10:07       ` Christian König
2023-01-25 10:21         ` Matthew Auld
2023-01-25 11:35           ` Christian König
2023-01-25 12:53             ` Matthew Auld
2023-01-25 14:20               ` Christian König
2023-01-25 15:46                 ` Matthew Auld
2023-01-24 19:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] " Patchwork
2023-01-24 19:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-24 22:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230124125726.13323-2-christian.koenig@amd.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.