All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: <hdegoede@redhat.com>, <markgross@kernel.org>
Cc: <platform-driver-x86@vger.kernel.org>, <Patil.Reddy@amd.com>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>
Subject: [PATCH 4/5] platform/x86/amd/pmf: Fix to update SPS default pprof thermals
Date: Wed, 25 Jan 2023 15:29:35 +0530	[thread overview]
Message-ID: <20230125095936.3292883-5-Shyam-sundar.S-k@amd.com> (raw)
In-Reply-To: <20230125095936.3292883-1-Shyam-sundar.S-k@amd.com>

By design PMF static slider will be set to BALANCED during
init, but updating to corresponding thermal values from
the PMF config store was missed, leading to improper settings
getting propagated to PMFW.

Fixes: 4c71ae414474 ("platform/x86/amd/pmf: Add support SPS PMF feature")
Suggested-by: Patil Rajesh Reddy <Patil.Reddy@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
---
 drivers/platform/x86/amd/pmf/sps.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/x86/amd/pmf/sps.c b/drivers/platform/x86/amd/pmf/sps.c
index 3b4a09a84c29..bed762d47a14 100644
--- a/drivers/platform/x86/amd/pmf/sps.c
+++ b/drivers/platform/x86/amd/pmf/sps.c
@@ -136,6 +136,9 @@ int amd_pmf_init_sps(struct amd_pmf_dev *dev)
 	dev->current_profile = PLATFORM_PROFILE_BALANCED;
 	amd_pmf_load_defaults_sps(dev);
 
+	/* update SPS balanced power mode thermals */
+	amd_pmf_set_sps_power_limits(dev);
+
 	dev->pprof.profile_get = amd_pmf_profile_get;
 	dev->pprof.profile_set = amd_pmf_profile_set;
 
-- 
2.25.1


  parent reply	other threads:[~2023-01-25 10:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25  9:59 [PATCH 0/5] platform/x86/amd/pmf: Updates to PMF driver Shyam Sundar S K
2023-01-25  9:59 ` [PATCH 1/5] platform/x86/amd/pmf: Add helper routine to update SPS thermals Shyam Sundar S K
2023-01-25  9:59 ` [PATCH 2/5] platform/x86/amd/pmf: Add helper routine to check pprof is balanced Shyam Sundar S K
2023-01-25  9:59 ` [PATCH 3/5] platform/x86/amd/pmf: update to auto-mode limits only after AMT event Shyam Sundar S K
2023-01-25  9:59 ` Shyam Sundar S K [this message]
2023-01-25  9:59 ` [PATCH 5/5] platform/x86/amd/pmf: Fix to update SPS thermals when power supply change Shyam Sundar S K
2023-01-26  3:39 ` [PATCH 0/5] platform/x86/amd/pmf: Updates to PMF driver Mario Limonciello
2023-01-30 13:32 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230125095936.3292883-5-Shyam-sundar.S-k@amd.com \
    --to=shyam-sundar.s-k@amd.com \
    --cc=Patil.Reddy@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.