All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
To: <hdegoede@redhat.com>, <markgross@kernel.org>
Cc: <Sanket.Goswami@amd.com>, <platform-driver-x86@vger.kernel.org>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>
Subject: [PATCH 3/4] platform/x86/amd: pmc: differentiate STB/SMU messaging prints
Date: Wed, 25 Jan 2023 17:01:26 +0530	[thread overview]
Message-ID: <20230125113127.3862898-4-Shyam-sundar.S-k@amd.com> (raw)
In-Reply-To: <20230125113127.3862898-1-Shyam-sundar.S-k@amd.com>

Modify the dynamic debug print to differentiate between the regular
and spill to DRAM usage of the SMU message port.

Suggested-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
---
 drivers/platform/x86/amd/pmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c
index 0dd9fb576f09..467b80ad01a1 100644
--- a/drivers/platform/x86/amd/pmc.c
+++ b/drivers/platform/x86/amd/pmc.c
@@ -592,13 +592,13 @@ static void amd_pmc_dump_registers(struct amd_pmc_dev *dev)
 	}
 
 	value = amd_pmc_reg_read(dev, response);
-	dev_dbg(dev->dev, "AMD_PMC_REGISTER_RESPONSE:%x\n", value);
+	dev_dbg(dev->dev, "AMD_%s_REGISTER_RESPONSE:%x\n", dev->msg_port ? "S2D" : "PMC", value);
 
 	value = amd_pmc_reg_read(dev, argument);
-	dev_dbg(dev->dev, "AMD_PMC_REGISTER_ARGUMENT:%x\n", value);
+	dev_dbg(dev->dev, "AMD_%s_REGISTER_ARGUMENT:%x\n", dev->msg_port ? "S2D" : "PMC", value);
 
 	value = amd_pmc_reg_read(dev, message);
-	dev_dbg(dev->dev, "AMD_PMC_REGISTER_MESSAGE:%x\n", value);
+	dev_dbg(dev->dev, "AMD_%s_REGISTER_MESSAGE:%x\n", dev->msg_port ? "S2D" : "PMC", value);
 }
 
 static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, u32 arg, u32 *data, u8 msg, bool ret)
-- 
2.25.1


  parent reply	other threads:[~2023-01-25 11:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 11:31 [PATCH 0/4] Updates to amd_pmc driver Shyam Sundar S K
2023-01-25 11:31 ` [PATCH 1/4] platform/x86/amd: pmc: Add num_samples message id support to STB Shyam Sundar S K
2023-01-30 14:42   ` Hans de Goede
2023-01-30 16:24     ` Shyam Sundar S K
2023-01-25 11:31 ` [PATCH 2/4] platform/x86/amd: pmc: Write dummy postcode into the STB DRAM Shyam Sundar S K
2023-01-25 17:43   ` Limonciello, Mario
2023-01-26  3:29     ` Shyam Sundar S K
2023-01-26  3:37       ` Mario Limonciello
2023-01-30 14:42   ` Hans de Goede
2023-01-25 11:31 ` Shyam Sundar S K [this message]
2023-01-30 14:43   ` [PATCH 3/4] platform/x86/amd: pmc: differentiate STB/SMU messaging prints Hans de Goede
2023-01-25 11:31 ` [PATCH 4/4] platform/x86/amd: pmc: Add line break for readability Shyam Sundar S K
2023-01-30 14:43   ` Hans de Goede
2023-01-26  3:38 ` [PATCH 0/4] Updates to amd_pmc driver Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230125113127.3862898-4-Shyam-sundar.S-k@amd.com \
    --to=shyam-sundar.s-k@amd.com \
    --cc=Sanket.Goswami@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.