All of lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: Intel-GFX@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>,
	DRI-Devel@Lists.FreeDesktop.Org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [PATCH v6 5/8] drm/i915: Allow error capture of a pending request
Date: Thu, 26 Jan 2023 16:28:39 -0800	[thread overview]
Message-ID: <20230127002842.3169194-6-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20230127002842.3169194-1-John.C.Harrison@Intel.com>

From: John Harrison <John.C.Harrison@Intel.com>

A hang situation has been observed where the only requests on the
context were either completed or not yet started according to the
breaadcrumbs. However, the register state claimed a batch was (maybe)
in progress. So, allow capture of the pending request on the grounds
that this might be better than nothing.

v2: Reword 'not started' warning message (Tvrtko)

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 225f1b11a6b93..904f21e1380cd 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1624,12 +1624,9 @@ capture_engine(struct intel_engine_cs *engine,
 		return NULL;
 
 	intel_engine_get_hung_entity(engine, &ce, &rq);
-	if (rq && !i915_request_started(rq)) {
+	if (rq && !i915_request_started(rq))
 		drm_info(&engine->gt->i915->drm, "Got hung context on %s with active request %lld:%lld [0x%04X] not yet started\n",
 			 engine->name, rq->fence.context, rq->fence.seqno, ce->guc_id.id);
-		i915_request_put(rq);
-		rq = NULL;
-	}
 
 	if (rq) {
 		capture = intel_engine_coredump_add_request(ee, rq, ATOMIC_MAYFAIL);
-- 
2.39.1


WARNING: multiple messages have this Message-ID (diff)
From: John.C.Harrison@Intel.com
To: Intel-GFX@Lists.FreeDesktop.Org
Cc: DRI-Devel@Lists.FreeDesktop.Org
Subject: [Intel-gfx] [PATCH v6 5/8] drm/i915: Allow error capture of a pending request
Date: Thu, 26 Jan 2023 16:28:39 -0800	[thread overview]
Message-ID: <20230127002842.3169194-6-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20230127002842.3169194-1-John.C.Harrison@Intel.com>

From: John Harrison <John.C.Harrison@Intel.com>

A hang situation has been observed where the only requests on the
context were either completed or not yet started according to the
breaadcrumbs. However, the register state claimed a batch was (maybe)
in progress. So, allow capture of the pending request on the grounds
that this might be better than nothing.

v2: Reword 'not started' warning message (Tvrtko)

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 225f1b11a6b93..904f21e1380cd 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1624,12 +1624,9 @@ capture_engine(struct intel_engine_cs *engine,
 		return NULL;
 
 	intel_engine_get_hung_entity(engine, &ce, &rq);
-	if (rq && !i915_request_started(rq)) {
+	if (rq && !i915_request_started(rq))
 		drm_info(&engine->gt->i915->drm, "Got hung context on %s with active request %lld:%lld [0x%04X] not yet started\n",
 			 engine->name, rq->fence.context, rq->fence.seqno, ce->guc_id.id);
-		i915_request_put(rq);
-		rq = NULL;
-	}
 
 	if (rq) {
 		capture = intel_engine_coredump_add_request(ee, rq, ATOMIC_MAYFAIL);
-- 
2.39.1


  parent reply	other threads:[~2023-01-27  0:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27  0:28 [PATCH v6 0/8] Allow error capture without a request & fix locking issues John.C.Harrison
2023-01-27  0:28 ` [Intel-gfx] " John.C.Harrison
2023-01-27  0:28 ` [PATCH v6 1/8] drm/i915/guc: Fix locking when searching for a hung request John.C.Harrison
2023-01-27  0:28   ` [Intel-gfx] " John.C.Harrison
2023-01-27  0:28 ` [PATCH v6 2/8] drm/i915: Fix request ref counting during error capture & debugfs dump John.C.Harrison
2023-01-27  0:28   ` [Intel-gfx] " John.C.Harrison
2023-01-27  0:28 ` [PATCH v6 3/8] drm/i915: Fix up locking around dumping requests lists John.C.Harrison
2023-01-27  0:28   ` [Intel-gfx] " John.C.Harrison
2023-01-27  0:28 ` [PATCH v6 4/8] drm/i915: Allow error capture without a request John.C.Harrison
2023-01-27  0:28   ` [Intel-gfx] " John.C.Harrison
2023-01-27  0:28 ` John.C.Harrison [this message]
2023-01-27  0:28   ` [Intel-gfx] [PATCH v6 5/8] drm/i915: Allow error capture of a pending request John.C.Harrison
2023-01-27  0:28 ` [PATCH v6 6/8] drm/i915/guc: Look for a guilty context when an engine reset fails John.C.Harrison
2023-01-27  0:28   ` [Intel-gfx] " John.C.Harrison
2023-01-27  0:28 ` [PATCH v6 7/8] drm/i915/guc: Add a debug print on GuC triggered reset John.C.Harrison
2023-01-27  0:28   ` [Intel-gfx] " John.C.Harrison
2023-01-27  0:28 ` [PATCH v6 8/8] drm/i915/guc: Rename GuC register state capture node to be more obvious John.C.Harrison
2023-01-27  0:28   ` [Intel-gfx] " John.C.Harrison
2023-01-27  0:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Allow error capture without a request & fix locking issues (rev4) Patchwork
2023-01-27  0:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-27  1:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230127002842.3169194-6-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=DRI-Devel@Lists.FreeDesktop.Org \
    --cc=Intel-GFX@Lists.FreeDesktop.Org \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.