From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Jianhua Lu <lujianhua000@gmail.com>, Lee Jones <lee@kernel.org>, Daniel Thompson <daniel.thompson@linaro.org>, Jingoo Han <jingoohan1@gmail.com> Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new() Date: Fri, 27 Jan 2023 16:26:39 +0100 [thread overview] Message-ID: <20230127152639.1347229-1-u.kleine-koenig@pengutronix.de> (raw) The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, there is an ongoing effort to convert all drivers to .probe_new to eventually drop .probe with the i2c_device_id parameter. This driver currently sits in next so wasn't on my radar before. My plan is to tackle that after the next merge window. So I ask you to either apply this patch during the next merge window or accept that it will go in via the i2c tree together with the patch that drops .probe(). Best regards Uwe drivers/video/backlight/ktz8866.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/video/backlight/ktz8866.c b/drivers/video/backlight/ktz8866.c index 97b723719e13..d38c13ad39c7 100644 --- a/drivers/video/backlight/ktz8866.c +++ b/drivers/video/backlight/ktz8866.c @@ -124,8 +124,7 @@ static void ktz8866_init(struct ktz8866 *ktz) ktz8866_write(ktz, LCD_BIAS_CFG1, LCD_BIAS_EN); } -static int ktz8866_probe(struct i2c_client *client, - const struct i2c_device_id *id) +static int ktz8866_probe(struct i2c_client *client) { struct backlight_device *backlight_dev; struct backlight_properties props; @@ -197,7 +196,7 @@ static struct i2c_driver ktz8866_driver = { .name = "ktz8866", .of_match_table = ktz8866_match_table, }, - .probe = ktz8866_probe, + .probe_new = ktz8866_probe, .remove = ktz8866_remove, .id_table = ktz8866_ids, }; base-commit: 2241ab53cbb5cdb08a6b2d4688feb13971058f65 prerequisite-patch-id: 2e7d7db8c0a90b8cd1deb6bbc51ead4c89c89b62 -- 2.39.0
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Jianhua Lu <lujianhua000@gmail.com>, Lee Jones <lee@kernel.org>, Daniel Thompson <daniel.thompson@linaro.org>, Jingoo Han <jingoohan1@gmail.com> Cc: linux-fbdev@vger.kernel.org, kernel@pengutronix.de, dri-devel@lists.freedesktop.org Subject: [PATCH] backlight: ktz8866: Convert to i2c's .probe_new() Date: Fri, 27 Jan 2023 16:26:39 +0100 [thread overview] Message-ID: <20230127152639.1347229-1-u.kleine-koenig@pengutronix.de> (raw) The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, there is an ongoing effort to convert all drivers to .probe_new to eventually drop .probe with the i2c_device_id parameter. This driver currently sits in next so wasn't on my radar before. My plan is to tackle that after the next merge window. So I ask you to either apply this patch during the next merge window or accept that it will go in via the i2c tree together with the patch that drops .probe(). Best regards Uwe drivers/video/backlight/ktz8866.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/video/backlight/ktz8866.c b/drivers/video/backlight/ktz8866.c index 97b723719e13..d38c13ad39c7 100644 --- a/drivers/video/backlight/ktz8866.c +++ b/drivers/video/backlight/ktz8866.c @@ -124,8 +124,7 @@ static void ktz8866_init(struct ktz8866 *ktz) ktz8866_write(ktz, LCD_BIAS_CFG1, LCD_BIAS_EN); } -static int ktz8866_probe(struct i2c_client *client, - const struct i2c_device_id *id) +static int ktz8866_probe(struct i2c_client *client) { struct backlight_device *backlight_dev; struct backlight_properties props; @@ -197,7 +196,7 @@ static struct i2c_driver ktz8866_driver = { .name = "ktz8866", .of_match_table = ktz8866_match_table, }, - .probe = ktz8866_probe, + .probe_new = ktz8866_probe, .remove = ktz8866_remove, .id_table = ktz8866_ids, }; base-commit: 2241ab53cbb5cdb08a6b2d4688feb13971058f65 prerequisite-patch-id: 2e7d7db8c0a90b8cd1deb6bbc51ead4c89c89b62 -- 2.39.0
next reply other threads:[~2023-01-27 15:27 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-27 15:26 Uwe Kleine-König [this message] 2023-01-27 15:26 ` [PATCH] backlight: ktz8866: Convert to i2c's .probe_new() Uwe Kleine-König 2023-01-28 0:36 ` Jianhua Lu 2023-01-28 0:36 ` Jianhua Lu 2023-01-28 13:32 ` Uwe Kleine-König 2023-01-28 14:14 ` Jianhua Lu 2023-01-28 16:16 ` Uwe Kleine-König 2023-01-28 16:44 ` Jianhua Lu 2023-01-28 17:07 ` Uwe Kleine-König 2023-01-28 17:35 ` Jianhua Lu 2023-01-30 9:42 ` Lee Jones 2023-01-30 9:42 ` Lee Jones 2023-02-11 23:05 ` Uwe Kleine-König 2023-02-22 15:23 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230127152639.1347229-1-u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=daniel.thompson@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jingoohan1@gmail.com \ --cc=kernel@pengutronix.de \ --cc=lee@kernel.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=lujianhua000@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.