All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Cc: replicant@osuosl.org, phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	"Martin Jücker" <martin.juecker@gmail.com>,
	"Henrik Grimler" <henrik@grimler.se>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 6/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5420
Date: Fri, 27 Jan 2023 20:40:55 +0100	[thread overview]
Message-ID: <20230127194057.186458-7-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230127194057.186458-1-krzysztof.kozlowski@linaro.org>

The DisplayPort and MIPI phys are actually part of the Power Management
Unit system controller.  They do not have their own address space, thus
keeping the nodes under soc causes warnings:

  exynos5420-smdk5420.dtb: soc: dp-video-phy: {'compatible': ['samsung,exynos5420-dp-video-phy'],
    'samsung,pmu-syscon': [[11]], '#phy-cells': [[0]], 'phandle': [[16]]} should not be valid under {'type': 'object'}

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos5420.dtsi | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index b1051a7d07af..6cdb1a832fb9 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -585,18 +585,6 @@ spi_2: spi@12d40000 {
 			status = "disabled";
 		};
 
-		dp_phy: dp-video-phy {
-			compatible = "samsung,exynos5420-dp-video-phy";
-			samsung,pmu-syscon = <&pmu_system_controller>;
-			#phy-cells = <0>;
-		};
-
-		mipi_phy: mipi-video-phy {
-			compatible = "samsung,exynos5420-mipi-video-phy";
-			syscon = <&pmu_system_controller>;
-			#phy-cells = <1>;
-		};
-
 		dsi: dsi@14500000 {
 			compatible = "samsung,exynos5410-mipi-dsi";
 			reg = <0x14500000 0x10000>;
@@ -822,7 +810,7 @@ jpeg_1: jpeg@11f60000 {
 		};
 
 		pmu_system_controller: system-controller@10040000 {
-			compatible = "samsung,exynos5420-pmu", "syscon";
+			compatible = "samsung,exynos5420-pmu", "simple-mfd", "syscon";
 			reg = <0x10040000 0x5000>;
 			clock-names = "clkout16";
 			clocks = <&clock CLK_FIN_PLL>;
@@ -830,6 +818,16 @@ pmu_system_controller: system-controller@10040000 {
 			interrupt-controller;
 			#interrupt-cells = <3>;
 			interrupt-parent = <&gic>;
+
+			dp_phy: dp-phy {
+				compatible = "samsung,exynos5420-dp-video-phy";
+				#phy-cells = <0>;
+			};
+
+			mipi_phy: mipi-phy {
+				compatible = "samsung,exynos5420-mipi-video-phy";
+				#phy-cells = <1>;
+			};
 		};
 
 		tmu_cpu0: tmu@10060000 {
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Cc: replicant@osuosl.org, phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	"Martin Jücker" <martin.juecker@gmail.com>,
	"Henrik Grimler" <henrik@grimler.se>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 6/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5420
Date: Fri, 27 Jan 2023 20:40:55 +0100	[thread overview]
Message-ID: <20230127194057.186458-7-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230127194057.186458-1-krzysztof.kozlowski@linaro.org>

The DisplayPort and MIPI phys are actually part of the Power Management
Unit system controller.  They do not have their own address space, thus
keeping the nodes under soc causes warnings:

  exynos5420-smdk5420.dtb: soc: dp-video-phy: {'compatible': ['samsung,exynos5420-dp-video-phy'],
    'samsung,pmu-syscon': [[11]], '#phy-cells': [[0]], 'phandle': [[16]]} should not be valid under {'type': 'object'}

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos5420.dtsi | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index b1051a7d07af..6cdb1a832fb9 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -585,18 +585,6 @@ spi_2: spi@12d40000 {
 			status = "disabled";
 		};
 
-		dp_phy: dp-video-phy {
-			compatible = "samsung,exynos5420-dp-video-phy";
-			samsung,pmu-syscon = <&pmu_system_controller>;
-			#phy-cells = <0>;
-		};
-
-		mipi_phy: mipi-video-phy {
-			compatible = "samsung,exynos5420-mipi-video-phy";
-			syscon = <&pmu_system_controller>;
-			#phy-cells = <1>;
-		};
-
 		dsi: dsi@14500000 {
 			compatible = "samsung,exynos5410-mipi-dsi";
 			reg = <0x14500000 0x10000>;
@@ -822,7 +810,7 @@ jpeg_1: jpeg@11f60000 {
 		};
 
 		pmu_system_controller: system-controller@10040000 {
-			compatible = "samsung,exynos5420-pmu", "syscon";
+			compatible = "samsung,exynos5420-pmu", "simple-mfd", "syscon";
 			reg = <0x10040000 0x5000>;
 			clock-names = "clkout16";
 			clocks = <&clock CLK_FIN_PLL>;
@@ -830,6 +818,16 @@ pmu_system_controller: system-controller@10040000 {
 			interrupt-controller;
 			#interrupt-cells = <3>;
 			interrupt-parent = <&gic>;
+
+			dp_phy: dp-phy {
+				compatible = "samsung,exynos5420-dp-video-phy";
+				#phy-cells = <0>;
+			};
+
+			mipi_phy: mipi-phy {
+				compatible = "samsung,exynos5420-mipi-video-phy";
+				#phy-cells = <1>;
+			};
 		};
 
 		tmu_cpu0: tmu@10060000 {
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Cc: replicant@osuosl.org, phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	"Martin Jücker" <martin.juecker@gmail.com>,
	"Henrik Grimler" <henrik@grimler.se>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 6/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5420
Date: Fri, 27 Jan 2023 20:40:55 +0100	[thread overview]
Message-ID: <20230127194057.186458-7-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230127194057.186458-1-krzysztof.kozlowski@linaro.org>

The DisplayPort and MIPI phys are actually part of the Power Management
Unit system controller.  They do not have their own address space, thus
keeping the nodes under soc causes warnings:

  exynos5420-smdk5420.dtb: soc: dp-video-phy: {'compatible': ['samsung,exynos5420-dp-video-phy'],
    'samsung,pmu-syscon': [[11]], '#phy-cells': [[0]], 'phandle': [[16]]} should not be valid under {'type': 'object'}

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos5420.dtsi | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index b1051a7d07af..6cdb1a832fb9 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -585,18 +585,6 @@ spi_2: spi@12d40000 {
 			status = "disabled";
 		};
 
-		dp_phy: dp-video-phy {
-			compatible = "samsung,exynos5420-dp-video-phy";
-			samsung,pmu-syscon = <&pmu_system_controller>;
-			#phy-cells = <0>;
-		};
-
-		mipi_phy: mipi-video-phy {
-			compatible = "samsung,exynos5420-mipi-video-phy";
-			syscon = <&pmu_system_controller>;
-			#phy-cells = <1>;
-		};
-
 		dsi: dsi@14500000 {
 			compatible = "samsung,exynos5410-mipi-dsi";
 			reg = <0x14500000 0x10000>;
@@ -822,7 +810,7 @@ jpeg_1: jpeg@11f60000 {
 		};
 
 		pmu_system_controller: system-controller@10040000 {
-			compatible = "samsung,exynos5420-pmu", "syscon";
+			compatible = "samsung,exynos5420-pmu", "simple-mfd", "syscon";
 			reg = <0x10040000 0x5000>;
 			clock-names = "clkout16";
 			clocks = <&clock CLK_FIN_PLL>;
@@ -830,6 +818,16 @@ pmu_system_controller: system-controller@10040000 {
 			interrupt-controller;
 			#interrupt-cells = <3>;
 			interrupt-parent = <&gic>;
+
+			dp_phy: dp-phy {
+				compatible = "samsung,exynos5420-dp-video-phy";
+				#phy-cells = <0>;
+			};
+
+			mipi_phy: mipi-phy {
+				compatible = "samsung,exynos5420-mipi-video-phy";
+				#phy-cells = <1>;
+			};
 		};
 
 		tmu_cpu0: tmu@10060000 {
-- 
2.34.1


  parent reply	other threads:[~2023-01-27 19:42 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 19:40 [PATCH 0/8] dt-bindings: phy/samsung: move MIPI and DP phys under PMU Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 1/8] dt-bindings: soc: samsung: exynos-pmu: allow phys as child Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 21:23   ` Rob Herring
2023-01-27 21:23     ` Rob Herring
2023-01-27 21:23     ` Rob Herring
2023-01-29 10:40   ` (subset) " Krzysztof Kozlowski
2023-01-29 10:40     ` Krzysztof Kozlowski
2023-01-29 10:40     ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 2/8] dt-bindings: phy: samsung,dp-video-phy: deprecate syscon phandle Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-30 21:15   ` Rob Herring
2023-01-30 21:15     ` Rob Herring
2023-01-30 21:15     ` Rob Herring
2023-01-31 17:32   ` Krzysztof Kozlowski
2023-01-31 17:32     ` Krzysztof Kozlowski
2023-01-31 17:32     ` Krzysztof Kozlowski
2023-02-03 13:38   ` Vinod Koul
2023-02-03 13:38     ` Vinod Koul
2023-02-03 13:38     ` Vinod Koul
2023-02-03 15:10   ` (subset) " Krzysztof Kozlowski
2023-02-03 15:10     ` Krzysztof Kozlowski
2023-02-03 15:10     ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 3/8] dt-bindings: phy: samsung,mipi-video-phy: " Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-30 21:16   ` Rob Herring
2023-01-30 21:16     ` Rob Herring
2023-02-03 15:10   ` (subset) " Krzysztof Kozlowski
2023-02-03 15:10     ` Krzysztof Kozlowski
2023-02-03 15:10     ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 4/8] phy: samsung,dp-video-phy: " Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-02-03 13:41   ` Vinod Koul
2023-02-03 13:41     ` Vinod Koul
2023-02-03 13:41     ` Vinod Koul
2023-02-03 15:10   ` (subset) " Krzysztof Kozlowski
2023-02-03 15:10     ` Krzysztof Kozlowski
2023-02-03 15:10     ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 5/8] phy: samsung,mipi-video-phy: " Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-02-03 13:42   ` Vinod Koul
2023-02-03 13:42     ` Vinod Koul
2023-02-03 13:42     ` Vinod Koul
2023-02-03 15:10   ` (subset) " Krzysztof Kozlowski
2023-02-03 15:10     ` Krzysztof Kozlowski
2023-02-03 15:10     ` Krzysztof Kozlowski
2023-01-27 19:40 ` Krzysztof Kozlowski [this message]
2023-01-27 19:40   ` [PATCH 6/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5420 Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 22:54   ` Marek Szyprowski
2023-01-27 22:54     ` Marek Szyprowski
2023-01-27 22:54     ` Marek Szyprowski
2023-03-06 11:39   ` (subset) " Krzysztof Kozlowski
2023-03-06 11:39     ` Krzysztof Kozlowski
2023-03-06 11:39     ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 7/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5250 Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 22:53   ` Marek Szyprowski
2023-01-27 22:53     ` Marek Szyprowski
2023-01-27 22:53     ` Marek Szyprowski
2023-03-06 11:39   ` (subset) " Krzysztof Kozlowski
2023-03-06 11:39     ` Krzysztof Kozlowski
2023-03-06 11:39     ` Krzysztof Kozlowski
2023-01-27 19:40 ` [PATCH 8/8] arm64: dts: exynos: move MIPI phy to PMU node in Exynos5433 Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 19:40   ` Krzysztof Kozlowski
2023-01-27 22:16   ` Marek Szyprowski
2023-01-27 22:16     ` Marek Szyprowski
2023-01-27 22:16     ` Marek Szyprowski
2023-03-06 11:39   ` (subset) " Krzysztof Kozlowski
2023-03-06 11:39     ` Krzysztof Kozlowski
2023-03-06 11:39     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230127194057.186458-7-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=henrik@grimler.se \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=martin.juecker@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=replicant@osuosl.org \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=vkoul@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.