From: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
To: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
peterz@infradead.org, hpa@zytor.com
Cc: bp@alien8.de, dave.hansen@linux.intel.com,
rafael.j.wysocki@intel.com, paulmck@kernel.org, jgross@suse.com,
seanjc@google.com, thomas.lendacky@amd.com,
linux-kernel@vger.kernel.org, imammedo@redhat.com,
amakhalov@vmware.com, ganb@vmware.com, ankitja@vmware.com,
bordoloih@vmware.com, keerthanak@vmware.com,
blamoreaux@vmware.com, namit@vmware.com, wyes.karny@amd.com,
lewis.carroll@amd.com, pv-drivers@vmware.com,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
xen-devel@lists.xenproject.org, srivatsa@csail.mit.edu
Subject: [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead()
Date: Fri, 27 Jan 2023 16:37:51 -0800 [thread overview]
Message-ID: <20230128003751.141317-1-srivatsa@csail.mit.edu> (raw)
From: "Srivatsa S. Bhat (VMware)" <srivatsa@csail.mit.edu>
The comment that says mwait_play_dead() returns only on failure is a
bit misleading because mwait_play_dead() could actually return for
valid reasons (such as mwait not being supported by the platform) that
do not indicate a failure of the CPU offline operation. So, remove the
comment.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
---
arch/x86/kernel/smpboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 55cad72715d9..9013bb28255a 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1833,7 +1833,7 @@ void native_play_dead(void)
play_dead_common();
tboot_shutdown(TB_SHUTDOWN_WFS);
- mwait_play_dead(); /* Only returns on failure */
+ mwait_play_dead();
if (cpuidle_play_dead())
hlt_play_dead();
}
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
To: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
peterz@infradead.org, hpa@zytor.com
Cc: kvm@vger.kernel.org, pv-drivers@vmware.com,
dave.hansen@linux.intel.com,
virtualization@lists.linux-foundation.org, ganb@vmware.com,
ankitja@vmware.com, namit@vmware.com, amakhalov@vmware.com,
rafael.j.wysocki@intel.com, bordoloih@vmware.com,
xen-devel@lists.xenproject.org, wyes.karny@amd.com,
thomas.lendacky@amd.com, paulmck@kernel.org,
keerthanak@vmware.com, bp@alien8.de, jgross@suse.com,
seanjc@google.com, linux-kernel@vger.kernel.org,
lewis.carroll@amd.com, imammedo@redhat.com,
blamoreaux@vmware.com
Subject: [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead()
Date: Fri, 27 Jan 2023 16:37:51 -0800 [thread overview]
Message-ID: <20230128003751.141317-1-srivatsa@csail.mit.edu> (raw)
From: "Srivatsa S. Bhat (VMware)" <srivatsa@csail.mit.edu>
The comment that says mwait_play_dead() returns only on failure is a
bit misleading because mwait_play_dead() could actually return for
valid reasons (such as mwait not being supported by the platform) that
do not indicate a failure of the CPU offline operation. So, remove the
comment.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
---
arch/x86/kernel/smpboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 55cad72715d9..9013bb28255a 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1833,7 +1833,7 @@ void native_play_dead(void)
play_dead_common();
tboot_shutdown(TB_SHUTDOWN_WFS);
- mwait_play_dead(); /* Only returns on failure */
+ mwait_play_dead();
if (cpuidle_play_dead())
hlt_play_dead();
}
--
2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next reply other threads:[~2023-01-28 0:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 0:37 Srivatsa S. Bhat [this message]
2023-01-28 0:37 ` [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead() Srivatsa S. Bhat
2023-02-14 17:09 ` Srivatsa S. Bhat
2023-02-14 17:09 ` Srivatsa S. Bhat
2023-02-14 22:56 ` [tip: x86/cleanups] " tip-bot2 for Srivatsa S. Bhat (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230128003751.141317-1-srivatsa@csail.mit.edu \
--to=srivatsa@csail.mit.edu \
--cc=amakhalov@vmware.com \
--cc=ankitja@vmware.com \
--cc=blamoreaux@vmware.com \
--cc=bordoloih@vmware.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=ganb@vmware.com \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=jgross@suse.com \
--cc=keerthanak@vmware.com \
--cc=kvm@vger.kernel.org \
--cc=lewis.carroll@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pv-drivers@vmware.com \
--cc=rafael.j.wysocki@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wyes.karny@amd.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.