All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Healy <cphealy@gmail.com>
To: cphealy@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com,
	linux@armlinux.org.uk, davem@davemloft.net,
	neil.armstrong@linaro.org, khilman@baylibre.com,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	jeremy.wang@amlogic.com
Cc: Chris Healy <healych@amazon.com>
Subject: [PATCH 1/1] net: phy: meson-gxl: Add generic dummy stubs for MMD register access
Date: Sat, 28 Jan 2023 18:26:15 -0800	[thread overview]
Message-ID: <20230129022615.379711-1-cphealy@gmail.com> (raw)

From: Chris Healy <healych@amazon.com>

The Meson G12A Internal PHY does not support standard IEEE MMD extended
register access, therefore add generic dummy stubs to fail the read and
write MMD calls. This is necessary to prevent the core PHY code from
erroneously believing that EEE is supported by this PHY even though this
PHY does not support EEE, as MMD register access returns all FFFFs.

Signed-off-by: Chris Healy <healych@amazon.com>
---
 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index c49062ad72c6..5e41658b1e2f 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	},
 };
 
-- 
2.39.1


WARNING: multiple messages have this Message-ID (diff)
From: Chris Healy <cphealy@gmail.com>
To: cphealy@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com,
	linux@armlinux.org.uk, davem@davemloft.net,
	neil.armstrong@linaro.org, khilman@baylibre.com,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	jeremy.wang@amlogic.com
Cc: Chris Healy <healych@amazon.com>
Subject: [PATCH 1/1] net: phy: meson-gxl: Add generic dummy stubs for MMD register access
Date: Sat, 28 Jan 2023 18:26:15 -0800	[thread overview]
Message-ID: <20230129022615.379711-1-cphealy@gmail.com> (raw)

From: Chris Healy <healych@amazon.com>

The Meson G12A Internal PHY does not support standard IEEE MMD extended
register access, therefore add generic dummy stubs to fail the read and
write MMD calls. This is necessary to prevent the core PHY code from
erroneously believing that EEE is supported by this PHY even though this
PHY does not support EEE, as MMD register access returns all FFFFs.

Signed-off-by: Chris Healy <healych@amazon.com>
---
 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index c49062ad72c6..5e41658b1e2f 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	},
 };
 
-- 
2.39.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Chris Healy <cphealy@gmail.com>
To: cphealy@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com,
	linux@armlinux.org.uk, davem@davemloft.net,
	neil.armstrong@linaro.org, khilman@baylibre.com,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	jeremy.wang@amlogic.com
Cc: Chris Healy <healych@amazon.com>
Subject: [PATCH 1/1] net: phy: meson-gxl: Add generic dummy stubs for MMD register access
Date: Sat, 28 Jan 2023 18:26:15 -0800	[thread overview]
Message-ID: <20230129022615.379711-1-cphealy@gmail.com> (raw)

From: Chris Healy <healych@amazon.com>

The Meson G12A Internal PHY does not support standard IEEE MMD extended
register access, therefore add generic dummy stubs to fail the read and
write MMD calls. This is necessary to prevent the core PHY code from
erroneously believing that EEE is supported by this PHY even though this
PHY does not support EEE, as MMD register access returns all FFFFs.

Signed-off-by: Chris Healy <healych@amazon.com>
---
 drivers/net/phy/meson-gxl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index c49062ad72c6..5e41658b1e2f 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
 		.handle_interrupt = meson_gxl_handle_interrupt,
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
+		.read_mmd	= genphy_read_mmd_unsupported,
+		.write_mmd	= genphy_write_mmd_unsupported,
 	},
 };
 
-- 
2.39.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

             reply	other threads:[~2023-01-29  2:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29  2:26 Chris Healy [this message]
2023-01-29  2:26 ` [PATCH 1/1] net: phy: meson-gxl: Add generic dummy stubs for MMD register access Chris Healy
2023-01-29  2:26 ` Chris Healy
2023-01-29 10:26 ` Heiner Kallweit
2023-01-29 10:26   ` Heiner Kallweit
2023-01-29 10:26   ` Heiner Kallweit
2023-01-29 21:25   ` Chris Healy
2023-01-29 21:25     ` Chris Healy
2023-01-29 21:25     ` Chris Healy
2023-01-29 16:51 ` Andrew Lunn
2023-01-29 16:51   ` Andrew Lunn
2023-01-29 16:51   ` Andrew Lunn
2023-01-29 21:28   ` Chris Healy
2023-01-29 21:28     ` Chris Healy
2023-01-29 21:28     ` Chris Healy
2023-01-29 21:53     ` Andrew Lunn
2023-01-29 21:53       ` Andrew Lunn
2023-01-29 21:53       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230129022615.379711-1-cphealy@gmail.com \
    --to=cphealy@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=healych@amazon.com \
    --cc=hkallweit1@gmail.com \
    --cc=jeremy.wang@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.