All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Adam Ford <aford173@gmail.com>,
	Martin Kepplinger <martin.kepplinger@puri.sm>,
	Paul Elder <paul.elder@ideasonboard.com>,
	Rui Miguel Silva <rmfrfs@gmail.com>,
	kernel@pengutronix.de, linux-imx@nxp.com
Subject: [PATCH v2 2/8] media: imx: imx7-media-csi: Simplify imx7_csi_video_init_format()
Date: Sun, 29 Jan 2023 04:34:23 +0200	[thread overview]
Message-ID: <20230129023429.22467-3-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20230129023429.22467-1-laurent.pinchart@ideasonboard.com>

The imx7_csi_video_init_format() function instantiates a
v4l2_subdev_format on the stack, to only use the .format field of that
structure. Replace it with a v4l2_mbus_framefmt instance.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/platform/nxp/imx7-media-csi.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/media/platform/nxp/imx7-media-csi.c b/drivers/media/platform/nxp/imx7-media-csi.c
index f1d7da7763d5..112af7279ccf 100644
--- a/drivers/media/platform/nxp/imx7-media-csi.c
+++ b/drivers/media/platform/nxp/imx7-media-csi.c
@@ -1600,17 +1600,15 @@ static struct imx7_csi_vb2_buffer *imx7_csi_video_next_buf(struct imx7_csi *csi)
 
 static int imx7_csi_video_init_format(struct imx7_csi *csi)
 {
-	struct v4l2_subdev_format fmt_src = {
-		.pad = IMX7_CSI_PAD_SRC,
-		.which = V4L2_SUBDEV_FORMAT_ACTIVE,
-	};
-	fmt_src.format.code = IMX7_CSI_DEF_MBUS_CODE;
-	fmt_src.format.width = IMX7_CSI_DEF_PIX_WIDTH;
-	fmt_src.format.height = IMX7_CSI_DEF_PIX_HEIGHT;
+	struct v4l2_mbus_framefmt format = { };
 
-	imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &fmt_src.format, NULL);
-	csi->vdev_compose.width = fmt_src.format.width;
-	csi->vdev_compose.height = fmt_src.format.height;
+	format.code = IMX7_CSI_DEF_MBUS_CODE;
+	format.width = IMX7_CSI_DEF_PIX_WIDTH;
+	format.height = IMX7_CSI_DEF_PIX_HEIGHT;
+
+	imx7_csi_mbus_fmt_to_pix_fmt(&csi->vdev_fmt, &format, NULL);
+	csi->vdev_compose.width = format.width;
+	csi->vdev_compose.height = format.height;
 
 	csi->vdev_cc = imx7_csi_find_pixel_format(csi->vdev_fmt.pixelformat);
 
-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2023-01-29  2:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29  2:34 [PATCH v2 0/8] media: nxp: imx7-media-csi: Move to subdev active state Laurent Pinchart
2023-01-29  2:34 ` [PATCH v2 1/8] media: imx: imx7-media-csi: Drop imx7_csi.cc field Laurent Pinchart
2023-01-29  2:34 ` Laurent Pinchart [this message]
2023-01-29  2:34 ` [PATCH v2 3/8] media: imx: imx7-media-csi: Drop unneeded check when starting streaming Laurent Pinchart
2023-01-29  2:34 ` [PATCH v2 4/8] media: imx: imx7-media-csi: Drop unneeded src_sd check Laurent Pinchart
2023-01-29  2:34 ` [PATCH v2 5/8] media: imx: imx7-media-csi: Drop unneeded pad checks Laurent Pinchart
2023-01-29  2:34 ` [PATCH v2 6/8] media: imx: imx7-media-csi: Cleanup errors in imx7_csi_async_register() Laurent Pinchart
2023-01-29  2:34 ` [PATCH v2 7/8] media: imx: imx7-media-csi: Zero format struct before calling .get_fmt() Laurent Pinchart
2023-01-29  2:34 ` [PATCH v2 8/8] media: imx: imx7-media-csi: Use V4L2 subdev active state Laurent Pinchart
2023-01-30 19:26   ` Jacopo Mondi
2023-01-30 20:14     ` Laurent Pinchart
2023-01-30 23:45 ` [PATCH v2 0/8] media: nxp: imx7-media-csi: Move to " Adam Ford
2023-01-31  9:30 ` Rui Miguel Silva
2023-01-31 10:17 ` Martin Kepplinger
2023-01-31 10:24   ` Laurent Pinchart
2023-01-31 11:18 ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230129023429.22467-3-laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=aford173@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=paul.elder@ideasonboard.com \
    --cc=rmfrfs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.