From: Longlong Xia <xialonglong1@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<ying.huang@intel.com>, <chenwandun@huawei.com>,
<wangkefeng.wang@huawei.com>, <sunnanyong@huawei.com>,
Longlong Xia <xialonglong1@huawei.com>
Subject: [PATCH -next] mm/swapfile: remove pr_debug in get_swap_pages()
Date: Tue, 31 Jan 2023 07:10:35 +0000 [thread overview]
Message-ID: <20230131071035.1085968-1-xialonglong1@huawei.com> (raw)
In-Reply-To: <87wn54c1fi.fsf@yhuang6-desk2.ccr.corp.intel.com>
It's known that get_swap_pages() may fail to find available space
under some extreme case, but pr_debug() provides useless information.
Let's remove it.
Signed-off-by: Longlong Xia <xialonglong1@huawei.com>
---
mm/swapfile.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 6202a6668a63..99143875d6f0 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -1098,8 +1098,6 @@ int get_swap_pages(int n_goal, swp_entry_t swp_entries[], int entry_size)
spin_unlock(&si->lock);
if (n_ret || size == SWAPFILE_CLUSTER)
goto check_out;
- pr_debug("scan_swap_map of si %d failed to find offset\n",
- si->type);
cond_resched();
spin_lock(&swap_avail_lock);
--
2.25.1
next prev parent reply other threads:[~2023-01-31 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 9:47 [PATCH] mm/swapfile: add cond_resched() in get_swap_pages() Longlong Xia
2023-01-29 0:39 ` Huang, Ying
2023-01-29 21:03 ` Andrew Morton
2023-01-30 0:26 ` Huang, Ying
2023-01-31 7:10 ` Longlong Xia [this message]
2023-01-31 7:27 ` [PATCH -next] mm/swapfile: remove pr_debug " Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131071035.1085968-1-xialonglong1@huawei.com \
--to=xialonglong1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=chenwandun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.