From: Imre Deak <imre.deak@intel.com> To: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Subject: [PATCH v2 15/17] drm/dp: Add a quirk for a DELL P2715Q MST payload allocation problem Date: Tue, 31 Jan 2023 17:05:46 +0200 [thread overview] Message-ID: <20230131150548.1614458-16-imre.deak@intel.com> (raw) In-Reply-To: <20230131150548.1614458-1-imre.deak@intel.com> The DELL P2715Q monitor's MST hub has a payload allocation problem, where the VCPI used to reserve the last two time slots (at position 0x3e, 0x3f) in the hub's payload table, this VCPI can't be reused for later payload configurations. To work around the problem in a follow-up patch the driver needs to reset the payload table after all payloads have been freed; add a quirk the driver can use to detect the monitor and apply the WA if needed. Cc: Lyude Paul <lyude@redhat.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Imre Deak <imre.deak@intel.com> --- drivers/gpu/drm/display/drm_dp_helper.c | 2 ++ include/drm/display/drm_dp_helper.h | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index 16565a0a5da6d..e2cf4b4fe11ea 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2244,6 +2244,8 @@ static const struct dpcd_quirk dpcd_quirk_list[] = { { OUI(0x90, 0xCC, 0x24), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) }, /* Apple MacBookPro 2017 15 inch eDP Retina panel reports too low DP_MAX_LINK_RATE */ { OUI(0x00, 0x10, 0xfa), DEVICE_ID(101, 68, 21, 101, 98, 97), false, BIT(DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS) }, + /* DELL P2715Q MST payload table must be reset after the two last payload slots get allocated. */ + { OUI(0x00, 0xe0, 0x4c), DEVICE_ID('D', 'p', '1', '.', '2', 0), true, BIT(DP_DPCD_QUIRK_MST_PAYLOAD_TABLE_RESET_WA) }, }; #undef OUI diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index ab55453f2d2cd..fcd445921ec9d 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -620,6 +620,14 @@ enum drm_dp_quirk { * the DP_MAX_LINK_RATE register reporting a lower max multiplier. */ DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS, + /** + * @DP_DPCD_QUIRK_MST_PAYLOAD_TABLE_RESET_WA: + * + * An bug in the MST branch device's payload allocation logic requires + * the payload table to be reset after its last two payload slots get + * allocated. + */ + DP_DPCD_QUIRK_MST_PAYLOAD_TABLE_RESET_WA, }; /** -- 2.37.1
WARNING: multiple messages have this Message-ID (diff)
From: Imre Deak <imre.deak@intel.com> To: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH v2 15/17] drm/dp: Add a quirk for a DELL P2715Q MST payload allocation problem Date: Tue, 31 Jan 2023 17:05:46 +0200 [thread overview] Message-ID: <20230131150548.1614458-16-imre.deak@intel.com> (raw) In-Reply-To: <20230131150548.1614458-1-imre.deak@intel.com> The DELL P2715Q monitor's MST hub has a payload allocation problem, where the VCPI used to reserve the last two time slots (at position 0x3e, 0x3f) in the hub's payload table, this VCPI can't be reused for later payload configurations. To work around the problem in a follow-up patch the driver needs to reset the payload table after all payloads have been freed; add a quirk the driver can use to detect the monitor and apply the WA if needed. Cc: Lyude Paul <lyude@redhat.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Imre Deak <imre.deak@intel.com> --- drivers/gpu/drm/display/drm_dp_helper.c | 2 ++ include/drm/display/drm_dp_helper.h | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index 16565a0a5da6d..e2cf4b4fe11ea 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2244,6 +2244,8 @@ static const struct dpcd_quirk dpcd_quirk_list[] = { { OUI(0x90, 0xCC, 0x24), DEVICE_ID_ANY, true, BIT(DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) }, /* Apple MacBookPro 2017 15 inch eDP Retina panel reports too low DP_MAX_LINK_RATE */ { OUI(0x00, 0x10, 0xfa), DEVICE_ID(101, 68, 21, 101, 98, 97), false, BIT(DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS) }, + /* DELL P2715Q MST payload table must be reset after the two last payload slots get allocated. */ + { OUI(0x00, 0xe0, 0x4c), DEVICE_ID('D', 'p', '1', '.', '2', 0), true, BIT(DP_DPCD_QUIRK_MST_PAYLOAD_TABLE_RESET_WA) }, }; #undef OUI diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index ab55453f2d2cd..fcd445921ec9d 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -620,6 +620,14 @@ enum drm_dp_quirk { * the DP_MAX_LINK_RATE register reporting a lower max multiplier. */ DP_DPCD_QUIRK_CAN_DO_MAX_LINK_RATE_3_24_GBPS, + /** + * @DP_DPCD_QUIRK_MST_PAYLOAD_TABLE_RESET_WA: + * + * An bug in the MST branch device's payload allocation logic requires + * the payload table to be reset after its last two payload slots get + * allocated. + */ + DP_DPCD_QUIRK_MST_PAYLOAD_TABLE_RESET_WA, }; /** -- 2.37.1
next prev parent reply other threads:[~2023-01-31 15:06 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-31 15:05 [Intel-gfx] [PATCH v2 00/17] drm/i915: drm/i915/dp_mst: Fix MST payload removal during output disabling Imre Deak 2023-01-31 15:05 ` [Intel-gfx] [PATCH v2 01/17] drm/i915/dp_mst: Add the MST topology state for modesetted CRTCs Imre Deak 2023-01-31 15:05 ` Imre Deak 2023-01-31 15:05 ` [PATCH v2 02/17] drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload() Imre Deak 2023-01-31 15:05 ` Imre Deak 2023-01-31 15:05 ` [Intel-gfx] " Imre Deak 2023-01-31 23:13 ` Lyude Paul 2023-01-31 23:13 ` Lyude Paul 2023-01-31 23:13 ` [Intel-gfx] " Lyude Paul 2023-02-01 15:04 ` Imre Deak 2023-02-01 15:04 ` Imre Deak 2023-02-01 15:04 ` [Intel-gfx] " Imre Deak 2023-02-07 0:42 ` Lyude Paul 2023-02-07 0:42 ` Lyude Paul 2023-02-07 0:42 ` Lyude Paul 2023-02-07 12:11 ` Imre Deak 2023-02-07 12:11 ` [Intel-gfx] " Imre Deak 2023-02-07 12:11 ` Imre Deak 2023-02-08 0:21 ` [Intel-gfx] " Lyude Paul 2023-02-08 0:21 ` Lyude Paul 2023-02-08 0:21 ` Lyude Paul 2023-02-08 7:41 ` Imre Deak 2023-02-08 7:41 ` [Intel-gfx] " Imre Deak 2023-02-08 7:41 ` Imre Deak 2023-02-09 21:43 ` Lyude Paul 2023-02-09 21:43 ` [Intel-gfx] " Lyude Paul 2023-02-09 21:43 ` Lyude Paul 2023-01-31 15:05 ` [PATCH v2 03/17] drm/display/dp_mst: Add drm_atomic_get_old_mst_topology_state() Imre Deak 2023-01-31 15:05 ` Imre Deak 2023-01-31 15:05 ` [Intel-gfx] " Imre Deak 2023-01-31 15:05 ` [Intel-gfx] [PATCH v2 04/17] drm/i915/dp_mst: Fix payload removal during output disabling Imre Deak 2023-01-31 15:05 ` Imre Deak 2023-01-31 15:05 ` [PATCH v2 05/17] drm/display/dp_mst: Fix the payload VCPI check in drm_dp_mst_dump_topology() Imre Deak 2023-01-31 15:05 ` [Intel-gfx] " Imre Deak 2023-01-31 15:05 ` [Intel-gfx] [PATCH v2 06/17] drm/display/dp_mst: Sanitize payload iteration " Imre Deak 2023-01-31 23:14 ` Lyude Paul 2023-02-03 12:22 ` Ville Syrjälä 2023-02-03 13:12 ` Imre Deak 2023-01-31 15:05 ` [Intel-gfx] [PATCH v2 07/17] drm/i915: Factor out helpers for modesetting CRTCs and connectors Imre Deak 2023-01-31 15:05 ` [Intel-gfx] [PATCH v2 08/17] drm/i915/dp_mst: Move getting the MST topology state earlier to connector check Imre Deak 2023-01-31 15:05 ` [PATCH v2 09/17] drm/display/dp_mst: Add a helper to verify the MST payload state Imre Deak 2023-01-31 15:05 ` [Intel-gfx] " Imre Deak 2023-01-31 15:05 ` [Intel-gfx] [PATCH v2 10/17] drm/i915/dp_mst: Verify the MST state of modesetted outputs Imre Deak 2023-01-31 15:05 ` [PATCH v2 11/17] drm/display/dp_mst: Add helpers to query for payload allocation errors Imre Deak 2023-01-31 15:05 ` [Intel-gfx] " Imre Deak 2023-02-02 10:13 ` kernel test robot 2023-02-02 12:15 ` [Intel-gfx] " Dan Carpenter 2023-02-02 12:15 ` Dan Carpenter 2023-02-02 12:15 ` Dan Carpenter 2023-02-02 12:35 ` Imre Deak 2023-02-02 12:35 ` [Intel-gfx] " Imre Deak 2023-02-02 12:35 ` Imre Deak 2023-01-31 15:05 ` [PATCH v2 12/17] drm/display/dp_mst: Add helpers to query payload allocation properties Imre Deak 2023-01-31 15:05 ` [Intel-gfx] " Imre Deak 2023-01-31 15:05 ` [PATCH v2 13/17] drm/display/dp_mst: Export the DP_PAYLOAD_TABLE_SIZE definition Imre Deak 2023-01-31 15:05 ` [Intel-gfx] " Imre Deak 2023-01-31 15:05 ` [PATCH v2 14/17] drm/display/dp_mst: Factor out a helper to reset the payload table Imre Deak 2023-01-31 15:05 ` [Intel-gfx] " Imre Deak 2023-01-31 15:05 ` Imre Deak [this message] 2023-01-31 15:05 ` [Intel-gfx] [PATCH v2 15/17] drm/dp: Add a quirk for a DELL P2715Q MST payload allocation problem Imre Deak 2023-01-31 15:05 ` [Intel-gfx] [PATCH v2 16/17] drm/i915/dp_mst: Add workaround for a DELL P2715Q " Imre Deak 2023-01-31 22:47 ` Lyude Paul 2023-02-01 14:41 ` Imre Deak 2023-01-31 23:43 ` Lyude Paul 2023-01-31 15:05 ` [Intel-gfx] [PATCH v2 17/17] drm/i915/dp_mst: Verify the HW state of MST encoders Imre Deak 2023-02-01 9:41 ` Jani Nikula 2023-02-01 14:03 ` Imre Deak 2023-01-31 15:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: drm/i915/dp_mst: Fix MST payload removal during output disabling Patchwork 2023-01-31 15:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-01-31 20:42 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230131150548.1614458-16-imre.deak@intel.com \ --to=imre.deak@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.