From: Johan Hovold <johan+linaro@kernel.org> To: Georgi Djakov <djakov@kernel.org> Cc: "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "Fabio Estevam" <festevam@gmail.com>, "NXP Linux Team" <linux-imx@nxp.com>, "Andy Gross" <agross@kernel.org>, "Bjorn Andersson" <andersson@kernel.org>, "Konrad Dybcio" <konrad.dybcio@linaro.org>, "Sylwester Nawrocki" <s.nawrocki@samsung.com>, "Artur Świgoń" <a.swigon@samsung.com>, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>, "Alim Akhtar" <alim.akhtar@samsung.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Jonathan Hunter" <jonathanh@nvidia.com>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, "Johan Hovold" <johan+linaro@kernel.org> Subject: [PATCH 00/23] interconnect: fix racy provider registration Date: Wed, 1 Feb 2023 11:15:36 +0100 [thread overview] Message-ID: <20230201101559.15529-1-johan+linaro@kernel.org> (raw) The current interconnect provider interface is inherently racy as providers are expected to be registered before being fully initialised. This can specifically cause racing DT lookups to fail as I recently noticed when the Qualcomm cpufreq driver failed to probe: of_icc_xlate_onecell: invalid index 0 cpu cpu0: error -EINVAL: error finding src node cpu cpu0: dev_pm_opp_of_find_icc_paths: Unable to get path0: -22 qcom-cpufreq-hw: probe of 18591000.cpufreq failed with error -22 This only happens very rarely, but the bug is easily reproduced by increasing the race window by adding an msleep() after registering osm-l3 interconnect provider. Note that the Qualcomm cpufreq driver is especially susceptible to this race as the interconnect path is looked up from the CPU nodes so that driver core does not guarantee the probe order even when device links are enabled (which they not always are). This series adds a new interconnect provider registration API which is used to fix up the interconnect drivers before removing the old racy API. Included are also a number of fixes for other bugs found while preparing the series. Johan Johan Hovold (23): interconnect: fix mem leak when freeing nodes interconnect: fix icc_provider_del() error handling interconnect: fix provider registration API interconnect: imx: fix registration race interconnect: qcom: osm-l3: fix registration race interconnect: qcom: rpm: fix probe child-node error handling interconnect: qcom: rpm: fix probe PM domain error handling interconnect: qcom: rpm: fix registration race interconnect: qcom: rpmh: fix probe child-node error handling interconnect: qcom: rpmh: fix registration race interconnect: qcom: msm8974: fix registration race interconnect: qcom: sm8450: fix registration race interconnect: qcom: sm8550: fix registration race interconnect: exynos: fix node leak in probe PM QoS error path interconnect: exynos: fix registration race interconnect: exynos: drop redundant link destroy memory: tegra: fix interconnect registration race memory: tegra124-emc: fix interconnect registration race memory: tegra20-emc: fix interconnect registration race memory: tegra30-emc: fix interconnect registration race interconnect: drop racy registration API interconnect: drop unused icc_get() interface interconnect: drop unused icc_link_destroy() interface drivers/interconnect/core.c | 149 +++++--------------------- drivers/interconnect/imx/imx.c | 20 ++-- drivers/interconnect/qcom/icc-rpm.c | 33 +++--- drivers/interconnect/qcom/icc-rpmh.c | 30 ++++-- drivers/interconnect/qcom/msm8974.c | 20 ++-- drivers/interconnect/qcom/osm-l3.c | 14 ++- drivers/interconnect/qcom/sm8450.c | 22 ++-- drivers/interconnect/qcom/sm8550.c | 22 ++-- drivers/interconnect/samsung/exynos.c | 30 +++--- drivers/memory/tegra/mc.c | 16 ++- drivers/memory/tegra/tegra124-emc.c | 12 +-- drivers/memory/tegra/tegra20-emc.c | 12 +-- drivers/memory/tegra/tegra30-emc.c | 12 +-- include/linux/interconnect-provider.h | 19 ++-- include/linux/interconnect.h | 8 -- 15 files changed, 154 insertions(+), 265 deletions(-) -- 2.39.1
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org> To: Georgi Djakov <djakov@kernel.org> Cc: "Shawn Guo" <shawnguo@kernel.org>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Pengutronix Kernel Team" <kernel@pengutronix.de>, "Fabio Estevam" <festevam@gmail.com>, "NXP Linux Team" <linux-imx@nxp.com>, "Andy Gross" <agross@kernel.org>, "Bjorn Andersson" <andersson@kernel.org>, "Konrad Dybcio" <konrad.dybcio@linaro.org>, "Sylwester Nawrocki" <s.nawrocki@samsung.com>, "Artur Świgoń" <a.swigon@samsung.com>, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>, "Alim Akhtar" <alim.akhtar@samsung.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Jonathan Hunter" <jonathanh@nvidia.com>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, "Johan Hovold" <johan+linaro@kernel.org> Subject: [PATCH 00/23] interconnect: fix racy provider registration Date: Wed, 1 Feb 2023 11:15:36 +0100 [thread overview] Message-ID: <20230201101559.15529-1-johan+linaro@kernel.org> (raw) The current interconnect provider interface is inherently racy as providers are expected to be registered before being fully initialised. This can specifically cause racing DT lookups to fail as I recently noticed when the Qualcomm cpufreq driver failed to probe: of_icc_xlate_onecell: invalid index 0 cpu cpu0: error -EINVAL: error finding src node cpu cpu0: dev_pm_opp_of_find_icc_paths: Unable to get path0: -22 qcom-cpufreq-hw: probe of 18591000.cpufreq failed with error -22 This only happens very rarely, but the bug is easily reproduced by increasing the race window by adding an msleep() after registering osm-l3 interconnect provider. Note that the Qualcomm cpufreq driver is especially susceptible to this race as the interconnect path is looked up from the CPU nodes so that driver core does not guarantee the probe order even when device links are enabled (which they not always are). This series adds a new interconnect provider registration API which is used to fix up the interconnect drivers before removing the old racy API. Included are also a number of fixes for other bugs found while preparing the series. Johan Johan Hovold (23): interconnect: fix mem leak when freeing nodes interconnect: fix icc_provider_del() error handling interconnect: fix provider registration API interconnect: imx: fix registration race interconnect: qcom: osm-l3: fix registration race interconnect: qcom: rpm: fix probe child-node error handling interconnect: qcom: rpm: fix probe PM domain error handling interconnect: qcom: rpm: fix registration race interconnect: qcom: rpmh: fix probe child-node error handling interconnect: qcom: rpmh: fix registration race interconnect: qcom: msm8974: fix registration race interconnect: qcom: sm8450: fix registration race interconnect: qcom: sm8550: fix registration race interconnect: exynos: fix node leak in probe PM QoS error path interconnect: exynos: fix registration race interconnect: exynos: drop redundant link destroy memory: tegra: fix interconnect registration race memory: tegra124-emc: fix interconnect registration race memory: tegra20-emc: fix interconnect registration race memory: tegra30-emc: fix interconnect registration race interconnect: drop racy registration API interconnect: drop unused icc_get() interface interconnect: drop unused icc_link_destroy() interface drivers/interconnect/core.c | 149 +++++--------------------- drivers/interconnect/imx/imx.c | 20 ++-- drivers/interconnect/qcom/icc-rpm.c | 33 +++--- drivers/interconnect/qcom/icc-rpmh.c | 30 ++++-- drivers/interconnect/qcom/msm8974.c | 20 ++-- drivers/interconnect/qcom/osm-l3.c | 14 ++- drivers/interconnect/qcom/sm8450.c | 22 ++-- drivers/interconnect/qcom/sm8550.c | 22 ++-- drivers/interconnect/samsung/exynos.c | 30 +++--- drivers/memory/tegra/mc.c | 16 ++- drivers/memory/tegra/tegra124-emc.c | 12 +-- drivers/memory/tegra/tegra20-emc.c | 12 +-- drivers/memory/tegra/tegra30-emc.c | 12 +-- include/linux/interconnect-provider.h | 19 ++-- include/linux/interconnect.h | 8 -- 15 files changed, 154 insertions(+), 265 deletions(-) -- 2.39.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-02-01 10:17 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-01 10:15 Johan Hovold [this message] 2023-02-01 10:15 ` [PATCH 00/23] interconnect: fix racy provider registration Johan Hovold 2023-02-01 10:15 ` [PATCH 01/23] interconnect: fix mem leak when freeing nodes Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-01 11:18 ` Konrad Dybcio 2023-02-01 11:18 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 02/23] interconnect: fix icc_provider_del() error handling Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-01 11:16 ` Konrad Dybcio 2023-02-01 11:16 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 03/23] interconnect: fix provider registration API Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:48 ` Konrad Dybcio 2023-02-03 2:48 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 04/23] interconnect: imx: fix registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:49 ` Konrad Dybcio 2023-02-03 2:49 ` Konrad Dybcio 2023-02-03 16:01 ` Luca Ceresoli 2023-02-03 16:01 ` Luca Ceresoli 2023-02-06 8:09 ` Johan Hovold 2023-02-06 8:09 ` Johan Hovold 2023-02-06 20:52 ` Luca Ceresoli 2023-02-06 20:52 ` Luca Ceresoli 2023-02-01 10:15 ` [PATCH 05/23] interconnect: qcom: osm-l3: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:51 ` Konrad Dybcio 2023-02-03 2:51 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 06/23] interconnect: qcom: rpm: fix probe child-node error handling Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:52 ` Konrad Dybcio 2023-02-03 2:52 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 07/23] interconnect: qcom: rpm: fix probe PM domain " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:53 ` Konrad Dybcio 2023-02-03 2:53 ` Konrad Dybcio 2023-03-11 18:17 ` Christophe JAILLET 2023-03-11 18:17 ` Christophe JAILLET 2023-03-13 8:18 ` Johan Hovold 2023-03-13 8:18 ` Johan Hovold 2023-02-01 10:15 ` [PATCH 08/23] interconnect: qcom: rpm: fix registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:53 ` Konrad Dybcio 2023-02-03 2:53 ` Konrad Dybcio 2023-02-03 4:06 ` Jun Nie 2023-02-03 4:06 ` Jun Nie 2023-02-01 10:15 ` [PATCH 09/23] interconnect: qcom: rpmh: fix probe child-node error handling Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:54 ` Konrad Dybcio 2023-02-03 2:54 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 10/23] interconnect: qcom: rpmh: fix registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:55 ` Konrad Dybcio 2023-02-03 2:55 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 11/23] interconnect: qcom: msm8974: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 23:13 ` Brian Masney 2023-02-02 23:13 ` Brian Masney 2023-02-03 2:56 ` Konrad Dybcio 2023-02-03 2:56 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 12/23] interconnect: qcom: sm8450: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:56 ` Konrad Dybcio 2023-02-03 2:56 ` Konrad Dybcio 2023-02-06 12:10 ` Vinod Koul 2023-02-06 12:10 ` Vinod Koul 2023-02-01 10:15 ` [PATCH 13/23] interconnect: qcom: sm8550: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-01 10:20 ` Abel Vesa 2023-02-01 10:20 ` Abel Vesa 2023-02-03 2:57 ` Konrad Dybcio 2023-02-03 2:57 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 14/23] interconnect: exynos: fix node leak in probe PM QoS error path Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 10:58 ` Krzysztof Kozlowski 2023-02-02 10:58 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 15/23] interconnect: exynos: fix registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 11:04 ` Krzysztof Kozlowski 2023-02-02 11:04 ` Krzysztof Kozlowski 2023-02-02 12:17 ` Johan Hovold 2023-02-02 12:17 ` Johan Hovold 2023-02-02 12:20 ` Krzysztof Kozlowski 2023-02-02 12:20 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 16/23] interconnect: exynos: drop redundant link destroy Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 11:09 ` Krzysztof Kozlowski 2023-02-02 11:09 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 17/23] memory: tegra: fix interconnect registration race Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 18/23] memory: tegra124-emc: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 19/23] memory: tegra20-emc: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 20/23] memory: tegra30-emc: " Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-02 12:21 ` Krzysztof Kozlowski 2023-02-01 10:15 ` [PATCH 21/23] interconnect: drop racy registration API Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:58 ` Konrad Dybcio 2023-02-03 2:58 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 22/23] interconnect: drop unused icc_get() interface Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-03 2:59 ` Konrad Dybcio 2023-02-03 2:59 ` Konrad Dybcio 2023-02-01 10:15 ` [PATCH 23/23] interconnect: drop unused icc_link_destroy() interface Johan Hovold 2023-02-01 10:15 ` Johan Hovold 2023-02-02 11:13 ` [PATCH 00/23] interconnect: fix racy provider registration Krzysztof Kozlowski 2023-02-02 11:13 ` Krzysztof Kozlowski 2023-02-02 12:20 ` Johan Hovold 2023-02-02 12:20 ` Johan Hovold
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230201101559.15529-1-johan+linaro@kernel.org \ --to=johan+linaro@kernel.org \ --cc=a.swigon@samsung.com \ --cc=agross@kernel.org \ --cc=alim.akhtar@samsung.com \ --cc=andersson@kernel.org \ --cc=djakov@kernel.org \ --cc=festevam@gmail.com \ --cc=jonathanh@nvidia.com \ --cc=kernel@pengutronix.de \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=s.nawrocki@samsung.com \ --cc=shawnguo@kernel.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.