From: Alexandre Ghiti <alexghiti@rivosinc.com> To: Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Andrey Ryabinin <ryabinin.a.a@gmail.com>, Alexander Potapenko <glider@google.com>, Andrey Konovalov <andreyknvl@gmail.com>, Dmitry Vyukov <dvyukov@google.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Ard Biesheuvel <ardb@kernel.org>, Conor Dooley <conor@kernel.org>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-efi@vger.kernel.org Cc: Alexandre Ghiti <alexghiti@rivosinc.com> Subject: [PATCH v4 0/6] RISC-V kasan rework Date: Fri, 3 Feb 2023 08:52:26 +0100 [thread overview] Message-ID: <20230203075232.274282-1-alexghiti@rivosinc.com> (raw) As described in patch 2, our current kasan implementation is intricate, so I tried to simplify the implementation and mimic what arm64/x86 are doing. In addition it fixes UEFI bootflow with a kasan kernel and kasan inline instrumentation: all kasan configurations were tested on a large ubuntu kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST. inline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK outline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK Actually 1 test always fails with KASAN_KUNIT_TEST that I have to check: # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan__test.c:1020 KASAN failure expected in "set_bit(nr, addr)", but none occurrred Note that Palmer recently proposed to remove COMMAND_LINE_SIZE from the userspace abi https://lore.kernel.org/lkml/20221211061358.28035-1-palmer@rivosinc.com/T/ so that we can finally increase the command line to fit all kasan kernel parameters. All of this should hopefully fix the syzkaller riscv build that has been failing for a few months now, any test is appreciated and if I can help in any way, please ask. base-commit-tag: v6.2-rc6 v4: - Fix build warning by declaring create_tmp_mapping as static, kernel test robot v3: - Add AB from Ard in patch 4, thanks - Fix checkpatch issues in patch 1, thanks Conor v2: - Rebase on top of v6.2-rc3 - patch 4 is now way simpler than it used to be since Ard already moved the string functions into the efistub. Alexandre Ghiti (6): riscv: Split early and final KASAN population functions riscv: Rework kasan population functions riscv: Move DTB_EARLY_BASE_VA to the kernel address space riscv: Fix EFI stub usage of KASAN instrumented strcmp function riscv: Fix ptdump when KASAN is enabled riscv: Unconditionnally select KASAN_VMALLOC if KASAN arch/riscv/Kconfig | 1 + arch/riscv/kernel/image-vars.h | 2 - arch/riscv/mm/init.c | 2 +- arch/riscv/mm/kasan_init.c | 516 ++++++++++++++++++--------------- arch/riscv/mm/ptdump.c | 24 +- 5 files changed, 298 insertions(+), 247 deletions(-) -- 2.37.2
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Ghiti <alexghiti@rivosinc.com> To: Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Andrey Ryabinin <ryabinin.a.a@gmail.com>, Alexander Potapenko <glider@google.com>, Andrey Konovalov <andreyknvl@gmail.com>, Dmitry Vyukov <dvyukov@google.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Ard Biesheuvel <ardb@kernel.org>, Conor Dooley <conor@kernel.org>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-efi@vger.kernel.org Cc: Alexandre Ghiti <alexghiti@rivosinc.com> Subject: [PATCH v4 0/6] RISC-V kasan rework Date: Fri, 3 Feb 2023 08:52:26 +0100 [thread overview] Message-ID: <20230203075232.274282-1-alexghiti@rivosinc.com> (raw) As described in patch 2, our current kasan implementation is intricate, so I tried to simplify the implementation and mimic what arm64/x86 are doing. In addition it fixes UEFI bootflow with a kasan kernel and kasan inline instrumentation: all kasan configurations were tested on a large ubuntu kernel with success with KASAN_KUNIT_TEST and KASAN_MODULE_TEST. inline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK outline ubuntu config + uefi: sv39: OK sv48: OK sv57: OK Actually 1 test always fails with KASAN_KUNIT_TEST that I have to check: # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan__test.c:1020 KASAN failure expected in "set_bit(nr, addr)", but none occurrred Note that Palmer recently proposed to remove COMMAND_LINE_SIZE from the userspace abi https://lore.kernel.org/lkml/20221211061358.28035-1-palmer@rivosinc.com/T/ so that we can finally increase the command line to fit all kasan kernel parameters. All of this should hopefully fix the syzkaller riscv build that has been failing for a few months now, any test is appreciated and if I can help in any way, please ask. base-commit-tag: v6.2-rc6 v4: - Fix build warning by declaring create_tmp_mapping as static, kernel test robot v3: - Add AB from Ard in patch 4, thanks - Fix checkpatch issues in patch 1, thanks Conor v2: - Rebase on top of v6.2-rc3 - patch 4 is now way simpler than it used to be since Ard already moved the string functions into the efistub. Alexandre Ghiti (6): riscv: Split early and final KASAN population functions riscv: Rework kasan population functions riscv: Move DTB_EARLY_BASE_VA to the kernel address space riscv: Fix EFI stub usage of KASAN instrumented strcmp function riscv: Fix ptdump when KASAN is enabled riscv: Unconditionnally select KASAN_VMALLOC if KASAN arch/riscv/Kconfig | 1 + arch/riscv/kernel/image-vars.h | 2 - arch/riscv/mm/init.c | 2 +- arch/riscv/mm/kasan_init.c | 516 ++++++++++++++++++--------------- arch/riscv/mm/ptdump.c | 24 +- 5 files changed, 298 insertions(+), 247 deletions(-) -- 2.37.2 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2023-02-03 7:52 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-03 7:52 Alexandre Ghiti [this message] 2023-02-03 7:52 ` [PATCH v4 0/6] RISC-V kasan rework Alexandre Ghiti 2023-02-03 7:52 ` [PATCH v4 1/6] riscv: Split early and final KASAN population functions Alexandre Ghiti 2023-02-03 7:52 ` Alexandre Ghiti 2023-02-17 11:50 ` Björn Töpel 2023-02-17 11:50 ` Björn Töpel 2023-02-03 7:52 ` [PATCH v4 2/6] riscv: Rework kasan " Alexandre Ghiti 2023-02-03 7:52 ` Alexandre Ghiti 2023-02-17 14:54 ` Björn Töpel 2023-02-17 14:54 ` Björn Töpel 2023-02-03 7:52 ` [PATCH v4 3/6] riscv: Move DTB_EARLY_BASE_VA to the kernel address space Alexandre Ghiti 2023-02-03 7:52 ` Alexandre Ghiti 2023-02-17 14:58 ` Björn Töpel 2023-02-17 14:58 ` Björn Töpel 2023-02-03 7:52 ` [PATCH v4 4/6] riscv: Fix EFI stub usage of KASAN instrumented strcmp function Alexandre Ghiti 2023-02-03 7:52 ` Alexandre Ghiti 2023-02-03 7:58 ` Atish Patra 2023-02-03 7:58 ` Atish Patra 2023-02-03 7:52 ` [PATCH v4 5/6] riscv: Fix ptdump when KASAN is enabled Alexandre Ghiti 2023-02-03 7:52 ` Alexandre Ghiti 2023-02-17 14:55 ` Björn Töpel 2023-02-17 14:55 ` Björn Töpel 2023-02-03 7:52 ` [PATCH v4 6/6] riscv: Unconditionnally select KASAN_VMALLOC if KASAN Alexandre Ghiti 2023-02-03 7:52 ` Alexandre Ghiti 2023-02-17 14:57 ` Björn Töpel 2023-02-17 14:57 ` Björn Töpel 2023-03-08 3:29 ` [PATCH v4 0/6] RISC-V kasan rework Palmer Dabbelt 2023-03-08 3:29 ` Palmer Dabbelt 2023-03-08 3:45 ` Palmer Dabbelt 2023-03-08 3:45 ` Palmer Dabbelt 2023-03-08 3:30 ` patchwork-bot+linux-riscv 2023-03-08 3:30 ` patchwork-bot+linux-riscv 2023-04-19 14:56 ` Palmer Dabbelt 2023-04-19 14:56 ` Palmer Dabbelt 2023-04-20 17:36 ` Palmer Dabbelt 2023-04-20 17:36 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230203075232.274282-1-alexghiti@rivosinc.com \ --to=alexghiti@rivosinc.com \ --cc=andreyknvl@gmail.com \ --cc=aou@eecs.berkeley.edu \ --cc=ardb@kernel.org \ --cc=conor@kernel.org \ --cc=dvyukov@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=ryabinin.a.a@gmail.com \ --cc=vincenzo.frascino@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.