All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, danielhb413@gmail.com,
	peter.maydell@linaro.org, "BALATON Zoltan" <balaton@eik.bme.hu>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 03/16] ppc/pegasos2: Improve readability of VIA south bridge creation
Date: Sun,  5 Feb 2023 07:04:36 -0300	[thread overview]
Message-ID: <20230205100449.2352781-4-danielhb413@gmail.com> (raw)
In-Reply-To: <20230205100449.2352781-1-danielhb413@gmail.com>

From: BALATON Zoltan <balaton@eik.bme.hu>

Slightly improve readability of creating the south btidge by cnamging
type of a local variable to avoid some casts within function arguments
which makes some lines shorter and easier to read.
Also remove an unneded line break.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230117214545.5E191746369@zero.eik.bme.hu>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 hw/ppc/pegasos2.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index f46d4bf51d..1a13632ba6 100644
--- a/hw/ppc/pegasos2.c
+++ b/hw/ppc/pegasos2.c
@@ -102,7 +102,8 @@ static void pegasos2_init(MachineState *machine)
     CPUPPCState *env;
     MemoryRegion *rom = g_new(MemoryRegion, 1);
     PCIBus *pci_bus;
-    PCIDevice *dev, *via;
+    Object *via;
+    PCIDevice *dev;
     I2CBus *i2c_bus;
     const char *fwname = machine->firmware ?: PROM_FILENAME;
     char *filename;
@@ -159,19 +160,18 @@ static void pegasos2_init(MachineState *machine)
     pci_bus = mv64361_get_pci_bus(pm->mv, 1);
 
     /* VIA VT8231 South Bridge (multifunction PCI device) */
-    via = pci_create_simple_multifunction(pci_bus, PCI_DEVFN(12, 0), true,
-                                          TYPE_VT8231_ISA);
+    via = OBJECT(pci_create_simple_multifunction(pci_bus, PCI_DEVFN(12, 0),
+                                                 true, TYPE_VT8231_ISA));
     object_property_add_alias(OBJECT(machine), "rtc-time",
-                              object_resolve_path_component(OBJECT(via),
-                                                            "rtc"),
+                              object_resolve_path_component(via, "rtc"),
                               "date");
     qdev_connect_gpio_out(DEVICE(via), 0,
                           qdev_get_gpio_in_named(pm->mv, "gpp", 31));
 
-    dev = PCI_DEVICE(object_resolve_path_component(OBJECT(via), "ide"));
+    dev = PCI_DEVICE(object_resolve_path_component(via, "ide"));
     pci_ide_create_devs(dev);
 
-    dev = PCI_DEVICE(object_resolve_path_component(OBJECT(via), "pm"));
+    dev = PCI_DEVICE(object_resolve_path_component(via, "pm"));
     i2c_bus = I2C_BUS(qdev_get_child_bus(DEVICE(dev), "i2c"));
     spd_data = spd_data_generate(DDR, machine->ram_size);
     smbus_eeprom_init_one(i2c_bus, 0x57, spd_data);
-- 
2.39.1



  parent reply	other threads:[~2023-02-05 10:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-05 10:04 [PULL 00/16] ppc queue Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 01/16] tests/migration: add sysprof-capture-4 as dependency for stress binary Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 02/16] tests/migration: add support for ppc64le for guestperf.py Daniel Henrique Barboza
2023-02-05 10:04 ` Daniel Henrique Barboza [this message]
2023-02-05 10:04 ` [PULL 04/16] hw/pci-host/mv64361: Reuse pci_swizzle_map_irq_fn Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 05/16] hw/ppc: Set machine->fdt in e500 machines Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 06/16] hw/ppc/e500{, plat}: Drop redundant checks for presence of platform bus Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 07/16] hw/ppc/e500.c: Avoid hardcoding parent device in create_devtree_etsec() Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 08/16] hw/ppc/e500.c: Attach eSDHC unimplemented region to ccsr_addr_space Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 09/16] ppc/pnv/pci: Cleanup PnvPHBPecState structure Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 10/16] ppc/pnv/pci: Remove duplicate definition of PNV_PHB5_DEVICE_ID Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 11/16] ppc/pnv/pci: Update PHB5 version register Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 12/16] ppc/pnv/pci: Fix PHB xscom registers memory region name Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 13/16] hw/ppc/pegasos2: Fix a typo in a comment Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 14/16] hw/display/sm501: Remove parenthesis around constant macro definitions Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 15/16] hw/display/sm501: Remove unneeded casts from void pointer Daniel Henrique Barboza
2023-02-05 10:04 ` [PULL 16/16] hw/display/sm501: Code style fix Daniel Henrique Barboza
2023-02-06 11:37 ` [PULL 00/16] ppc queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230205100449.2352781-4-danielhb413@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=balaton@eik.bme.hu \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.